Hide Forgot
Created attachment 1695268 [details] sap-preconfigure Created attachment 1695268 [details] sap-preconfigure Created attachment 1695268 [details] sap-preconfigure Description of problem: We need to build a new version based on upstream version 2.0.0, without any code which is not relevant for RHEL 7 and RHEL 8. Version-Release number of selected component (if applicable): 2.0.0 How reproducible: Steps to Reproduce: 1. 2. 3. Actual results: Expected results: Additional info: The attached tar files only contain code which is relevant for RHEL 7 and RHEL 8.
Created attachment 1695269 [details] sap-netweaver-preconfigure
Created attachment 1695270 [details] sap-hana-preconfigure
Please don't sign BZes with an empty comment #0 The attached playbook failed for me with TASK [sap-preconfigure : Verify that the DNS domain is set] *********************************** fatal: [localhost]: FAILED! => { "assertion": "not( (sap_domain is undefined) or (sap_domain is none) or (sap_domain | trim == '') )", "changed": false, "evaluated_to": false, "msg": "You need to define the variable 'sap_domain' in defaults/main.yml." }
Created attachment 1696025 [details] sap-hana-preconfigure
Discovered and fixed 3 new issues: https://github.com/linux-system-roles/sap-hana-preconfigure/issues/92 - firewalld installation state detection not working https://github.com/linux-system-roles/sap-hana-preconfigure/issues/90 - File /etc/init.d/boot.local should have permissions of 0755 (configure-epb.yml) https://github.com/linux-system-roles/sap-hana-preconfigure/issues/89 - task disable-firewall.yml in 2009879_7.yml also needs single step execution support I also provided a new version of sap-hana-preconfigure, dated 2020-06-08 09:33 UTC. Please let me know if you want me to delete the old version and/or if you would like me to provide a diff output.
(In reply to Bernd Finger from comment #7) > Discovered and fixed 3 new issues: > https://github.com/linux-system-roles/sap-hana-preconfigure/issues/92 - > firewalld installation state detection not working > https://github.com/linux-system-roles/sap-hana-preconfigure/issues/90 - File > /etc/init.d/boot.local should have permissions of 0755 (configure-epb.yml) > https://github.com/linux-system-roles/sap-hana-preconfigure/issues/89 - task > disable-firewall.yml in 2009879_7.yml also needs single step execution > support > > I also provided a new version of sap-hana-preconfigure, dated 2020-06-08 > 09:33 UTC. Please let me know if you want me to delete the old version > and/or if you would like me to provide a diff output. Bernd, i would prefer to use the tarballs from: https://github.com/berndfinger/sap-preconfigure/releases/download/2.0.0/sap-preconfigure.tar.gz https://github.com/berndfinger/sap-hana-preconfigure/releases/download/2.0.0/sap-hana-preconfigure.tar.gz https://github.com/berndfinger/sap-netweaver-preconfigure/releases/download/2.0.0/sap-netweaver-preconfigure.tar.gz and add the additional fixes to the above tarballs. It prevents the error in rpmdiff in errata-tools! It seems the tarball which are attached in bugzilla are not the same from github.
The tarballs in the upstream code have all the non-RHEL-7, non-RHEL8 code in it. For the tarball I attached here, I used the script I will now attach to this bug, named create-rhel-system-roles-sap-tar.sh. But even that one does a git pull of the latest status. Also I did not yet update the upstream tarball with the latest pull request which I used for the last tar file in here.
Created attachment 1696122 [details] script for creating tarballs from upstream
I found /usr/share/ansible/roles/sap-hana-preconfigure/tasks/sapnote/1944799.yml in rhel-system-roles-sap.noarch 2.0.0-1.el8. This file is for SLES and should not be delivered in rhel-system-roles-sap. I also found it in the new version at https://brewweb.engineering.redhat.com/brew/rpminfo?rpmID=8229419 . The script https://bugzilla.redhat.com/attachment.cgi?id=1696122 should exclude it but maybe there is a typo in it which prevents the exclusion?
(In reply to Bernd Finger from comment #20) > I found > /usr/share/ansible/roles/sap-hana-preconfigure/tasks/sapnote/1944799.yml in > rhel-system-roles-sap.noarch 2.0.0-1.el8. This file is for SLES and should > not be delivered in rhel-system-roles-sap. I also found it in the new > version at https://brewweb.engineering.redhat.com/brew/rpminfo?rpmID=8229419 > . > > The script https://bugzilla.redhat.com/attachment.cgi?id=1696122 should > exclude it but maybe there is a typo in it which prevents the exclusion? yes, it's a typo bug in script. This issue is now fixed in rhel-system-roles-sap-2.0.0-3.el8. Bernd, thank for checking!
Since the problem described in this bug report should be resolved in a recent advisory, it has been closed with a resolution of ERRATA. For information on the advisory (rhel-system-roles-sap bug fix and enhancement update), and where to find the updated files, follow the link below. If the solution does not work for you, open a new bug report. https://access.redhat.com/errata/RHBA-2020:4612