This bug was initially created as a copy of Bug #1829711 Description of problem: "migrate-set-cache-size" is deprecated since qemu-4.2 from qemu.org [1] and should be replaced by 'migrate-set-parameters'. https://wiki.qemu.org/ChangeLog/4.2#Migration When fixing this, please also adjust the test case to mark the command as okay to be removed. Version-Release number of selected component (if applicable): How reproducible: Steps to Reproduce: 1. 2. 3. Actual results: Expected results: Additional info:
*** This bug has been marked as a duplicate of bug 1829544 ***
Hi Jirka, This bz is about Stop using deprecated "migrate-set-cache-size", not duplicate with bug 1829544: Stop using deprecated "query-migrate-cache-size" Please help reopen it if I'm right
Ah, and I looked at the bugs at least twice to check whether they are duplicates and still I didn't notice the QMP command is slightly different. Sorry for the noise.
Patches sent upstream for review: https://www.redhat.com/archives/libvir-list/2020-June/msg00444.html
Fixed upstream by commit 2481fcea957000a35316031f759fdade428355c8 Refs: v6.4.0-126-g2481fcea95 Author: Jiri Denemark <jdenemar> AuthorDate: Wed Jun 10 16:13:15 2020 +0200 Commit: Jiri Denemark <jdenemar> CommitDate: Wed Jun 17 10:25:33 2020 +0200 qemu: Avoid deprecated migrate-set-cache-size QMP command The same functionality can be achieved using migrate-set-parameters QMP command with xbzrle-cache-size parameter. https://bugzilla.redhat.com/show_bug.cgi?id=1845012 Signed-off-by: Jiri Denemark <jdenemar> Reviewed-by: Peter Krempa <pkrempa>
Reproduce with: libvirt-client-6.4.0-1.module+el8.3.0+6881+88468c00.x86_64 qemu-kvm-4.1.0-14.module+el8.2.0+4670+07fe2774.x86_64 1) set cache size by virsh migrate-compcache, migrate-set-cache-size/query-migrate-cache-size is used: # virsh migrate-compcache rhel7-min --size=536870912 Compression cache: 512.000 MiB 2020-07-31 08:09:33.502+0000: 40506: info : qemuMonitorSend:935 : QEMU_MONITOR_SEND_MSG: mon=0x7f6af0036b20 msg={"execute":"migrate-set-cache-size","arguments":{"value":536870912},"id":"libvirt-288"} 2020-07-31 08:09:33.504+0000: 40508: info : qemuMonitorSend:935 : QEMU_MONITOR_SEND_MSG: mon=0x7f6af0036b20 msg={"execute":"query-migrate-cache-size","id":"libvirt-289"} 2) do live migration with --comp-xzbrle-size, migrate-set-parameters is used # virsh migrate rhel7-min qemu+ssh://10.0.150.207/system --live --verbose --tls --compressed --comp-xbzrle-cache 268435456 --comp-methods xbzrle 2020-07-31 08:10:19.744+0000: 40507: info : qemuMonitorSend:935 : QEMU_MONITOR_SEND_MSG: mon=0x7f6af0036b20 msg={"execute":"migrate-set-parameters","arguments":{"tls-creds":"objlibvirt_migrate_tls0","tls-hostname":"fjin-1","xbzrle-cache-size":268435456},"id":"libvirt-296"}
Verify with qemu-kvm that supports migrate-set-parameters: libvirt-client-6.5.0-1.module+el8.3.0+7323+d54bb644.x86_64 qemu-kvm-5.0.0-0.module+el8.3.0+6620+5d5e1420.x86_64 migrate-set-parameters is used in following steps: 1) # virsh migrate-compcache rhel7-min --size=536870912 2) # virsh migrate rhel7-min qemu+ssh://10.0.150.207/system --live --verbose --tls --compressed --comp-xbzrle-cache 268435456 --comp-methods xbzrle Still need to verify with qemu-kvm that doesn't support migrate-set-parameters
(In reply to Fangge Jin from comment #10) > Still need to verify with qemu-kvm that doesn't support > migrate-set-parameters To test this scenario, I will have to test upgrade from RHEL7.5 to RHELAV-8.3, which is not supported. So this bug can be marked as verified.
Since the problem described in this bug report should be resolved in a recent advisory, it has been closed with a resolution of ERRATA. For information on the advisory (virt:8.3 bug fix and enhancement update), and where to find the updated files, follow the link below. If the solution does not work for you, open a new bug report. https://access.redhat.com/errata/RHBA-2020:5137