RHEL Engineering is moving the tracking of its product development work on RHEL 6 through RHEL 9 to Red Hat Jira (issues.redhat.com). If you're a Red Hat customer, please continue to file support cases via the Red Hat customer portal. If you're not, please head to the "RHEL project" in Red Hat Jira and file new tickets here. Individual Bugzilla bugs in the statuses "NEW", "ASSIGNED", and "POST" are being migrated throughout September 2023. Bugs of Red Hat partners with an assigned Engineering Partner Manager (EPM) are migrated in late September as per pre-agreed dates. Bugs against components "kernel", "kernel-rt", and "kpatch" are only migrated if still in "NEW" or "ASSIGNED". If you cannot log in to RH Jira, please consult article #7032570. That failing, please send an e-mail to the RH Jira admins at rh-issues@redhat.com to troubleshoot your issue as a user management inquiry. The email creates a ServiceNow ticket with Red Hat. Individual Bugzilla bugs that are migrated will be moved to status "CLOSED", resolution "MIGRATED", and set with "MigratedToJIRA" in "Keywords". The link to the successor Jira issue will be found under "Links", have a little "two-footprint" icon next to it, and direct you to the "RHEL project" in Red Hat Jira (issue links are of type "https://issues.redhat.com/browse/RHEL-XXXX", where "X" is a digit). This same link will be available in a blue banner at the top of the page informing you that that bug has been migrated.

Description of problem:
NM fails to activate slaves when there are multiple stacked devices and autoconnect-slaves=1.


Version-Release number of selected component (if applicable):
1.22.8-4.el8 and upstream master


How reproducible:
50%


Steps to Reproduce:
  nmcli connection add type bridge ifname ovirtmgmt con-name ovirtmgmt+ ip4 172.25.1.1/32 connection.autoconnect-slaves 1
  nmcli connection add type bond ifname bond0 con-name bond0+ connection.master ovirtmgmt connection.slave-type bridge
  nmcli connection add type ethernet ifname eth2 con-name slave+ connection.master bond0 connection.slave-type bond

  # simulate reboot
  systemctl stop NetworkManager
  rm -rf /run/NetworkManager
  ip link delete bond0 2> /dev/null
  ip link delete ovirtmgmt 2> /dev/null
  systemctl start NetworkManager
  sleep 4

  nmcli device


Actual results:
eth2 is stuck in connecting (prepare)


Expected results:
eth2 successfully connects


Additional info:
I believe the bug was introduced by the fix for bz 1548265.

Created attachment 1696027 [details]
Reproducer script

Upstream merge request:

https://gitlab.freedesktop.org/NetworkManager/NetworkManager/-/merge_requests/532

This really does not work?

We have at least this test that is covering that:
https://gitlab.freedesktop.org/NetworkManager/NetworkManager-ci/-/blob/master/nmcli/features/bond.feature#L1283

Does it mean we want to set connection.autoconnect-slaves 1 to the top most master only?

Thank you for clarification.

(In reply to Vladimir Benes from comment #3)
> This really does not work?
> 
> We have at least this test that is covering that:
> https://gitlab.freedesktop.org/NetworkManager/NetworkManager-ci/-/blob/
> master/nmcli/features/bond.feature#L1283
> 
> Does it mean we want to set connection.autoconnect-slaves 1 to the top most
> master only?

I think the problem is caused by having both autoconnect-slaves=yes on the topmost master and autoconnect=yes on its slave, which causes a race condition in the lowest slave.

New merge request: https://gitlab.freedesktop.org/NetworkManager/NetworkManager/-/merge_requests/568

CI test added:
https://gitlab.freedesktop.org/NetworkManager/NetworkManager-ci/-/merge_requests/610

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (NetworkManager bug fix and enhancement update), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2020:4499