Bug 1845210 - Backport patch for reading SELinux labels before policy load
Summary: Backport patch for reading SELinux labels before policy load
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: Fedora
Classification: Fedora
Component: kernel
Version: 32
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Kernel Maintainer List
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2020-06-08 16:41 UTC by Jonathan Lebon
Modified: 2021-04-29 16:53 UTC (History)
21 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2021-04-29 16:53:31 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)

Description Jonathan Lebon 2020-06-08 16:41:48 UTC
This bug was initially created as a copy of Bug #1839819

I've submitted a kernel patch upstream[1] that I'd like to consider for backporting to f32 (i.e. kernel-5.6). It's not yet merged upstream because it didn't make the merge window. I am filing this issue now so that we can prepare for backporting it when it is merged. There is work underway to also have it backported to RHEL.

This patch is in essence similar to https://bugzilla.redhat.com/show_bug.cgi?id=1758597, but for *reading* SELinux labels rather than writing. Together these patches will unblock the ability for FCOS to reprovision the rootfs.

Thanks!

Patch: https://lore.kernel.org/selinux/20200528143938.209364-1-jlebon@redhat.com/

Ack from upstream: https://lore.kernel.org/selinux/CAHC9VhRy6hYVYTgxDxek+2Xv6tDbJy4GOGC3h2m5-VYDLG2iSA@mail.gmail.com/

Comment 1 Jonathan Lebon 2020-06-24 13:08:19 UTC
This was merged upstream now: https://lore.kernel.org/selinux/CAHC9VhQs+PVbxMNh9s78yO_bGk_Feii4x=dVxZUcK=OoqP6sUw@mail.gmail.com/
Can we start the backport process?

Comment 2 Jonathan Lebon 2020-06-29 20:34:48 UTC
Any way someone could take a look at this? The RHEL 8.3 version of this bug is moving forward, but we'd really like to do things properly and leverage this in Fedora CoreOS first before adding it to RHCOS.

Happy to help, though not sure on what the procedure is here. I can submit a dist-git PR, but it seems like it's not used much overall? (Last merged PR was 7 months ago.)

Comment 3 Peter Robinson 2020-07-07 16:40:12 UTC
> This was merged upstream now:

I think you mean this was accepted for upstream, it's not yet landed into the 5.8 dev cycle. Is it due to land in 5.8 or 5.9?

Comment 4 Jonathan Lebon 2020-07-07 18:05:34 UTC
> I think you mean this was accepted for upstream, it's not yet landed into the 5.8 dev cycle. Is it due to land in 5.8 or 5.9?

It missed 5.8 and should land in 5.9.

Comment 5 Peter Robinson 2020-07-12 11:34:08 UTC
I've pushed this to f31/f32 kernel builds so it will be in the next Fedora kernel, probably 5.7.9

Comment 6 Peter Robinson 2020-07-12 11:38:59 UTC
Also a MR to ensure it's in 5.8 too and doesn't get lost on rebase:
https://gitlab.com/cki-project/kernel-ark/-/merge_requests/507

Comment 7 Fedora Program Management 2021-04-29 16:30:18 UTC
This message is a reminder that Fedora 32 is nearing its end of life.
Fedora will stop maintaining and issuing updates for Fedora 32 on 2021-05-25.
It is Fedora's policy to close all bug reports from releases that are no longer
maintained. At that time this bug will be closed as EOL if it remains open with a
Fedora 'version' of '32'.

Package Maintainer: If you wish for this bug to remain open because you
plan to fix it in a currently maintained version, simply change the 'version' 
to a later Fedora version.

Thank you for reporting this issue and we are sorry that we were not 
able to fix it before Fedora 32 is end of life. If you would still like 
to see this bug fixed and are able to reproduce it against a later version 
of Fedora, you are encouraged  change the 'version' to a later Fedora 
version prior this bug is closed as described in the policy above.

Although we aim to fix as many bugs as possible during every release's 
lifetime, sometimes those efforts are overtaken by events. Often a 
more recent Fedora release includes newer upstream software that fixes 
bugs or makes them obsolete.

Comment 8 Jonathan Lebon 2021-04-29 16:53:31 UTC
This was done.


Note You need to log in before you can comment on or make changes to this bug.