Spec URL: https://tieugene.fedorapeople.org/rpms/python-kyotocabinet/python-kyotocabinet.spec SRPM URL: https://tieugene.fedorapeople.org/rpms/python-kyotocabinet/python-kyotocabinet-1.22-1.fc32.src.rpm Description: Kyoto Cabinet is very fast key-value storage. Koji builds: f31: https://koji.fedoraproject.org/koji/taskinfo?taskID=45556167 f32: https://koji.fedoraproject.org/koji/taskinfo?taskID=45556194 f33: https://koji.fedoraproject.org/koji/taskinfo?taskID=45556209 Fedora Account System Username: tieugene
Source1: https://www.gnu.org/licenses/gpl-3.0.txt %prep %setup0 -q -n %{module}-python-%{version} cp %{SOURCE1} COPYING This is not okay, see https://docs.fedoraproject.org/en-US/packaging-guidelines/LicensingGuidelines/#_license_text
(In reply to Susi Lehtola from comment #1) > Source1: https://www.gnu.org/licenses/gpl-3.0.txt > > %prep > %setup0 -q -n %{module}-python-%{version} > cp %{SOURCE1} COPYING > > > This is not okay, see > https://docs.fedoraproject.org/en-US/packaging-guidelines/ > LicensingGuidelines/#_license_text As for README this file (COPYING) _must_ be in tarball (look inside). But seems the author[s] simply forget this. I send email to them, but there is no any warranty. And no one any other "official" source tarball.
(In reply to Eugene A. Pivnev from comment #2) > (In reply to Susi Lehtola from comment #1) > > Source1: https://www.gnu.org/licenses/gpl-3.0.txt > > > > %prep > > %setup0 -q -n %{module}-python-%{version} > > cp %{SOURCE1} COPYING > > > > > > This is not okay, see > > https://docs.fedoraproject.org/en-US/packaging-guidelines/ > > LicensingGuidelines/#_license_text > > As for README this file (COPYING) _must_ be in tarball (look inside). > But seems the author[s] simply forget this. > > I send email to them, but there is no any warranty. > And no one any other "official" source tarball. Asking upstream is sufficient, you shouldn't join your own License copy. - Group is not used in Fedora - Globbing the entire %{python3_sitearch} is forbidden, please be more specific instead: %{python3_sitearch}/Kyoto_Cabinet-1.5-py*.egg-info %{python3_sitearch}/kyotocabinet*.so - License: GLPv3 → License: GPLv3 - Install example/ as %doc? - %define module kyotocabinet → %global module kyotocabinet Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed Issues: ======= - Package contains BR: python2-devel or python3-devel - Python packages must not contain %{pythonX_site(lib|arch)}/* in %files Note: Package contains %{pythonX_site(lib|arch)}/* in %files See: https://pagure.io/packaging-committee/issue/782 ===== MUST items ===== C/C++: [x]: Development (unversioned) .so files in -devel subpackage, if present. Note: Unversioned so-files in private %_libdir subdirectory (see attachment). Verify they are not in ld path. Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [!]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "GNU General Public License (v3)", "GPL (v3 or later)". 27 files have unknown license. Detailed output of licensecheck in /home/bob/packaging/review/python-kyotocabinet/review- python-kyotocabinet/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 317440 bytes in 21 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local Python: [x]: Python eggs must not download any dependencies during the build process. [x]: A package which is used by another package via an egg interface should provide egg info. [x]: Package meets the Packaging Guidelines::Python [x]: Packages MUST NOT have dependencies (either build-time or runtime) on packages named with the unversioned python- prefix unless no properly versioned package exists. Dependencies on Python packages instead MUST use names beginning with python2- or python3- as appropriate. [x]: Binary eggs must be removed in %prep ===== SHOULD items ===== Generic: [x]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [-]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in python3-kyotocabinet [?]: Package functions as described. [x]: Latest version is packaged. [!]: Package does not include license text files separate from upstream. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [-]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [!]: Spec use %global instead of %define unless justified. Note: %define requiring justification: %define module kyotocabinet [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: python3-kyotocabinet-1.22-1.fc33.x86_64.rpm python-kyotocabinet-debugsource-1.22-1.fc33.x86_64.rpm python-kyotocabinet-1.22-1.fc33.src.rpm python3-kyotocabinet.x86_64: W: invalid-license GLPv3 python-kyotocabinet-debugsource.x86_64: W: invalid-license GLPv3 python-kyotocabinet.src: W: invalid-license GLPv3 3 packages and 0 specfiles checked; 0errors, 3 warnings.
(In reply to Robert-André Mauchin from comment #3) > Asking upstream is sufficient, you shouldn't join your own License copy. Fixed. URL to vendor's license reference added. > - Group is not used in Fedora Fixed. > - Globbing the entire %{python3_sitearch} is forbidden, please be more > specific instead: > > %{python3_sitearch}/Kyoto_Cabinet-1.5-py*.egg-info > %{python3_sitearch}/kyotocabinet*.so Fixed, thank you. > - License: GLPv3 → License: GPLv3 Fixed. > - Install example/ as %doc? Added. > - %define module kyotocabinet → %global module kyotocabinet Fixed. ==== SPEC: https://tieugene.fedorapeople.org/rpms/python-kyotocabinet/python-kyotocabinet.spec SRPM: https://tieugene.fedorapeople.org/rpms/python-kyotocabinet/python-kyotocabinet-1.22-2.fc32.src.rpm Koji builds: - f33: https://koji.fedoraproject.org/koji/taskinfo?taskID=46285578 - f32: https://koji.fedoraproject.org/koji/taskinfo?taskID=46285740 - f31: https://koji.fedoraproject.org/koji/taskinfo?taskID=46285947
Package approved.
(fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/python-kyotocabinet