RHEL Engineering is moving the tracking of its product development work on RHEL 6 through RHEL 9 to Red Hat Jira (issues.redhat.com). If you're a Red Hat customer, please continue to file support cases via the Red Hat customer portal. If you're not, please head to the "RHEL project" in Red Hat Jira and file new tickets here. Individual Bugzilla bugs in the statuses "NEW", "ASSIGNED", and "POST" are being migrated throughout September 2023. Bugs of Red Hat partners with an assigned Engineering Partner Manager (EPM) are migrated in late September as per pre-agreed dates. Bugs against components "kernel", "kernel-rt", and "kpatch" are only migrated if still in "NEW" or "ASSIGNED". If you cannot log in to RH Jira, please consult article #7032570. That failing, please send an e-mail to the RH Jira admins at rh-issues@redhat.com to troubleshoot your issue as a user management inquiry. The email creates a ServiceNow ticket with Red Hat. Individual Bugzilla bugs that are migrated will be moved to status "CLOSED", resolution "MIGRATED", and set with "MigratedToJIRA" in "Keywords". The link to the successor Jira issue will be found under "Links", have a little "two-footprint" icon next to it, and direct you to the "RHEL project" in Red Hat Jira (issue links are of type "https://issues.redhat.com/browse/RHEL-XXXX", where "X" is a digit). This same link will be available in a blue banner at the top of the page informing you that that bug has been migrated.
Bug 1845418 - The linux bridge `ageing_time` should not be mulitple by 100
Summary: The linux bridge `ageing_time` should not be mulitple by 100
Keywords:
Status: CLOSED NOTABUG
Alias: None
Product: Red Hat Enterprise Linux 8
Classification: Red Hat
Component: NetworkManager
Version: ---
Hardware: x86_64
OS: All
unspecified
high
Target Milestone: rc
: 8.3
Assignee: sushil kulkarni
QA Contact: Desktop QE
URL:
Whiteboard:
Depends On:
Blocks: nmstate-nm
TreeView+ depends on / blocked
 
Reported: 2020-06-09 07:54 UTC by Gris Ge
Modified: 2020-06-09 12:10 UTC (History)
8 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2020-06-09 12:10:48 UTC
Type: Bug
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)

Description Gris Ge 2020-06-09 07:54:19 UTC
Description of problem:


The sysfs already convert the jiffies into seconds before showing,
NM should not multiple it by 100.

Kernel code(br_sysfs_br.c) is:

static ssize_t ageing_time_show(struct device *d,
				struct device_attribute *attr, char *buf)
{
	struct net_bridge *br = to_bridge(d);
	return sprintf(buf, "%lu\n", jiffies_to_clock_t(br->ageing_time));
}


Version-Release number of selected component (if applicable):
NetworkManager-1.25.2-25985.d1e8eb791c.el8.x86_64

How reproducible:
100%

Steps to Reproduce:
1. sudo nmcli c add type bridge ifname br0
2. cat /sys/class/net/br0/bridge/ageing_time
3.

Actual results:

30000

Expected results:

300

Additional info:

Please also check with other bridge options on this `user_hz_compensate = TRUE`.
I believe all sysfs bridge option is converted to seconds.

Comment 1 Thomas Haller 2020-06-09 09:29:16 UTC
The bridge.ageing-time property in NetworkManager is in seconds (with a default of 300). It's also documented that way.

The sysctl value is in a different unit (1/100 of a second).

Of course, if NM configures a aging-time of 300 seconds, then the value on sysctl reads as "30000 1/100 seconds".

What is wrong with that?

Comment 2 Thomas Haller 2020-06-09 09:31:45 UTC
The problem here is that the setting in kernel has a wider range (supporting sub-seconds precision).
In NetworkManager API you currently cannot express such values.

The real problem is that this is public API, and it cannot be changed. It could only be deprecated and extended with a new value, which is a painful thing to do.

Comment 3 Gris Ge 2020-06-09 12:10:30 UTC
aha. My fault. It was multiple by the USER_HZ which could be retrieved via `os.sysconf("SC_CLK_TCK")` in python.


Note You need to log in before you can comment on or make changes to this bug.