RHEL Engineering is moving the tracking of its product development work on RHEL 6 through RHEL 9 to Red Hat Jira (issues.redhat.com). If you're a Red Hat customer, please continue to file support cases via the Red Hat customer portal. If you're not, please head to the "RHEL project" in Red Hat Jira and file new tickets here. Individual Bugzilla bugs in the statuses "NEW", "ASSIGNED", and "POST" are being migrated throughout September 2023. Bugs of Red Hat partners with an assigned Engineering Partner Manager (EPM) are migrated in late September as per pre-agreed dates. Bugs against components "kernel", "kernel-rt", and "kpatch" are only migrated if still in "NEW" or "ASSIGNED". If you cannot log in to RH Jira, please consult article #7032570. That failing, please send an e-mail to the RH Jira admins at rh-issues@redhat.com to troubleshoot your issue as a user management inquiry. The email creates a ServiceNow ticket with Red Hat. Individual Bugzilla bugs that are migrated will be moved to status "CLOSED", resolution "MIGRATED", and set with "MigratedToJIRA" in "Keywords". The link to the successor Jira issue will be found under "Links", have a little "two-footprint" icon next to it, and direct you to the "RHEL project" in Red Hat Jira (issue links are of type "https://issues.redhat.com/browse/RHEL-XXXX", where "X" is a digit). This same link will be available in a blue banner at the top of the page informing you that that bug has been migrated.
Bug 1845608 - Missing support of MDB_RTR_TYPE_TEMP(3) in 'bridge.multicast-router'
Summary: Missing support of MDB_RTR_TYPE_TEMP(3) in 'bridge.multicast-router'
Keywords:
Status: CLOSED NOTABUG
Alias: None
Product: Red Hat Enterprise Linux 8
Classification: Red Hat
Component: NetworkManager
Version: ---
Hardware: x86_64
OS: Linux
unspecified
medium
Target Milestone: rc
: 8.3
Assignee: Thomas Haller
QA Contact: Desktop QE
URL:
Whiteboard:
Depends On:
Blocks: nmstate-nm
TreeView+ depends on / blocked
 
Reported: 2020-06-09 16:02 UTC by Gris Ge
Modified: 2020-06-30 14:37 UTC (History)
8 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2020-06-30 14:37:20 UTC
Type: Bug
Target Upstream Version:
Embargoed:

Attachments (Terms of Use)

Description Gris Ge 2020-06-09 16:02:42 UTC 
Description of problem:

In kernel, the linux bridge muilticast route type has `MDB_RTR_TYPE_TEMP(3)`.

```
/* multicast router types */
enum {
	MDB_RTR_TYPE_DISABLED,
	MDB_RTR_TYPE_TEMP_QUERY,
	MDB_RTR_TYPE_PERM,
	MDB_RTR_TYPE_TEMP
};

```

which is not supported by NetworkManager.

Version-Release number of selected component (if applicable):

NetworkManager-1.25.2-25985.d1e8eb791c.el8.x86_64

How reproducible:
100%

Steps to Reproduce:
1. nmcli c add type bridge ifname br0 bridge.multicast-router 3
2.
3.

Actual results:

Error: failed to modify bridge.multicast-router: '3' not among [auto, disabled, enabled].

Expected results:

No failure.

Additional info:

Please also allowing `bridge.multicast-router` been set via integer.
Comment 1 Thomas Haller 2020-06-10 15:23:59 UTC 
option "3" is not supported for the bridge device itself:


# ip link delete br0 2>/dev/null;
# ip link add br0 type bridge mcast_router 3;
# cat /sys/devices/virtual/net/br0/bridge/multicast_router
RTNETLINK answers: Invalid argument

likewise:
# ip link delete br0 2>/dev/null;
# ip link add br0 type bridge mcast_router 2;
# cat /sys/devices/virtual/net/br0/bridge/multicast_router
2
# echo 3 > /sys/devices/virtual/net/br0/bridge/multicast_router
bash: echo: write error: Invalid argument


see br_multicast_set_router() in kernel.


Option MDB_RTR_TYPE_TEMP is only supported for slaves. Like `man ip-link` says:

   mcast_router MULTICAST_ROUTER - configure this port for having multicast routers attached. A port with a multicast router will receive all multicast traffic. MULTICAST_ROUTER may be 
   either 0 to disable multicast routers on this port, 1 to let the system detect the presence of of routers (this is the default), 2 to permanently enable multicast traffic forwarding on 
   this port or 3 to enable multicast routers temporarily on this port, not depending on incoming queries.
Comment 2 Gris Ge 2020-06-19 02:34:57 UTC 
Hi Thomas,

Thanks for the info. Yes, the kernel indicate the 3 option is only for bridge port.

Since the sysfs is using integer for this option, can we expect NM support integer as well?
It worry me that kenrel constant names are completely different from auto/disabled/enabled

You want me to create new bug for this integer support or we can use this one?
Comment 3 Thomas Haller 2020-06-29 10:43:01 UTC 
(In reply to Gris Ge from comment #2)
> Hi Thomas,
> 
> Thanks for the info. Yes, the kernel indicate the 3 option is only for
> bridge port.
> 
> Since the sysfs is using integer for this option, can we expect NM support
> integer as well?
> It worry me that kenrel constant names are completely different from
> auto/disabled/enabled
> 
> You want me to create new bug for this integer support or we can use this
> one?

yes, that is unfortunate. But the API was added in 1.24.0, and the existing API cannot be changed. The only possible thing would be to deprecate the option and add an alternative, but that makes the API overall most confusing, not less.
Comment 5 Thomas Haller 2020-06-30 14:37:20 UTC 
OK, so we cannot change the API to use numbers instead of the names ("auto", "disabled", "enabled").

I improved the documentation slightly (on master: https://gitlab.freedesktop.org/NetworkManager/NetworkManager/-/commit/b9aa7ef81c2de70a3673b38ae0f36c5ad4e666ab )


Other than that, I think there is nothing to do for this bug. Closing as NOTABUG.

Please reopen, if you think anything is missing. Thanks.
Note You need to log in before you can comment on or make changes to this bug.