Bug 1845903 - gcp-routes service too slow to not route traffic into GCP SDN
Summary: gcp-routes service too slow to not route traffic into GCP SDN
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: OpenShift Container Platform
Classification: Red Hat
Component: Machine Config Operator
Version: 4.5
Hardware: Unspecified
OS: Unspecified
high
high
Target Milestone: ---
: 4.6.0
Assignee: Antonio Murdaca
QA Contact: Ke Wang
URL:
Whiteboard:
Depends On:
Blocks: 1845416 1846647 1847876
TreeView+ depends on / blocked
 
Reported: 2020-06-10 11:58 UTC by Stefan Schimanski
Modified: 2020-10-27 16:06 UTC (History)
3 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2020-10-27 16:06:07 UTC
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Github openshift machine-config-operator pull 1808 0 None closed Bug 1845903: gcp-routes: decrease downfile poll to be faster than LB on recovery 2020-07-22 12:51:55 UTC
Red Hat Product Errata RHBA-2020:4196 0 None None None 2020-10-27 16:06:38 UTC

Description Stefan Schimanski 2020-06-10 11:58:11 UTC
When the local kube-apiserver becomes ready, the GCP LBs pick up the endpoint and route traffic to the IP. In parallel the gcp-routes service notices the local, green readyz and stops sending traffic to that LB.

The second step must happen *BEFORE* the first. Otherwise, local requests still go to the GCP LB that already picked up the endpoint. We risk to blackhole 1/3 of the requests (because GCP has no hairpinning support).

The reason is that the gcp-routes script polls every 5s (without inotify which isn't installed in the image as we know) such that we end up with 1*2s + 1.9999s + 5s until the gcp-routes script updates iptables (1.9999s because the readyz polling happens at an unfortunate time, and the 5s for the poll script to notice). Hence, 9s >> 6s of the LB. Hence, for 3s we might lose 1/3 of the requests originating from the local host.

Compare: https://github.com/openshift/installer/pull/3512/files#diff-3aaac4ae7d381237a540f05371931b76R10

Comment 3 Lalatendu Mohanty 2020-06-17 14:45:36 UTC
Do we have a fork of this bug which is targeted for 4.5.0?

Comment 4 Kirsten Garrison 2020-06-18 18:45:43 UTC
@Lala see: https://github.com/openshift/machine-config-operator/pull/1821

It's been merged into 4.5

Comment 5 Kirsten Garrison 2020-06-18 20:32:59 UTC
@Stefan is the acceptance criteria for this the same as https://bugzilla.redhat.com/show_bug.cgi?id=1845416#c13 ?

Comment 8 errata-xmlrpc 2020-10-27 16:06:07 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (OpenShift Container Platform 4.6 GA Images), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2020:4196


Note You need to log in before you can comment on or make changes to this bug.