Bug 1846330 - Remove DNS VIP
Summary: Remove DNS VIP
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: OpenShift Container Platform
Classification: Red Hat
Component: Installer
Version: 4.4
Hardware: Unspecified
OS: Unspecified
unspecified
medium
Target Milestone: ---
: 4.6.0
Assignee: Douglas Schilling Landgraf
QA Contact: Guilherme Santos
URL:
Whiteboard:
Depends On: 1830652
Blocks:
TreeView+ depends on / blocked
 
Reported: 2020-06-11 11:56 UTC by Roy Golan
Modified: 2020-10-27 16:07 UTC (History)
4 users (show)

Fixed In Version:
Doc Type: No Doc Update
Doc Text:
Clone Of:
Environment:
Last Closed: 2020-10-27 16:06:37 UTC
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Github openshift api pull 684 0 None closed ovirt: add a comment about DNS VIP field 2020-10-22 06:46:20 UTC
Github openshift installer pull 3692 0 None closed BUG 1839896: ovirt: General Improvements 2020-10-22 06:46:20 UTC
Github openshift installer pull 3883 0 None closed ovirt: update documentation 2020-10-22 06:46:07 UTC
Red Hat Product Errata RHBA-2020:4196 0 None None None 2020-10-27 16:07:15 UTC

Description Roy Golan 2020-06-11 11:56:46 UTC
DNS VIP is no longer needed, and is not in use to form the etcd cluster.

- remove it from installconfig, ignore if passed
- remove it from platform
- remove the wizard question for dns_vip
- remove from platform documents under docs/user/ovirt

Comment 3 Sandro Bonazzola 2020-06-18 06:43:22 UTC
due to capacity constraints we will be revisiting this bug in the upcoming sprint

Comment 4 Douglas Schilling Landgraf 2020-07-09 12:06:58 UTC
due to capacity constraints we will be revisiting this bug in the upcoming sprint

Comment 5 Douglas Schilling Landgraf 2020-07-10 12:59:45 UTC
(In reply to Roy Golan from comment #1)
> also remove the openshift/api struct field -
> https://github.com/openshift/api/blob/
> 95abe2d2f4223d5931e418bf8e4d3773d16b42c0/config/v1/types_infrastructure.
> go#L397

We cannot remove this field at this moment, otherwise will break the API compatibility. In one year from now, we will able to do that (for all platforms).

Comment 6 David Eads 2020-07-10 13:00:27 UTC
We don't want to immediately remove the field because that can cause upgraded clusters to fail.  Instead, we should update the API doc to deprecate the field and indicate that the value is no longer set and no longer honored. This leaves old clusters with previous value set, but ensures that new clusters cannot make use of it.

One year from now, we can reassess removal or force clearing of the value to bring every cluster in line.

Comment 8 Jan Zmeskal 2020-09-29 11:27:13 UTC
Verified with 4.6.0-0.nightly-2020-09-28-212756

Verification steps:
1. Check https://github.com/openshift/installer/blob/master/docs/user/ovirt/install_ipi.md to see if the reference to DNS VIP has been removed
2. Run openshift-install create install-config and go through the wizard. Make sure it does not ask for DNS VIP.

Comment 10 errata-xmlrpc 2020-10-27 16:06:37 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (OpenShift Container Platform 4.6 GA Images), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2020:4196


Note You need to log in before you can comment on or make changes to this bug.