Bug 1846507 - [sig-network][Feature:Router] The HAProxy router should expose prometheus metrics for a route
Summary: [sig-network][Feature:Router] The HAProxy router should expose prometheus met...
Keywords:
Status: CLOSED EOL
Alias: None
Product: OpenShift Container Platform
Classification: Red Hat
Component: Networking
Version: 4.5
Hardware: Unspecified
OS: Unspecified
medium
medium
Target Milestone: ---
: 4.5.z
Assignee: aos-network-edge-staff
QA Contact: Arvind iyengar
URL:
Whiteboard:
Depends On: 1835371
Blocks:
TreeView+ depends on / blocked
 
Reported: 2020-06-11 18:38 UTC by OpenShift BugZilla Robot
Modified: 2022-08-04 22:27 UTC (History)
11 users (show)

Fixed In Version:
Doc Type: No Doc Update
Doc Text:
Clone Of:
Environment:
Last Closed: 2021-08-03 15:22:15 UTC
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Github openshift origin pull 25098 0 None closed [release-4.5] Bug 1846507: router/metrics: Fix haproxy_server_max_sessions test 2021-02-05 17:36:49 UTC

Comment 4 Arvind iyengar 2020-06-22 09:49:59 UTC
We can continue to see intermittent failures in the recent runs post the PR merge. With below errors:
---
fail [github.com/openshift/origin/test/extended/router/metrics.go:189]: Expected
    <[]float64 | len:2, cap:2>: [0, 0]
to consist of
    <[]interface {} | len:2, cap:2>: [
        {Comparator: ">", CompareTo: [0]},
        {Comparator: ">", CompareTo: [0]},
    ]
---

There are certain times in the run when the test seem to work perfectly. Is this occurrence still a problem with e2e test or due to some anomalies in the environment.

Comment 6 Andrew McDermott 2020-06-30 14:35:38 UTC
The fix has reduced the intermittent flakes quite significantly.

Moving to 4.6 and will backport if we can continue to reduce the intermittent nature.

Comment 8 Ben Parees 2020-07-02 22:45:24 UTC
https://bugzilla.redhat.com/show_bug.cgi?id=1835371 is the original targeted at 4.6  I think this bug was intended to be a clone that targeted 4.5 and then got its target unset and reset to 4.6, i am setting it to 4.5.z.

if you conclude a backport to 4.5.z is not needed, then close this bug.

Comment 9 Andrew McDermott 2020-07-06 09:11:49 UTC
(In reply to Ben Parees from comment #8)
> https://bugzilla.redhat.com/show_bug.cgi?id=1835371 is the original targeted
> at 4.6  I think this bug was intended to be a clone that targeted 4.5 and
> then got its target unset and reset to 4.6, i am setting it to 4.5.z.
> 
> if you conclude a backport to 4.5.z is not needed, then close this bug.

IIRC, in our bug scrub the intent was to move it out of 4.5[.0]. 

A backport to 4.5.z is still needed.

Comment 10 Andrew McDermott 2020-07-09 12:11:02 UTC
I’m adding UpcomingSprint, because I was occupied by fixing bugs with
higher priority/severity, developing new features with higher
priority, or developing new features to improve stability at a macro
level. I will revisit this bug next sprint.

Comment 11 Andrew McDermott 2020-07-30 10:06:10 UTC
I’m adding UpcomingSprint, because I was occupied by fixing bugs with
higher priority/severity, developing new features with higher
priority, or developing new features to improve stability at a macro
level. I will revisit this bug next sprint.

Comment 14 Andrew McDermott 2020-09-10 11:49:25 UTC
I’m adding UpcomingSprint, because I was occupied by fixing bugs with
higher priority/severity, developing new features with higher
priority, or developing new features to improve stability at a macro
level. I will revisit this bug next sprint.

Comment 15 Andrew McDermott 2020-10-02 17:06:49 UTC
We need to figure out whether https://github.com/openshift/router/pull/179 fixed or arrested the flake rate in 4.6. If so, we will consider a backport.

Tagging with UpcomingSprint.

Comment 16 Andrew McDermott 2020-10-23 16:04:07 UTC
Tagging with UpcomingSprint while investigation is either ongoing or
pending. Will be considered for earlier release versions when
diagnosed and resolved.

Comment 17 Andrew McDermott 2020-11-16 08:24:18 UTC
Tagging with UpcomingSprint while investigation is either ongoing or
pending. Will be considered for earlier release versions when
diagnosed and resolved.

Comment 18 Andrew McDermott 2020-12-04 16:51:59 UTC
Tagging with UpcomingSprint while investigation is either ongoing or
pending. Will be considered for earlier release versions when
diagnosed and resolved.

Comment 19 Vikas Laad 2021-08-03 15:22:15 UTC
OCP 4.5 is out of support now, there will not be any more releases for 4.5

Please see lifecycle policy
https://access.redhat.com/support/policy/updates/openshift for supported
versions.


Note You need to log in before you can comment on or make changes to this bug.