Note: This bug is displayed in read-only format because the product is no longer active in Red Hat Bugzilla.
RHEL Engineering is moving the tracking of its product development work on RHEL 6 through RHEL 9 to Red Hat Jira (issues.redhat.com). If you're a Red Hat customer, please continue to file support cases via the Red Hat customer portal. If you're not, please head to the "RHEL project" in Red Hat Jira and file new tickets here. Individual Bugzilla bugs in the statuses "NEW", "ASSIGNED", and "POST" are being migrated throughout September 2023. Bugs of Red Hat partners with an assigned Engineering Partner Manager (EPM) are migrated in late September as per pre-agreed dates. Bugs against components "kernel", "kernel-rt", and "kpatch" are only migrated if still in "NEW" or "ASSIGNED". If you cannot log in to RH Jira, please consult article #7032570. That failing, please send an e-mail to the RH Jira admins at rh-issues@redhat.com to troubleshoot your issue as a user management inquiry. The email creates a ServiceNow ticket with Red Hat. Individual Bugzilla bugs that are migrated will be moved to status "CLOSED", resolution "MIGRATED", and set with "MigratedToJIRA" in "Keywords". The link to the successor Jira issue will be found under "Links", have a little "two-footprint" icon next to it, and direct you to the "RHEL project" in Red Hat Jira (issue links are of type "https://issues.redhat.com/browse/RHEL-XXXX", where "X" is a digit). This same link will be available in a blue banner at the top of the page informing you that that bug has been migrated.

Bug 1846705

Summary: Possible memory leak detected in pcp-atop
Product: Red Hat Enterprise Linux 8 Reporter: Jan Kurik <jkurik>
Component: pcpAssignee: Nathan Scott <nathans>
Status: CLOSED ERRATA QA Contact: Jan Kurik <jkurik>
Severity: low Docs Contact:
Priority: low    
Version: 8.3CC: agerstmayr, jkurik, mgoodwin, mjw, mjw, nathans, patrickm
Target Milestone: rcKeywords: Bugfix, Triaged
Target Release: 8.4Flags: pm-rhel: mirror+
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: No Doc Update
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2020-11-04 03:00:37 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Attachments:
Description Flags
Output of the #1080 testcase none

Description Jan Kurik 2020-06-12 19:43:34 UTC
Created attachment 1697093 [details]
Output of the #1080 testcase

Description of problem:
Running test case #1080 of pcp-testsuite, valgrind detects possible memory leak in pdubuf.c

Version-Release number of selected component (if applicable):
* RHEL-8.3-Alpha release
* valgrind-3.16.0-1.el8
* pcp-5.1.1-2.el8

How reproducible:
Always with valgrind >= 3.16
Versions of valgrid < 3.16 do not detect this possible memory leak

Steps to Reproduce:
1. Install pcp-system-tools
# yum install -y pcp-zeroconf pcp-system-tools
2. Install valgrind >= 3.16
(i.e. https://brewweb.engineering.redhat.com/brew/buildinfo?buildID=1207405)
3. Run the test case #1080
# cd /var/lib/pcp/testsuite && ./check 1080

Actual results:
The testcase fails and valgrind reports possible memory leak.
I am attaching 1080.out.bad from a s390x system containing the whole valgrind output

Expected results:
No memory leak is reported

Additional info:
I am a bit unsure here as this is reproducible only with valgrind >= 3.16 (which is currently quite new). So this issue might also be a valgrind's false-positive report.

Comment 1 Nathan Scott 2020-06-15 01:17:32 UTC
This is a false positive Jan, and it is exactly as you say - the
very fresh version of valgrind arrived in 8.3 almost at the same
time as Fedora ... hence, we don't yet have this fix in place:

commit f30aff90b7b46e99ce6619c73b436e5e77591022
Author: Nathan Scott <nathans>
Date:   Tue Jun 9 09:18:16 2020 +1000

    qa: add valgrind suppressions needed for valgrind 3.16 on f32

Comment 2 Mark Wielaard 2020-06-15 13:29:37 UTC
Note that this bug was cloned for valgrind since it looked like a regression.
But analysis so far seem to indicate it isn't a false positive.
Could someone take a peek at the valgrind bug:
https://bugzilla.redhat.com/show_bug.cgi?id=1846996
I intend to close it unless some pcp hackers can show the code does indeed correctly unpin the (leaked) memory buffers.

Comment 3 Mark Wielaard 2020-06-16 10:38:40 UTC
(In reply to Mark Wielaard from comment #2)
> Note that this bug was cloned for valgrind since it looked like a regression.

Nathan provided me with more background info about this issue.
See https://bugzilla.redhat.com/show_bug.cgi?id=1846996#c4
I have closed the associated valgrind bug now.

Comment 8 errata-xmlrpc 2020-11-04 03:00:37 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (pcp bug fix and enhancement update), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2020:4684