RHEL Engineering is moving the tracking of its product development work on RHEL 6 through RHEL 9 to Red Hat Jira (issues.redhat.com). If you're a Red Hat customer, please continue to file support cases via the Red Hat customer portal. If you're not, please head to the "RHEL project" in Red Hat Jira and file new tickets here. Individual Bugzilla bugs in the statuses "NEW", "ASSIGNED", and "POST" are being migrated throughout September 2023. Bugs of Red Hat partners with an assigned Engineering Partner Manager (EPM) are migrated in late September as per pre-agreed dates. Bugs against components "kernel", "kernel-rt", and "kpatch" are only migrated if still in "NEW" or "ASSIGNED". If you cannot log in to RH Jira, please consult article #7032570. That failing, please send an e-mail to the RH Jira admins at rh-issues@redhat.com to troubleshoot your issue as a user management inquiry. The email creates a ServiceNow ticket with Red Hat. Individual Bugzilla bugs that are migrated will be moved to status "CLOSED", resolution "MIGRATED", and set with "MigratedToJIRA" in "Keywords". The link to the successor Jira issue will be found under "Links", have a little "two-footprint" icon next to it, and direct you to the "RHEL project" in Red Hat Jira (issue links are of type "https://issues.redhat.com/browse/RHEL-XXXX", where "X" is a digit). This same link will be available in a blue banner at the top of the page informing you that that bug has been migrated.
Bug 1846820 - build new libbpf with latest fixes
Summary: build new libbpf with latest fixes
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Red Hat Enterprise Linux 8
Classification: Red Hat
Component: libbpf
Version: 8.3
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: rc
: 8.2
Assignee: Jiri Olsa
QA Contact: Jean-Tsung Hsiao
URL:
Whiteboard:
Depends On: 1809913
Blocks: 1710951 1819241 1919345
TreeView+ depends on / blocked
 
Reported: 2020-06-14 23:34 UTC by Jiri Olsa
Modified: 2021-01-22 15:55 UTC (History)
6 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of: 1809913
: 1919345 (view as bug list)
Environment:
Last Closed: 2020-11-04 02:11:33 UTC
Type: Bug
Target Upstream Version:
Embargoed:

Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Red Hat Product Errata RHBA-2020:4588 0 None None None 2020-11-04 02:11:38 UTC

Comment 4 Jean-Tsung Hsiao 2020-07-20 19:46:46 UTC 
Hi Jiri,
I have built xdp-filter using libbpf.
Good enough to verify this bug?
Thanks!
Jean

[root@netqe29 xdp-tools]# uname -r
4.18.0-226.el8.x86_64
[root@netqe29 xdp-tools]# rpm -qa | grep libbpf
libbpf-0.0.8-2.el8.x86_64
libbpf-devel-0.0.8-2.el8.x86_64
[root@netqe29 xdp-tools]# 

[root@netqe29 xdp-tools]# ./configure
libbpf support: system
perf_buffer__consume support: no
[root@netqe29 xdp-tools]# cd xdp-filter/
[root@netqe29 xdp-filter]# make
    CC       staticobjs/libxdp.o
    LINK     libxdp.a
    CC       sharedobjs/libxdp.o
    LINK     libxdp.so.1.0.0
    M4       xdp-dispatcher.c
    CLANG    xdp-dispatcher.o
    LLC      xdp-dispatcher.o
    CC       params.o
    CC       logging.o
    CC       util.o
    CC       stats.o
    CC       xpcapng.o
    CLANG    xdpfilt_dny_udp.o
    LLC      xdpfilt_dny_udp.o
    CLANG    xdpfilt_dny_tcp.o
    LLC      xdpfilt_dny_tcp.o
    CLANG    xdpfilt_dny_ip.o
    LLC      xdpfilt_dny_ip.o
    CLANG    xdpfilt_dny_eth.o
    LLC      xdpfilt_dny_eth.o
    CLANG    xdpfilt_dny_all.o
    LLC      xdpfilt_dny_all.o
    CLANG    xdpfilt_alw_udp.o
    LLC      xdpfilt_alw_udp.o
    CLANG    xdpfilt_alw_tcp.o
    LLC      xdpfilt_alw_tcp.o
    CLANG    xdpfilt_alw_ip.o
    LLC      xdpfilt_alw_ip.o
    CLANG    xdpfilt_alw_eth.o
    LLC      xdpfilt_alw_eth.o
    CLANG    xdpfilt_alw_all.o
    LLC      xdpfilt_alw_all.o
    CC       xdp-filter
    LINK     xdp-dispatcher.o
[root@netqe29 xdp-filter]#
Comment 5 Jiri Olsa 2020-07-21 14:35:30 UTC 
I recall Toke needed the libbpf change for xdp-tools,
but I dont know if it shows just by building xdp-tools

Toke?

this BZ is for libbpf update, so any standard test suite
we run for libbpf will do
Comment 6 Jean-Tsung Hsiao 2020-07-21 14:57:53 UTC 
(In reply to Jiri Olsa from comment #5)
> I recall Toke needed the libbpf change for xdp-tools,
> but I dont know if it shows just by building xdp-tools
For bug 1759154 Toke suggested using the new package to build xdp-tools/xdp-filter as a way of verification.

> 
> Toke?
> 
> this BZ is for libbpf update, so any standard test suite
> we run for libbpf will do


Not sure about "any standard test suite" . Can you point out some of them?
Thanks!
Jean
Comment 7 Jiri Olsa 2020-07-22 08:19:03 UTC 
(In reply to Jean-Tsung Hsiao from comment #6)
> (In reply to Jiri Olsa from comment #5)
> > I recall Toke needed the libbpf change for xdp-tools,
> > but I dont know if it shows just by building xdp-tools
> For bug 1759154 Toke suggested using the new package to build
> xdp-tools/xdp-filter as a way of verification.
> 
> > 
> > Toke?
> > 
> > this BZ is for libbpf update, so any standard test suite
> > we run for libbpf will do
> 
> 
> Not sure about "any standard test suite" . Can you point out some of them?

nothing specific, I meant anything you'd normally run for libbpf
Comment 8 Jean-Tsung Hsiao 2020-07-23 13:47:26 UTC 
(In reply to Jiri Olsa from comment #7)
> (In reply to Jean-Tsung Hsiao from comment #6)
> > (In reply to Jiri Olsa from comment #5)
> > > I recall Toke needed the libbpf change for xdp-tools,
> > > but I dont know if it shows just by building xdp-tools
> > For bug 1759154 Toke suggested using the new package to build
> > xdp-tools/xdp-filter as a way of verification.
> > 
> > > 
> > > Toke?
> > > 
> > > this BZ is for libbpf update, so any standard test suite
> > > we run for libbpf will do
> > 
> > 
> > Not sure about "any standard test suite" . Can you point out some of them?
> 
> nothing specific, I meant anything you'd normally run for libbpf

As Toke, I used it to compile xdp-tools --- nothing else. It was successful. So, I would like to set the status to VERIFIED.
Comment 9 Toke Høiland-Jørgensen 2020-08-10 11:32:26 UTC 
Looks like this was resolved, so clearing my needinfo :)

(And yeah, I don't think we have anything other than xdp-tools to test libbpf against for the time being; seeing as the kernel self-tests don't use the system libbpf version; so fine with me to have this verified by testing of xdp-tools compilation)
Comment 11 Jean-Tsung Hsiao 2020-09-08 02:14:03 UTC 
Hi Jiri,
Not sure why you changed the status to Modified.
Please advise.
Thanks!
Jean
Comment 12 Jiri Olsa 2020-09-08 12:19:31 UTC 
(In reply to Jean-Tsung Hsiao from comment #11)
> Hi Jiri,
> Not sure why you changed the status to Modified.
> Please advise.
> Thanks!
> Jean

there was new build added to the errata at that time

jirka
Comment 13 Jean-Tsung Hsiao 2020-09-08 13:08:12 UTC 
(In reply to Jiri Olsa from comment #12)
> (In reply to Jean-Tsung Hsiao from comment #11)
> > Hi Jiri,
> > Not sure why you changed the status to Modified.
> > Please advise.
> > Thanks!
> > Jean
> 
> there was new build added to the errata at that time
> 
> jirka

I see. I'll test that.
Thanks!
Jean
Comment 14 Jean-Tsung Hsiao 2020-09-08 14:56:16 UTC 
Tested libbpf by compiling xdp-tools. It passed. See log below.
Will set status to VERIFIED.

[root@netqe10 xdp-tools]# rpm -q libbpf
libbpf-0.0.8-4.el8.x86_64
[root@netqe10 xdp-tools]# uname -r
4.18.0-234.el8.x86_64
[root@netqe10 xdp-tools]#

[root@netqe10 xdp-tools]# make

lib

  util
    CC       params.o
    CC       logging.o
    CC       util.o
    CC       stats.o
    CC       xpcapng.o

  libxdp
    CC       staticobjs/libxdp.o
    LINK     libxdp.a
    CC       sharedobjs/libxdp.o
    LINK     libxdp.so.1.0.0
    M4       xdp-dispatcher.c
    CLANG    xdp-dispatcher.o
    LLC      xdp-dispatcher.o

  testing
    CLANG    test_long_func_name.o
    LLC      test_long_func_name.o
    CLANG    xdp_drop.o
    LLC      xdp_drop.o
    CLANG    xdp_pass.o
    LLC      xdp_pass.o
    LINK     xdp-dispatcher.o

xdp-filter
    CLANG    xdpfilt_dny_udp.o
    LLC      xdpfilt_dny_udp.o
    CLANG    xdpfilt_dny_tcp.o
    LLC      xdpfilt_dny_tcp.o
    CLANG    xdpfilt_dny_ip.o
    LLC      xdpfilt_dny_ip.o
    CLANG    xdpfilt_dny_eth.o
    LLC      xdpfilt_dny_eth.o
    CLANG    xdpfilt_dny_all.o
    LLC      xdpfilt_dny_all.o
    CLANG    xdpfilt_alw_udp.o
    LLC      xdpfilt_alw_udp.o
    CLANG    xdpfilt_alw_tcp.o
    LLC      xdpfilt_alw_tcp.o
    CLANG    xdpfilt_alw_ip.o
    LLC      xdpfilt_alw_ip.o
    CLANG    xdpfilt_alw_eth.o
    LLC      xdpfilt_alw_eth.o
    CLANG    xdpfilt_alw_all.o
    LLC      xdpfilt_alw_all.o
    CC       xdp-filter
    LINK     xdp-dispatcher.o

xdp-loader
    CC       xdp-loader
    LINK     xdp-dispatcher.o

xdp-dump
    CC       xdpdump
    CLANG    xdpdump_bpf.o
    LLC      xdpdump_bpf.o
    LINK     xdp-dispatcher.o
Comment 15 Jerome Marchand 2020-09-10 12:50:35 UTC 
(In reply to Jiri Olsa from comment #12)
> (In reply to Jean-Tsung Hsiao from comment #11)
> > Hi Jiri,
> > Not sure why you changed the status to Modified.
> > Please advise.
> > Thanks!
> > Jean
> 
> there was new build added to the errata at that time
> 
> jirka

Hi Jiri. It's a good practice tu update the Fixed In Version field when you change the status to MODIFIED. That helps prevents misunderstanding with QE wrt fixed versions.
Comment 18 errata-xmlrpc 2020-11-04 02:11:33 UTC 
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (libbpf bug fix and enhancement update), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2020:4588
Note You need to log in before you can comment on or make changes to this bug.