Bug 1847053 - Error during step2 and 4 with docker run didn't make to fail the update
Summary: Error during step2 and 4 with docker run didn't make to fail the update
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Red Hat OpenStack
Classification: Red Hat
Component: python-paunch
Version: 13.0 (Queens)
Hardware: Unspecified
OS: Unspecified
medium
medium
Target Milestone: ---
: ---
Assignee: Emilien Macchi
QA Contact: David Rosenfeld
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2020-06-15 14:21 UTC by Eduard Barrera
Modified: 2023-12-15 18:09 UTC (History)
4 users (show)

Fixed In Version: python-paunch-2.5.3-7.el7ost
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2020-10-28 18:23:50 UTC
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Launchpad 1843734 0 None None None 2020-07-20 13:14:10 UTC
OpenStack gerrit 742751 0 None MERGED [queens-only] Improve volume validation (unclean backport) 2020-10-05 12:49:21 UTC
Red Hat Product Errata RHBA-2020:4388 0 None None None 2020-10-28 18:24:09 UTC

Description Eduard Barrera 2020-06-15 14:21:58 UTC
Description of problem:

During an update we got the following error:

"Error running ['docker', 'run', '--name', 'appformix_heat_plugin', '--label', 'config_id=tripleo_step3', '--label', 'container_name=appformix_heat_plugin', '--label', 'managed_by=paunch', '--label', 'config_data={\"environme
nt\": [\"AUTH_MODE=keystone\", \"KEYSTONE_AUTH_URL_VERSION=/v3\", \"KEYSTONE_AUTH_ADMIN_PASSWORD=XXXXXXXXXXXXXXXXXXXXX\", \"KEYSTONE_AUTH_ADMIN_USER=admin\", \"KEYSTONE_AUTH_ADMIN_TENANT=admin\", \"KEYSTONE_AUTH_REGION_NAME=region
One\", \"KEYSTONE_AUTH_PROJECT_DOMAIN_NAME=Default\", \"KEYSTONE_AUTH_USER_DOMAIN_NAME=Default\", \"KEYSTONE_AUTH_HOST=X.X.X.200\", \"KEYSTONE_AUTH_ADMIN_PORT=35357\", \"KEYSTONE_AUTH_PROTO=http\"], \"image\": \"100.X.X.X
:8787/contrail-appformix-heat-init:1912.32-rhel\", \"volumes\": [\"/etc/contrail/ssl:/etc/contrail/ssl\", \"contrail_heat_opt_plugin:/opt/plugin\"]}', '--detach=true', '--env=AUTH_MODE=keystone', '--env=KEYSTONE_AUTH_URL_VERSION=/v3'
, '--env=KEYSTONE_AUTH_ADMIN_PASSWORD=XXXXXXXXXXXXXXXXXXX', '--env=KEYSTONE_AUTH_ADMIN_USER=admin', '--env=KEYSTONE_AUTH_ADMIN_TENANT=admin', '--env=KEYSTONE_AUTH_REGION_NAME=regionOne', '--env=KEYSTONE_AUTH_PROJECT_DOMAIN_NAME=
Default', '--env=KEYSTONE_AUTH_USER_DOMAIN_NAME=Default', '--env=KEYSTONE_AUTH_HOST=X.X.X.200', '--env=KEYSTONE_AUTH_ADMIN_PORT=35357', '--env=KEYSTONE_AUTH_PROTO=http', '--volume=/etc/contrail/ssl:/etc/contrail/ssl', '--volume
=contrail_heat_opt_plugin:/opt/plugin', 'X.X.X.101:8787/contrail-appformix-heat-init:1912.32-rhel'].",
"stderr: Error: error checking path \"contrail_heat_opt_plugin\": stat contrail_heat_opt_plugin: no such file or directory",


"Error running ['docker', 'run', '--name', 'heat_engine', '--label', 'config_id=tripleo_step4', '--label', 'container_name=heat_engine', '--label', 'managed_by=paunch', '--
...
...
ig_files/config.json:ro', '--volume=/var/lib/config-data/puppet-generated/heat/:/var/lib/kolla/config_files/src:ro', 'X.X.X.110:8787/rhosp13/openstack-heat-engine:13.0-83'].",
"stderr: Error: error checking path \"contrail_heat_opt_plugin\": stat contrail_heat_opt_plugin: no such file or directory",
"stdout: 3ab50d0140e38b0470130c86df43f8331b623b968505712bc5715c6986b4e326",
"stdout: 72faf6b1f25f433fbe0462349e67dc7104cc37f266ea69323ac4a1dad0baa220",
"stdout: 6c959ff5cff6f01336b5602fe8cd177a10f3ead342ea664daeb30c72be773e1b",
"stdout: a21b338f13c8233e93e7ecc6fa48ca67a54cf514ff58a228bef40f9146faf840",
"stdout: 5b4e8c586ad184468eaebb2986e314731847bf17a6db40719948dc3ed5213e53",
"stdout: 6cd2d7a99d357203ee9bc54b0c42dd04bd9da08222808a32a180069dfa413205",


The expectation is openstack update run should fail which in turn would fail step2.


Version-Release number of selected component (if applicable):
OSP13

How reproducible:
Unsure

Steps to Reproduce:
1. perform a minor update
2.
3.

Actual results:
update completed successfully event some containers could not be spawned

Expected results:
update should fail reported the corresponding error

Comment 7 Emilien Macchi 2020-07-20 13:14:10 UTC
A bit of context: Docker supports using a volume name as part of a volume mount.
In https://review.opendev.org/#/c/672239, we added logic into paunch to throw an error if the source didn't exist and we assumed it was always a file system path. Since this can also be container volume, we need to adjust the logic to handle checking for container volumes. This patch was reverted (see https://bugs.launchpad.net/tripleo/+bug/1843734).

The volume validation was improved in OSP16 but not backported to Queens: https://review.opendev.org/#/c/682141
I guess this should be done.

Comment 23 errata-xmlrpc 2020-10-28 18:23:50 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (Red Hat OpenStack Platform 13.0 director bug fix advisory), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2020:4388


Note You need to log in before you can comment on or make changes to this bug.