Bug 1847815 - [NooBaa] Backingstore events aren't using correct types
Summary: [NooBaa] Backingstore events aren't using correct types
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Red Hat OpenShift Container Storage
Classification: Red Hat Storage
Component: Multi-Cloud Object Gateway
Version: 4.5
Hardware: Unspecified
OS: Unspecified
unspecified
low
Target Milestone: ---
: OCS 4.5.0
Assignee: Ohad
QA Contact: Ben Eli
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2020-06-17 06:25 UTC by Ben Eli
Modified: 2020-09-15 10:18 UTC (History)
3 users (show)

Fixed In Version: 4.5.0-470.ci
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2020-09-15 10:17:44 UTC
Embargoed:


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Github noobaa noobaa-operator pull 354 0 None closed Refactor backingstore mode info mapping and add severity 2020-11-10 06:24:42 UTC
Red Hat Product Errata RHBA-2020:3754 0 None None None 2020-09-15 10:18:06 UTC

Description Ben Eli 2020-06-17 06:25:24 UTC
Description of problem (please be detailed as possible and provide log
snippests):
While verifying BZ1828611, I found out that all backingstore related events are reported with type="warning". According to Kanika, this is the way the backend reports those events, and thus should be fixed on the NooBaa backend side.

For example - 
$ oc get events | grep backingstore
8m44s       Warning   BackingStorePhaseReady         backingstore/aws                                                                Backing store mode: INITALIZING
8m43s       Warning   BackingStorePhaseReady         backingstore/aws                                                                Backing store mode: OPTIMAL
8m31s       Warning   BackingStorePhaseRejected      backingstore/aws                                                                Backing store mode: STORAGE_NOT_EXIST

BackingStorePhaseReady+OPTIMAL should be reported as normal, BackingStorePhaseRejected should be reported as an error

Version of all relevant components (if applicable):
OCS 4.5.0-449
OCP 4.5.0-0.nightly-2020-06-17-001505

Does this issue impact your ability to continue to work with the product
(please explain in detail what is the user impact)?
No

Is there any workaround available to the best of your knowledge?
No

Rate from 1 - 5 the complexity of the scenario you performed that caused this
bug (1 - very simple, 5 - very complex)?
1

Can this issue reproducible?
Yes

Can this issue reproduce from the UI?
Yes

If this is a regression, please provide more details to justify this:
NA

Steps to Reproduce:
1. Create a backingstore with a nonexistent target store
2. Create a healthy backingstore
3. Watch the Events section under the Object Service tab in the OpenShift web console


Actual results:
All events are reported as warnings

Expected results:
Events are reported with their proper types

Additional info:

Comment 2 Raz Tamir 2020-06-18 08:35:03 UTC
Hi @Ben,

Is this a regression from previous releases?
Was it discovered with our automation?

Please add relevant keywords for any of the above questions if the answer is 'yes'

Thanks

Comment 3 Ben Eli 2020-06-18 09:40:52 UTC
@Raz -
This feature was added in 4.5, as part of BZ1828611.
Thus, I don't think it's a regression.
It was discovered by me while I was trying to verify the BZ mentioned above :)

Comment 4 Ohad 2020-06-28 09:16:22 UTC
Hi @ben, 
I started to look at the code and found out that k8s events can be only one of the following types: EventTypeNormal ("Normal") and EventTypeWarning ("Warning").
This means that the BZ can be resolved only partially. 

I suggest changing the requirement for BackingStorePhaseRejected being marked as  "Error"(not supported) to be "Warning" so when I will introduce the changed we could resolve this BZ.

Comment 5 Ben Eli 2020-06-28 10:15:06 UTC
I agree. In this case, all errors should be shown as warnings.

Comment 6 Ohad 2020-06-28 12:57:53 UTC
A fix was issued in the upstream project (see links section)

Comment 10 Ben Eli 2020-07-19 13:43:16 UTC
Backingstore events now use the Normal and Warning event types properly.
Verified.
OCS v4.5.0-493.ci
OCP v4.5.0-0.nightly-2020-07-18-024505

Comment 12 errata-xmlrpc 2020-09-15 10:17:44 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (Red Hat OpenShift Container Storage 4.5.0 bug fix and enhancement update), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2020:3754


Note You need to log in before you can comment on or make changes to this bug.