Red Hat Satellite engineering is moving the tracking of its product development work on Satellite to Red Hat Jira (issues.redhat.com). If you're a Red Hat customer, please continue to file support cases via the Red Hat customer portal. If you're not, please head to the "Satellite project" in Red Hat Jira and file new tickets here. Individual Bugzilla bugs will be migrated starting at the end of May. If you cannot log in to RH Jira, please consult article #7032570. That failing, please send an e-mail to the RH Jira admins at rh-issues@redhat.com to troubleshoot your issue as a user management inquiry. The email creates a ServiceNow ticket with Red Hat. Individual Bugzilla bugs that are migrated will be moved to status "CLOSED", resolution "MIGRATED", and set with "MigratedToJIRA" in "Keywords". The link to the successor Jira issue will be found under "Links", have a little "two-footprint" icon next to it, and direct you to the "Satellite project" in Red Hat Jira (issue links are of type "https://issues.redhat.com/browse/SAT-XXXX", where "X" is a digit). This same link will be available in a blue banner at the top of the page informing you that that bug has been migrated.
Bug 1847951 - Satellite log files (/var/log/foreman-maintain/foreman-maintain.log and /var/log/foreman-installer/satellite.log) captures password in the plain text.
Summary: Satellite log files (/var/log/foreman-maintain/foreman-maintain.log and /var/...
Keywords:
Status: CLOSED WONTFIX
Alias: None
Product: Red Hat Satellite
Classification: Red Hat
Component: Installation
Version: 6.8.0
Hardware: x86_64
OS: Linux
unspecified
medium
Target Milestone: 6.11.0
Assignee: satellite6-bugs
QA Contact: Devendra Singh
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2020-06-17 12:29 UTC by Devendra Singh
Modified: 2022-07-19 11:20 UTC (History)
7 users (show)

Fixed In Version:
Doc Type: Enhancement
Doc Text:
Clone Of: 1785117
Environment:
Last Closed: 2021-08-10 21:37:00 UTC
Target Upstream Version:
Embargoed:

Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Github sosreport sos pull 2115 0 None closed [foreman] scrub cpdb password in installer logs 2020-07-23 18:46:48 UTC

Description Devendra Singh 2020-06-17 12:29:06 UTC 
Description of problem: Satellite log files (/var/log/foreman-maintain/foreman-maintain.log and /var/log/foreman-installer/satellite.log) captures password in the plain text.

Version-Release number of selected component (if applicable):
6.8


Steps to Reproduce RFE:
1. Collect the logs using foreman-debug
2. Check the satellite.log from collected foreman-debug log
3. Password display in the plain text

Actual Result:

satellite.8.log:[DEBUG 2020-06-15T05:09:16 main]   Searching for "foreman_proxy_content::pulp_admin_password+FILTERED+
satellite.8.log:[DEBUG 2020-06-15T05:09:16 main]           No such key: "foreman_proxy_content::pulp_admin_password+FILTERED+
satellite.8.log:[DEBUG 2020-06-15T05:09:16 main]           Found key: "foreman_proxy_content::pulp_admin_password" +FILTERED+ "XXXXXXXXXXXXXXXX"
satellite.8.log:[DEBUG 2020-06-15T05:09:16 main]  Automatic Parameter Lookup of 'foreman_proxy_content::pulp_proxy_password+FILTERED+
satellite.8.log:[DEBUG 2020-06-15T05:09:16 main]   Searching for "foreman_proxy_content::pulp_proxy_password+FILTERED+
satellite.8.log:[DEBUG 2020-06-15T05:09:16 main]           No such key: "foreman_proxy_content::pulp_proxy_password+FILTERED+
satellite.8.log:[DEBUG 2020-06-15T05:09:16 main]           Found key: "foreman_proxy_content::pulp_proxy_password" +FILTERED+ nil
satellite.8.log:[DEBUG 2020-06-15T05:09:16 main]  Automatic Parameter Lookup of 'foreman_proxy_content::qpid_router_sasl_password+FILTERED+
satellite.8.log:[DEBUG 2020-06-15T05:09:16 main]   Searching for "foreman_proxy_content::qpid_router_sasl_password+FILTERED+
satellite.8.log:[DEBUG 2020-06-15T05:09:16 main]           No such key: "foreman_proxy_content::qpid_router_sasl_password+FILTERED+
satellite.8.log:[DEBUG 2020-06-15T05:09:16 main]           Found key: "foreman_proxy_content::qpid_router_sasl_password" +FILTERED+ "XXXXXXXXXXXXXXXXX"
satellite.8.log:[DEBUG 2020-06-15T05:09:16 main]  Automatic Parameter Lookup of 'foreman_proxy_content::pulpcore_postgresql_password+FILTERED+
satellite.8.log:[DEBUG 2020-06-15T05:09:16 main]   Searching for "foreman_proxy_content::pulpcore_postgresql_password+FILTERED+
satellite.8.log:[DEBUG 2020-06-15T05:09:16 main]           No such key: "foreman_proxy_content::pulpcore_postgresql_password+FILTERED+
satellite.8.log:[DEBUG 2020-06-15T05:09:16 main]           Found key: "foreman_proxy_content::pulpcore_postgresql_password" +FILTERED+ "XXXXXXXXXXXX"
satellite.8.log:[DEBUG 2020-06-15T05:09:17 main]  Automatic Parameter Lookup of 'foreman::cli::password+FILTERED+


Expected Result:

All the passwords should be replaced with FILTERED.
Comment 3 Pavel Moravec 2020-06-17 13:38:09 UTC 
I think sos-3.9-2 does obfuscate everything properly here, could you please test it from the build

https://brewweb.engineering.redhat.com/brew/buildinfo?buildID=1205534

?
Comment 4 Devendra Singh 2020-06-17 14:05:24 UTC 
(In reply to Pavel Moravec from comment #3)
> I think sos-3.9-2 does obfuscate everything properly here, could you please
> test it from the build
> 
> https://brewweb.engineering.redhat.com/brew/buildinfo?buildID=1205534
> 
> ?

I have tested the same on 6.8, all the passwords value replaced with special ****** except https://bugzilla.redhat.com/show_bug.cgi?id=1785117#c12

sos version: 3.9-2.el7

[DEBUG 2020-06-15T04:50:33 main]           Original path: "%{facts.kafo.scenario.answer_file}"
[DEBUG 2020-06-15T04:50:33 main]  Found key: "foreman_proxy_content::pulp_admin_password" value: ********
[DEBUG 2020-06-15T04:50:33 main]  Automatic Parameter Lookup of 'foreman_proxy_content::pulp_max_speed'
[DEBUG 2020-06-15T04:50:33 main]   Searching for "foreman_proxy_content::pulp_max_speed"
[DEBUG 2020-06-15T04:50:33 main]     Global Data Provider (hiera configuration version 5)
[DEBUG 2020-06-15T04:50:33 main]       Using configuration "/usr/share/foreman-installer/config/foreman-hiera.yaml"
[DEBUG 2020-06-15T04:50:33 main]       Hierarchy entry "Custom user answers"
[DEBUG 2020-06-15T04:50:33 main]         Path "/etc/foreman-installer/custom-hiera.yaml"
[DEBUG 2020-06-15T04:50:33 main]           Original path: "/etc/foreman-installer/custom-hiera.yaml"

[DEBUG 2020-06-15T04:50:33 main]           Original path: "%{facts.kafo.scenario.answer_file}"
[DEBUG 2020-06-15T04:50:33 main]  Found key: "foreman_proxy_content::qpid_router_sasl_password" value: ********
[DEBUG 2020-06-15T04:50:33 main]  Automatic Parameter Lookup of 'foreman_proxy_content::enable_ostree'
[DEBUG 2020-06-15T04:50:33 main]   Searching for "foreman_proxy_content::enable_ostree"
[DEBUG 2020-06-15T04:50:33 main]     Global Data Provider (hiera configuration version 5)
[DEBUG 2020-06-15T04:50:33 main]       Using configuration "/usr/share/foreman-installer/config/foreman-hiera.yaml"
[DEBUG 2020-06-15T04:50:33 main]       Hierarchy entry "Custom user answers"
Comment 5 Pavel Moravec 2020-06-17 15:16:48 UTC 
https://github.com/sosreport/sos/pull/2115 raised for the sos part.

Due to the state of RHEL7.9, I suggest to have this fixed since Sat7/RHEL8.4 only.
Comment 6 Mike McCune 2021-07-13 21:54:48 UTC 
Upon review of our valid but aging backlog the Satellite Team has concluded that this Bugzilla does not meet the criteria for a resolution in the near term, and are planning to close in a month. This message may be a repeat of a previous update and the bug is again being considered to be closed. If you have any concerns about this, please contact your Red Hat Account team.  Thank you.
Comment 8 Mike McCune 2021-08-10 21:34:00 UTC 
Thank you for your interest in Red Hat Satellite. We have evaluated this request, and while we recognize that it is a valid request, we do not expect this to be implemented in the product in the foreseeable future. This is due to other priorities for the product, and not a reflection on the request itself. We are therefore closing this out as WONTFIX. If you have any concerns about this feel free to contact your Red Hat Account Team. Thank you.
Note You need to log in before you can comment on or make changes to this bug.