Description of problem:

ocf:heartbeat:sybaseASE fails to start when symlinks are used for sybase_home

Version-Release number of selected component (if applicable):

resource-agents-4.1.1-30.el7_7.7.x86_64


Steps to Reproduce:
1. create ocf:heartbeat:sybaseASE using a symlink to a directory on cluster managed storage as the sybase_home attribute

Actual results:

Resource fails since the probe will return OCF_ERR_GENERIC (1) instead of OCF_NOT_RUNNING (7) or OCF_SUCCESS (0).


Expected results:

The resource agent should be configured in such a way that should be able to accurately report when the resource isn't running even when symlinks are used.


Additional info:


This appears to be the result of verify_all() which returns OCF_ERR_ARGS, but then the caller converts that to OCF_ERR_GENERIC

        # Check if the parameter 'sybase_home' is a valid path.
        if [[ ! -d $OCF_RESKEY_sybase_home ]]
        then
                ocf_log err "sybaseASE: The sybase_home '$OCF_RESKEY_sybase_home' doesn't exist."
                return $OCF_ERR_ARGS
        fi
------------------------------------------(cut)-----------------------------------------------------------

        # Check if the directory /$OCF_RESKEY_sybase_home/$OCF_RESKEY_sybase_ase exists.
        if [[ ! -d $OCF_RESKEY_sybase_home/$OCF_RESKEY_sybase_ase ]]
        then
                ocf_log err "sybaseASE: The directory '$OCF_RESKEY_sybase_home/$OCF_RESKEY_sybase_ase' doesn't exist."
                return $OCF_ERR_ARGS
        fi
------------------------------------------(cut)-----------------------------------------------------------

        # Check if the directory /$OCF_RESKEY_sybase_home/$OCF_RESKEY_sybase_ocs exists.
        if [[ ! -d $OCF_RESKEY_sybase_home/$OCF_RESKEY_sybase_ocs ]]
        then
                ocf_log err "sybaseASE: The directory '$OCF_RESKEY_sybase_home/$OCF_RESKEY_sybase_ocs' doesn't exist."
                return $OCF_ERR_ARGS
        fi