Bug 1848598 - "rbd import-diff" will potentially ignore discarded regions
Summary: "rbd import-diff" will potentially ignore discarded regions
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Red Hat Ceph Storage
Classification: Red Hat Storage
Component: RBD
Version: 4.0
Hardware: Unspecified
OS: Unspecified
unspecified
medium
Target Milestone: ---
: 5.0
Assignee: Greg Farnum
QA Contact: Gopi
URL:
Whiteboard:
Depends On: 1848594
Blocks:
TreeView+ depends on / blocked
 
Reported: 2020-06-18 15:15 UTC by Jason Dillaman
Modified: 2021-08-30 08:25 UTC (History)
6 users (show)

Fixed In Version: ceph-16.0.0-8633.el8cp
Doc Type: If docs needed, set a value
Doc Text:
Clone Of: 1848594
Environment:
Last Closed: 2021-08-30 08:25:38 UTC
Embargoed:


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Ceph Project Bug Tracker 45986 0 None None None 2020-06-18 15:15:30 UTC
Red Hat Issue Tracker RHCEPH-1245 0 None None None 2021-08-30 00:19:13 UTC
Red Hat Product Errata RHBA-2021:3294 0 None None None 2021-08-30 08:25:50 UTC

Description Jason Dillaman 2020-06-18 15:15:30 UTC
+++ This bug was initially created as a clone of Bug #1848594 +++

Description of problem:
Create an "rbd export-diff" of a snapshot that includes newly discarded regions. When running "rbd import-diff", it will issue discards via the librbd API, but the librbd API will incorrectly prune the extents of the discard to align against 64KiB boundaries (by default). This might result in an unexpected difference between the two images even though a discard should not be assumed to actually free disk space and zero it. 

Version-Release number of selected component (if applicable):
4.0 + 5.0

How reproducible:
100%

Steps to Reproduce:
1. Export an image snapshot diff that includes unaligned (64KiB) discards using a pre-RHCS 4 client.
2. Attempt to import the snapshot diff using an RHCS 4+ client that now ignores unaligned discards

Actual results:
The unaligned discarded region will be be discarded in the import-diff destination image.

Expected results:
The unaligned discarded regions should be zeroed since users might be attempting to verify proper import/export via checksums -- which will fail if the images don't exactly match.

Additional info:

Comment 4 errata-xmlrpc 2021-08-30 08:25:38 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (Red Hat Ceph Storage 5.0 bug fix and enhancement), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2021:3294


Note You need to log in before you can comment on or make changes to this bug.