Bug 1849097 - [RFE] Support standard NBD URL syntax
Summary: [RFE] Support standard NBD URL syntax
Keywords:
Status: CLOSED DEFERRED
Alias: None
Product: vdsm
Classification: oVirt
Component: Core
Version: 4.40.14
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
: ---
Assignee: bugs@ovirt.org
QA Contact: Avihai
URL:
Whiteboard:
Depends On: 1849091
Blocks:
TreeView+ depends on / blocked
 
Reported: 2020-06-19 15:35 UTC by Nir Soffer
Modified: 2022-05-11 12:40 UTC (History)
5 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2022-05-11 12:40:23 UTC
oVirt Team: Storage
Embargoed:
sbonazzo: ovirt-4.5?
pm-rhel: planning_ack?
pm-rhel: devel_ack?
pm-rhel: testing_ack?


Attachments (Terms of Use)

Description Nir Soffer 2020-06-19 15:35:00 UTC
Description of problem:

NBD protocol introduced new URL syntax recenlty:
https://github.com/NetworkBlockDevice/nbd/blob/master/doc/uri.md

NBD URI                          Export name
----------------------------------------------------
nbd+unix:///disk?socket=sock     disk
nbd+unix:///?socket=sock         (empty string)
nbd://example.com/disk           disk
nbd://example.com/               (empty string)


Vdsm generates qemu non-standard syntax:

QEMU NBD URI                     Export name
---------------------------------------------------
nbd:unix:/socket:exportname=disk   disk
nbd:example.com/disk               disk

We want to switch to the standard NBD URL syntax for better compatibility with
virt-v2v, and possibly allowing backup using NBD socket.

Vdsm generates NBD URL in:
- NBD.start_server
- VM.start_backup

In both cases we need to switch to the new syntax.

This change depends on bug 1849091 - we cannot generate URLs that imageio
does not support, since imageio is consuming these URLs when downloading
disks and backups.

We also need to check that qemu-nbd and qemu support the new syntax, we never
tested the new syntax.

Comment 1 Nir Soffer 2020-06-19 15:42:22 UTC
Related to bug 1657713, using NBD transport for virt-v2v.

Comment 2 Michal Skrivanek 2020-06-23 12:34:01 UTC
This request is not currently committed to 4.4.z, moving it to 4.5

Comment 3 Michal Skrivanek 2021-08-20 11:01:51 UTC
This bug/RFE is more than a year old and it didn't get enough attention so far, and is now flagged as pending close. 
Please review if it is still relevant and provide additional details/justification/patches if you believe it should get more attention for the next oVirt release.

Comment 4 Richard W.M. Jones 2021-08-20 11:08:38 UTC
Well I think you *should* support NBD URIs.  It's usually a very
simple change to make as the format is simple.

Comment 6 Sandro Bonazzola 2022-03-29 16:16:40 UTC
We are past 4.5.0 feature freeze, please re-target.

Comment 7 Arik 2022-05-11 12:40:23 UTC
Filed: https://github.com/oVirt/vdsm/issues/174


Note You need to log in before you can comment on or make changes to this bug.