Bug 1849518 - marketplace-operator should show the source git commit
Summary: marketplace-operator should show the source git commit
Alias: None
Product: OpenShift Container Platform
Classification: Red Hat
Component: OLM
Version: 4.4
Hardware: Unspecified
OS: Unspecified
Target Milestone: ---
: 4.4.z
Assignee: Daniel Sover
QA Contact: Jian Zhang
Depends On: 1849524
TreeView+ depends on / blocked
Reported: 2020-06-22 05:57 UTC by Jian Zhang
Modified: 2020-07-06 20:47 UTC (History)
1 user (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Last Closed: 2020-07-06 20:47:17 UTC
Target Upstream Version:

Attachments (Terms of Use)

System ID Private Priority Status Summary Last Updated
Github operator-framework operator-marketplace pull 292 0 None closed Bug 1849518: [release-4.4] show the source commit id 2021-01-14 07:39:02 UTC
Red Hat Product Errata RHBA-2020:2786 0 None None None 2020-07-06 20:47:39 UTC

Description Jian Zhang 2020-06-22 05:57:25 UTC
Description of problem:
The marketplace-operator --version should show the git source commits, not the build commits.

Version-Release number of selected component (if applicable):
Cluster version is 4.4.0-0.nightly-2020-06-21-210301

How reproducible:

Steps to Reproduce:
1. Install an OCP 4.x cluster

2. Check the marketplace-operator version.

Actual results:
The below git commit "01f5538293c300c97ea5b045d60981243bc24c30" isn't the source commit, we could not find it in the commits history: https://github.com/operator-framework/operator-marketplace/commits/release-4.4

mac:~ jianzhang$ oc -n openshift-marketplace  exec marketplace-operator-664774d49-jhqkf -- marketplace-operator --version
time="2020-06-22T05:48:11Z" level=info msg="Go Version: go1.13.4"
time="2020-06-22T05:48:11Z" level=info msg="Go OS/Arch: linux/amd64"
time="2020-06-22T05:48:11Z" level=info msg="operator-sdk Version: v0.8.0"
Marketplace source git commit: 01f5538293c300c97ea5b045d60981243bc24c30

Expected results:
It should show the source commits that we can find it in the https://github.com/operator-framework/operator-marketplace/commits/release-4.4

Additional info:

Comment 2 Jian Zhang 2020-06-22 06:03:18 UTC
Submit a PR: https://github.com/operator-framework/operator-marketplace/pull/292

Comment 7 Jian Zhang 2020-06-28 02:17:30 UTC
Cluster version is 4.4.0-0.nightly-2020-06-27-171816

1, Check the marketplace operators' version:
mac:~ jianzhang$ oc project openshift-marketplace
Now using project "openshift-marketplace" on server "https://api.ci-ln-jm4cyz2-d5d6b.origin-ci-int-aws.dev.rhcloud.com:6443".
mac:~ jianzhang$ oc get pods
NAME                                    READY   STATUS    RESTARTS   AGE
certified-operators-747c7cb4f9-2kfxk    1/1     Running   0          17m
community-operators-7db59cd9f7-9lt92    1/1     Running   0          17m
marketplace-operator-68c966f5c8-vgrfp   1/1     Running   0          18m
redhat-marketplace-847d789647-qgcz4     1/1     Running   0          17m
redhat-operators-5f976849f5-mpkpr       1/1     Running   0          17m

mac:~ jianzhang$ oc exec marketplace-operator-68c966f5c8-vgrfp -- marketplace-operator --version
Marketplace source git commit: 34fd70b3c0782bc7eaeb752666a7614c30ccf545
time="2020-06-28T02:01:01Z" level=info msg="Go Version: go1.13.4"
time="2020-06-28T02:01:01Z" level=info msg="Go OS/Arch: linux/amd64"
time="2020-06-28T02:01:01Z" level=info msg="operator-sdk Version: v0.8.0"

As we can see from the below screenshot, the above commit is the same as the below one. LGTM, verify it.

Comment 9 errata-xmlrpc 2020-07-06 20:47:17 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.


Note You need to log in before you can comment on or make changes to this bug.