Description of problem:

When trying to change external-protocol-port to a value that is already used by another pf row, there is no error checking and we end up 'stuck' until the api times out. The neutron db is catching
the improper config, but the validation should likely not allow it to get that far.


Version-Release number of selected component (if applicable):


How reproducible:



Steps to Reproduce:
1.
2.
3.

Actual results:


Expected results:
Should fail right away, as it does during reaction of the pf with invalid param

Additional info:

Reference script:



openstack server create --nic net-id=private,v4-fixed-ip=10.0.0.10 --flavor m1.nano --image $IMAGE_ID \
    --key-name demo d --wait && openstack port set --name dp $(openstack port list --server d -f value -c ID) && \
openstack server create --nic net-id=private,v4-fixed-ip=10.0.0.11 --flavor m1.nano --image $IMAGE_ID \
    --key-name demo e --wait && openstack port set --name ep $(openstack port list --server e -f value -c ID) && echo ok

FIP=172.24.4.8 ; \
openstack floating ip create --floating-ip-address ${FIP} public
FIP_UUID=$(openstack floating ip show ${FIP} -f value -c id) ; echo ${FIP_UUID}

openstack floating ip port forwarding create --internal-ip-address 10.0.0.10 --internal-protocol-port 22  \
   --port dp --external-protocol-port 2020 --protocol tcp $FIP_UUID
   
# this fails right away, as it should
openstack floating ip port forwarding create --internal-ip-address 10.0.0.11 --internal-protocol-port 22  \
   --port ep --external-protocol-port 2020 --protocol tcp $FIP_UUID

openstack floating ip port forwarding create --internal-ip-address 10.0.0.11 --internal-protocol-port 22  \
   --port ep --external-protocol-port 2021 --protocol tcp $FIP_UUID

openstack floating ip port forwarding list ${FIP_UUID}

PF_ID=$(openstack floating ip port forwarding list ${FIP_UUID} -f value -c 'Internal IP Address' -c ID | \
   grep 10.0.0.11 | cut -d' ' -f1) ; echo $PF_ID

# Issue: this should fail sooner than it does
time openstack floating ip port forwarding set --external-protocol-port 2020 ${FIP_UUID} ${PF_ID}