Bug 1849722 - Review Request: python-graphene - GraphQL Framework for Python
Summary: Review Request: python-graphene - GraphQL Framework for Python
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Alfredo Moralejo
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On: 1756646 1836559
Blocks:
TreeView+ depends on / blocked
 
Reported: 2020-06-22 16:16 UTC by Javier Peña
Modified: 2020-07-20 10:53 UTC (History)
2 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2020-07-20 10:53:16 UTC
Type: ---
Embargoed:
amoralej: fedora-review+


Attachments (Terms of Use)

Description Javier Peña 2020-06-22 16:16:19 UTC
Spec URL: https://jpena.fedorapeople.org/python-graphene/python-graphene.spec
SRPM URL: https://jpena.fedorapeople.org/python-graphene/python-graphene-3.0b2-1.fc33.src.rpm
Description: Graphene is a Python library for building GraphQL schemas/types fast and easily.
Fedora Account System Username: jpena

Koji scratch build is available at https://koji.fedoraproject.org/koji/taskinfo?taskID=45992169 . Unit tests had to be disabled because some test requirements are not packaged in Fedora yet.

Comment 1 Javier Peña 2020-06-23 10:48:08 UTC
I have uploaded an updated spec that disables automatic dependency generation.

Spec URL: https://jpena.fedorapeople.org/python-graphene/python-graphene.spec
SRPM URL: https://jpena.fedorapeople.org/python-graphene/python-graphene-3.0b2-2.fc33.src.rpm

Koji scratch build available at https://koji.fedoraproject.org/koji/taskinfo?taskID=46035476.

Comment 2 Alfredo Moralejo 2020-06-23 11:28:52 UTC
fedora-review results:



Rpmlint (installed packages)
----------------------------
warning: Found bdb Packages database while attempting sqlite backend: using bdb backend.
perl: warning: Setting locale failed.
perl: warning: Please check that your locale settings:
	LANGUAGE = (unset),
	LC_ALL = (unset),
	LC_CTYPE = "C.UTF-8",
	LANG = "en_US.UTF-8"
    are supported and installed on your system.
perl: warning: Falling back to the standard locale ("C").
perl: warning: Setting locale failed.
perl: warning: Please check that your locale settings:
	LANGUAGE = (unset),
	LC_ALL = (unset),
	LC_CTYPE = "C.UTF-8",
	LANG = "en_US.UTF-8"
    are supported and installed on your system.
perl: warning: Falling back to the standard locale ("C").
warning: Found bdb Packages database while attempting sqlite backend: using bdb backend.
python3-graphene.noarch: W: spelling-error %description -l en_US schemas -> schema, sachems, schemes
python3-graphene.noarch: W: invalid-url URL: https://github.com/graphql-python/graphene <urlopen error [Errno -2] Name or service not known>
1 packages and 0 specfiles checked; 0 errors, 2 warnings.



Source checksums
----------------
https://files.pythonhosted.org/packages/source/g/graphene/graphene-3.0b2.tar.gz :
  CHECKSUM(SHA256) this package     : 7ad98b944f0d55e369cfa9759229f56e22df20c7b4a131b6d0596a6c6a0c817b
  CHECKSUM(SHA256) upstream package : 7ad98b944f0d55e369cfa9759229f56e22df20c7b4a131b6d0596a6c6a0c817b


Requires
--------
python3-graphene (rpmlib, GLIBC filtered):
    python(abi)
    python3dist(aniso8601)
    python3dist(graphql-core)
    python3dist(graphql-relay)
    python3dist(unidecode)



Provides
--------
python3-graphene:
    python-graphene
    python3-graphene
    python3.9-graphene
    python3.9dist(graphene)
    python3dist(graphene)



Generated by fedora-review 0.7.3 (44b83c7) last change: 2019-09-18
Command line :/usr/bin/fedora-review -b 1849722
Buildroot used: fedora-rawhide-{{ target_arch }}
Active plugins: Python, Generic, Shell-api
Disabled plugins: C/C++, Perl, SugarActivity, R, PHP, Ocaml, Haskell, Java, fonts
Disabled flags: EPEL6, EPEL7, DISTTAG, BATCH, EXARCH



Some comments:

- Unit tests are not executed in %check as some required libraries to run unit tests are not available in Fedora.
- Automatic python requirements has been disabled as it was introducing unneeded minimum version of unidecode and max versions for all requirements which is not recommendd.

This package is APPROVED

Comment 3 Gwyn Ciesla 2020-06-23 14:21:57 UTC
(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/python-graphene

Comment 4 Javier Peña 2020-07-20 10:53:16 UTC
We have a Rawhide build now, closing.


Note You need to log in before you can comment on or make changes to this bug.