Bug 1850212

Verified in CI job: https://rhos-ci-jenkins.lab.eng.tlv2.redhat.com/view/DFG/view/upgrades/view/ffu/job/DFG-upgrades-ffu-ffu-upgrade-13-16.1_director-rhel-virthost-3cont_2comp-ipv4-vxlan-HA-no-ceph/51/console

We missed to remove all those parameters from the CI automation and the job failed with:

2020-09-22 16:53:46 | [Tue Sep 22 16:53:46 EDT 2020] Running upgrade converge step
2020-09-22 16:53:47 | 2020-09-22 16:53:47.490 647134 INFO osc_lib.shell [-] command: overcloud upgrade converge -> tripleoclient.v1.overcloud_upgrade.UpgradeConverge (auth=True)[00m
2020-09-22 16:53:47 | 2020-09-22 16:53:47.492 647134 INFO osc_lib.clientmanager [-] Using auth plugin: password[00m
2020-09-22 16:53:47 | 2020-09-22 16:53:47.493 647134 DEBUG osc_lib.clientmanager [-] Using parameters {'auth_url': 'https://192.168.24.2:13000', 'project_name': 'admin', 'project_domain_name': 'Default', 'username': 'admin', 'user_domain_name': 'Default', 'password': '***'} setup_auth /usr/lib/python3.6/site-packages/osc_lib/clientmanager.py:157[00m
2020-09-22 16:53:47 | 2020-09-22 16:53:47.495 647134 DEBUG osc_lib.clientmanager [-] Get auth_ref auth_ref /usr/lib/python3.6/site-packages/osc_lib/clientmanager.py:201[00m
2020-09-22 16:53:50 | 2020-09-22 16:53:50.059 647134 ERROR openstack [-] The following parameters should be removed from the environment files:
2020-09-22 16:53:50 | namespace_stein
2020-09-22 16:53:50 | name_prefix_stein
2020-09-22 16:53:50 | ceph3_tag
2020-09-22 16:53:50 | tag_stein
2020-09-22 16:53:50 | ceph3_namespace
2020-09-22 16:53:50 | ceph3_image
2020-09-22 16:53:50 | : tripleoclient.exceptions.BannedParameters: The following parameters should be removed from the environment files:[00m
2020-09-22 16:53:50 | 2020-09-22 16:53:50.061 647134 INFO osc_lib.shell [-] END return value: 1[00m
2020-09-22 16:53:50 | sys:1: ResourceWarning: unclosed <ssl.SSLSocket fd=4, family=AddressFamily.AF_INET, type=SocketKind.SOCK_STREAM, proto=6, laddr=('192.168.24.2', 32956), raddr=('192.168.24.2', 13000)>
2020-09-22 16:53:50 | sys:1: ResourceWarning: unclosed <ssl.SSLSocket fd=5, family=AddressFamily.AF_INET, type=SocketKind.SOCK_STREAM, proto=6, laddr=('192.168.24.2', 42530), raddr=('192.168.24.2', 13004)>

http://cougar11.scl.lab.tlv.redhat.com/DFG-upgrades-ffu-ffu-upgrade-13-16.1_director-rhel-virthost-3cont_2comp-ipv4-vxlan-HA-no-ceph/51/undercloud-0.tar.gz?undercloud-0/home/stack/overcloud_upgrade_converge.log

Which confirms that the patch works.

RPM versions:

openstack-tripleo-heat-templates-11.3.2-1.20200914170155.29a02c1.el8ost.noarch
python3-tripleoclient-12.3.2-1.20200914164926.72161e0.el8ost.noarch
openstack-tripleo-common-11.4.1-1.20200914165650.974b967.el8ost.noarch

Log: http://cougar11.scl.lab.tlv.redhat.com/DFG-upgrades-ffu-ffu-upgrade-13-16.1_director-rhel-virthost-3cont_2comp-ipv4-vxlan-HA-no-ceph/51/undercloud-0.tar.gz?undercloud-0/rpms.log

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (Red Hat OpenStack Platform 16.1 bug fix and enhancement advisory), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHEA-2020:4284