Bug 1851677 - [RFE] Allow passing arbitrary vars to ansible
Summary: [RFE] Allow passing arbitrary vars to ansible
Keywords:
Status: CLOSED DEFERRED
Alias: None
Product: cockpit-ovirt
Classification: oVirt
Component: Hosted Engine
Version: 0.12.8
Hardware: Unspecified
OS: Unspecified
low
medium
Target Milestone: ---
: ---
Assignee: Aviv Turgeman
QA Contact: Wei Wang
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2020-06-28 05:52 UTC by Yedidyah Bar David
Modified: 2021-11-12 10:29 UTC (History)
12 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of: 1849517
Environment:
Last Closed: 2021-09-29 11:33:06 UTC
oVirt Team: UX
Embargoed:


Attachments (Terms of Use)

Description Yedidyah Bar David 2020-06-28 05:52:10 UTC
+++ This bug was initially created as a clone of Bug #1849517 +++

Description of problem:

Current ovirt-hosted-engine-setup is a wrapper to several ansible playbooks.

The actual code is in a separate project, ovirt-ansible-hosted-engine-setup, with its own documentation - in particular, allowing passing specific variables to affects its behavior.

IMO it should be possible to allow passing such variables directly from 'hosted-engine --deploy', based on the documentation of ovirt-ansible-hosted-engine-setup, and with the understanding that this can conflict with variables otherwise already set by 'hosted-engine --deploy'.

I am currently opening this bug because we recently fixed bug 1816619, adding a new variable to affect the deploy process, but provide no easy means for the user to use this new functionality. While it can be even more helpful to add to 'hosted-engine --deploy' specific functionality for each such variable (including, perhaps, user interaction, validation, etc.), as we usually do, I do not think this is mandatory.

Version-Release number of selected component (if applicable):
Current master, probably since 4.3

How reproducible:
Always

Steps to Reproduce:
1. Install ovirt-ansible-hosted-engine-setup with a version that includes a fix to bug 1816619. 
2. Deploy hosted-engine with an old appliance and a broken mirror, such that 'dnf update ovirt-engine' on the engine VM fails, 
3.

Actual results:
Fails

Expected results:
Be able to easily pass some option that will cause the ansible code to run with he_offline_deployment=true, so that deploy will succeed

Additional info:
Already pushed a patch to do this, adding a new option:

    --ansible-extra-vars=VARS
        Pass '--extra-vars=VARS' to all ansible calls

This should allow to do (2.) as:

hosted-engine --deploy --ansible-extra-vars=he_offline_deployment=true

Opening this bug currently only on the CLI 'hosted-engine --deploy'. We probably want a similar bug for the cockpit UI - but I do not know the code there well, no idea how hard/easy it is to do.

--- Additional comment from Yedidyah Bar David on 2020-06-22 08:58:42 IDT ---

This was also reported in ovirt-users mailing list, thread subject was:

[ovirt-users] Hosted engine deployment fails consistently when trying to download files.

Comment 2 Michal Skrivanek 2021-08-20 11:01:46 UTC
This bug/RFE is more than a year old and it didn't get enough attention so far, and is now flagged as pending close. 
Please review if it is still relevant and provide additional details/justification/patches if you believe it should get more attention for the next oVirt release.

Comment 3 Michal Skrivanek 2021-09-29 11:33:06 UTC
This bug didn't get any attention in a long time, and it's not planned in foreseeable future. oVirt development team has no plans to work on it.
Please feel free to reopen if you have a plan how to contribute this feature/bug fix.


Note You need to log in before you can comment on or make changes to this bug.