Bug 1852059 - Review Request: flexiblas - A BLAS/LAPACK wrapper library with runtime exchangeable backends
Summary: Review Request: flexiblas - A BLAS/LAPACK wrapper library with runtime exchan...
Keywords:
Status: CLOSED NEXTRELEASE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Robert-André Mauchin 🐧
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2020-06-29 16:41 UTC by Iñaki Ucar
Modified: 2020-06-30 19:27 UTC (History)
2 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2020-06-30 19:27:45 UTC
Type: ---
Embargoed:
zebob.m: fedora-review+


Attachments (Terms of Use)

Description Iñaki Ucar 2020-06-29 16:41:22 UTC
Spec URL: https://iucar.fedorapeople.org/pkgs/flexiblas.spec
SRPM URL: https://iucar.fedorapeople.org/pkgs/flexiblas-3.0.0-1.fc31.src.rpm

koji scratch build: https://koji.fedoraproject.org/koji/taskinfo?taskID=46337536

Description: FlexiBLAS is a wrapper library that enables the exchange of the BLAS and LAPACK implementation used by a program without recompiling or relinking it.

Fedora Account System Username: iucar

Comment 1 Robert-André Mauchin 🐧 2020-06-30 11:49:51 UTC
 - Own these directories:

[!]: Package requires other packages for directories it uses.
     Note: No known owner of /etc/flexiblas64rc.d, /usr/lib64/flexiblas64,
     /etc/flexiblasrc.d, /usr/lib64/flexiblas

 - Main package has no binary, maybe make it Requires: wrapper or wrapper64


Package Review
==============

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed



===== MUST items =====

C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: Development (unversioned) .so files in -devel subpackage, if present.
     Note: Unversioned so-files in private %_libdir subdirectory (see
     attachment). Verify they are not in ld path.
[x]: If your application is a C or C++ application you must list a
     BuildRequires against gcc, gcc-c++ or clang.
[x]: Header files in -devel subpackage, if present.
[x]: ldconfig not called in %post and %postun for Fedora 28 and later.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.

Generic:
[x]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
     Guidelines.
[x]: License field in the package spec file matches the actual license.
     Note: Checking patched sources after %prep for licenses. Licenses
     found: "Unknown or generated", "GPL (v2 or later)", "Public domain",
     "GPL (v3 or later)", "GNU Lesser General Public License (v2.1 or
     later)", "Expat License", "BSD 2-clause "Simplified" License", "GNU
     General Public License (v3)". 15685 files have unknown license.
     Detailed output of licensecheck in
     /home/bob/packaging/review/flexiblas/review-flexiblas/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: If the package is under multiple licenses, the licensing breakdown
     must be documented in the spec.
[!]: Package requires other packages for directories it uses.
     Note: No known owner of /etc/flexiblas64rc.d, /usr/lib64/flexiblas64,
     /etc/flexiblasrc.d, /usr/lib64/flexiblas
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[x]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
     names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
     Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
     (~1MB) or number of files.
     Note: Documentation size is 40960 bytes in 3 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
     one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
     Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
     license(s) in its own file, then that file, containing the text of the
     license(s) for the package is included in %license.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
[x]: %config files are marked noreplace or the reason is justified.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
     work.
[x]: Package is named using only allowed ASCII characters.
[x]: No %config files under /usr.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
     provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
     %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

===== SHOULD items =====

Generic:
[-]: If the source package does not include license text(s) as a separate
     file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[?]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[-]: Sources are verified with gpgverify first in %prep if upstream
     publishes signatures.
     Note: gpgverify is not used.
[-]: Description and summary sections in the package spec file contains
     translations for supported Non-English languages, if available.
[x]: Package should compile and build into binary rpms on all supported
     architectures.
[x]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed
     files.
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
     $RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Fully versioned dependency in subpackages if applicable.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: The placement of pkgconfig(.pc) files are correct.
[x]: Sources can be downloaded from URI in Source: tag
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define unless justified.

===== EXTRA items =====

Generic:
[x]: Rpmlint is run on debuginfo package(s).
     Note: No rpmlint messages.
[x]: Rpmlint is run on all installed packages.
     Note: There are rpmlint messages (see attachment).
[x]: Large data in /usr/share should live in a noarch subpackage if package
     is arched.
[x]: Spec file according to URL is the same as in SRPM.


Rpmlint
-------
Checking: flexiblas-3.0.0-1.fc33.x86_64.rpm
          flexiblas-wrapper-3.0.0-1.fc33.x86_64.rpm
          flexiblas-devel-3.0.0-1.fc33.x86_64.rpm
          flexiblas-atlas-3.0.0-1.fc33.x86_64.rpm
          flexiblas-blis-serial-3.0.0-1.fc33.x86_64.rpm
          flexiblas-blis-openmp-3.0.0-1.fc33.x86_64.rpm
          flexiblas-blis-threads-3.0.0-1.fc33.x86_64.rpm
          flexiblas-openblas-serial-3.0.0-1.fc33.x86_64.rpm
          flexiblas-openblas-openmp-3.0.0-1.fc33.x86_64.rpm
          flexiblas-openblas-threads-3.0.0-1.fc33.x86_64.rpm
          flexiblas-wrapper64-3.0.0-1.fc33.x86_64.rpm
          flexiblas-blis-serial64-3.0.0-1.fc33.x86_64.rpm
          flexiblas-blis-openmp64-3.0.0-1.fc33.x86_64.rpm
          flexiblas-blis-threads64-3.0.0-1.fc33.x86_64.rpm
          flexiblas-openblas-serial64-3.0.0-1.fc33.x86_64.rpm
          flexiblas-openblas-openmp64-3.0.0-1.fc33.x86_64.rpm
          flexiblas-openblas-threads64-3.0.0-1.fc33.x86_64.rpm
          flexiblas-debuginfo-3.0.0-1.fc33.x86_64.rpm
          flexiblas-debugsource-3.0.0-1.fc33.x86_64.rpm
          flexiblas-3.0.0-1.fc33.src.rpm
flexiblas.x86_64: W: spelling-error %description -l en_US relinking -> relining, re linking, re-linking
flexiblas.x86_64: E: no-binary
flexiblas-wrapper.x86_64: W: spelling-error %description -l en_US relinking -> relining, re linking, re-linking
flexiblas-wrapper.x86_64: W: non-conffile-in-etc /etc/flexiblasrc.d/netlib.conf
flexiblas-devel.x86_64: W: spelling-error %description -l en_US relinking -> relining, re linking, re-linking
flexiblas-atlas.x86_64: W: spelling-error %description -l en_US relinking -> relining, re linking, re-linking
flexiblas-atlas.x86_64: W: no-documentation
flexiblas-atlas.x86_64: W: non-conffile-in-etc /etc/flexiblasrc.d/atlas.conf
flexiblas-blis-serial.x86_64: W: spelling-error %description -l en_US relinking -> relining, re linking, re-linking
flexiblas-blis-serial.x86_64: W: no-documentation
flexiblas-blis-serial.x86_64: W: non-conffile-in-etc /etc/flexiblasrc.d/blis-serial.conf
flexiblas-blis-openmp.x86_64: W: spelling-error %description -l en_US relinking -> relining, re linking, re-linking
flexiblas-blis-openmp.x86_64: W: no-documentation
flexiblas-blis-openmp.x86_64: W: non-conffile-in-etc /etc/flexiblasrc.d/blis-openmp.conf
flexiblas-blis-threads.x86_64: W: spelling-error %description -l en_US relinking -> relining, re linking, re-linking
flexiblas-blis-threads.x86_64: W: no-documentation
flexiblas-blis-threads.x86_64: W: non-conffile-in-etc /etc/flexiblasrc.d/blis-threads.conf
flexiblas-openblas-serial.x86_64: W: spelling-error %description -l en_US relinking -> relining, re linking, re-linking
flexiblas-openblas-serial.x86_64: W: no-documentation
flexiblas-openblas-serial.x86_64: W: non-conffile-in-etc /etc/flexiblasrc.d/openblas-serial.conf
flexiblas-openblas-openmp.x86_64: W: spelling-error %description -l en_US relinking -> relining, re linking, re-linking
flexiblas-openblas-openmp.x86_64: W: no-documentation
flexiblas-openblas-openmp.x86_64: W: non-conffile-in-etc /etc/flexiblasrc.d/openblas-openmp.conf
flexiblas-openblas-threads.x86_64: W: spelling-error %description -l en_US relinking -> relining, re linking, re-linking
flexiblas-openblas-threads.x86_64: W: no-documentation
flexiblas-openblas-threads.x86_64: W: non-conffile-in-etc /etc/flexiblasrc.d/openblas-threads.conf
flexiblas-wrapper64.x86_64: W: spelling-error %description -l en_US relinking -> relining, re linking, re-linking
flexiblas-wrapper64.x86_64: W: non-conffile-in-etc /etc/flexiblas64rc.d/netlib.conf
flexiblas-blis-serial64.x86_64: W: spelling-error %description -l en_US relinking -> relining, re linking, re-linking
flexiblas-blis-serial64.x86_64: W: no-documentation
flexiblas-blis-serial64.x86_64: W: non-conffile-in-etc /etc/flexiblas64rc.d/blis-serial64.conf
flexiblas-blis-openmp64.x86_64: W: spelling-error %description -l en_US relinking -> relining, re linking, re-linking
flexiblas-blis-openmp64.x86_64: W: no-documentation
flexiblas-blis-openmp64.x86_64: W: non-conffile-in-etc /etc/flexiblas64rc.d/blis-openmp64.conf
flexiblas-blis-threads64.x86_64: W: spelling-error %description -l en_US relinking -> relining, re linking, re-linking
flexiblas-blis-threads64.x86_64: W: no-documentation
flexiblas-blis-threads64.x86_64: W: non-conffile-in-etc /etc/flexiblas64rc.d/blis-threads64.conf
flexiblas-openblas-serial64.x86_64: W: spelling-error %description -l en_US relinking -> relining, re linking, re-linking
flexiblas-openblas-serial64.x86_64: W: no-documentation
flexiblas-openblas-serial64.x86_64: W: non-conffile-in-etc /etc/flexiblas64rc.d/openblas-serial64.conf
flexiblas-openblas-openmp64.x86_64: W: spelling-error %description -l en_US relinking -> relining, re linking, re-linking
flexiblas-openblas-openmp64.x86_64: W: no-documentation
flexiblas-openblas-openmp64.x86_64: W: non-conffile-in-etc /etc/flexiblas64rc.d/openblas-openmp64.conf
flexiblas-openblas-threads64.x86_64: W: spelling-error %description -l en_US relinking -> relining, re linking, re-linking
flexiblas-openblas-threads64.x86_64: W: no-documentation
flexiblas-openblas-threads64.x86_64: W: non-conffile-in-etc /etc/flexiblas64rc.d/openblas-threads64.conf
flexiblas.src: W: spelling-error %description -l en_US relinking -> relining, re linking, re-linking
20 packages and 0 specfiles checked; 1 errors, 46 warnings.

Comment 2 Iñaki Ucar 2020-06-30 17:34:46 UTC
Spec URL: https://iucar.fedorapeople.org/pkgs/flexiblas.spec
SRPM URL: https://iucar.fedorapeople.org/pkgs/flexiblas-3.0.0-2.fc31.src.rpm

koji scratch build: https://koji.fedoraproject.org/koji/taskinfo?taskID=46387120

Changes:
- Own provided directories: as requested.
- More robust file renaming: it failed if all backends were disabled, because rename didn't find any file to rename.
- Rename wrapper(64) subpackages to netlib(64): I think this is more appropriate. Also, if we change %{default_backend} to "netlib", then these packages just require themselves.
- Conditionalize all external libraries, as well as the default: now I'm using %bcond_without for all the backends, so that it's easy to disable them if there is any issue with them. And the %{default_backend} changes automatically to "netlib" if OpenBLAS is not available.
- Disable Blis64 on s390x, which is currently unavailable: basically, Blis doesn't detect 64-bit capabilities on that platform, and those packages are just 32-bit builds. Reported in https://bugzilla.redhat.com/show_bug.cgi?id=1852549

About the main package, I'm reluctanct to require either netlib or netlib64, because that would pull that version too for all the packages linking to the other one. There are two use cases for FlexiBLAS:

1) another package links against it, so when a user install such a package, the required FlexiBLAS bits are installed too, but the user is completely unaware of that;
2) the user knows about FlexiBLAS and actually wants to install it to use it for a local build; then the user needs to install flexiblas-devel, not flexiblas.

So basically there's no use case for the main package alone.

Comment 3 Robert-André Mauchin 🐧 2020-06-30 18:08:06 UTC
LGTM, package approved.

Comment 4 Gwyn Ciesla 2020-06-30 19:01:36 UTC
(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/flexiblas


Note You need to log in before you can comment on or make changes to this bug.