Red Hat Bugzilla – Bug 185212
Review Request: freedoom - open source doom game files
Last modified: 2007-11-30 17:11:27 EST
Spec Name or Url: http://www.kobold.org/~wart/fedora/freedoom.spec SRPM Name or Url: http://www.kobold.org/~wart/fedora/freedoom-0.4.1-1.src.rpm Description: Freely distributable game files for Doom. This is an alternative set of game files to replace the shareware game files for Doom. This package has a hard requirement on prboom in the .desktop file which is reflected in the Requires tag. This will eventually be changed to require 'doom-engine' so that it can be played with alternate doom engines. Note that this introduces a circular dependency where freedoom Requires prboom, and prboom Requires freedoom.
Adding Hans to cc: per his request.
Changes to the game data files directory, per the discussion in BZ #185211 (prboom) http://www.kobold.org/~wart/fedora/freedoom-0.4.1-2.src.rpm http://www.kobold.org/~wart/fedora/freedoom.spec
MUST ==== * Source tarball matches upstream * Package (and .spec) named properly * License file included * Spec file readable, in Am. English * Builds on FC-5 x86_64 * No locale files * No excessive BR: or Requires: * Not relocatable * buildroot cleaned up in %install and %clean * No duplicate files * permissions ok * Macro usage consistent * Contains permissable content * Desktop file included and properly installed MUST FIX ======== License must be BSD not Distributable SHOULD FIX ========== * Use %{version} in Source0 * Remove: # This package should Provide <enginename>-data for each doom engine # that it is known to work with. Concedering the procedure for doom wads we agreed on this is no longer true.
One more try to address all must and should fix issues: http://www.kobold.org/~wart/fedora/freedoom-0.4.1-3.src.rpm http://www.kobold.org/~wart/fedora/freedoom.spec
Looks good, APPROVED.
Imported and built. Thanks!