Note: This bug is displayed in read-only format because the product is no longer active in Red Hat Bugzilla.

Bug 1852354

Summary:	Hotplug memory with the same id to previous one, qemu got coredump
Product:	Red Hat Enterprise Linux Advanced Virtualization	Reporter:	Min Deng <mdeng>
Component:	qemu-kvm	Assignee:	Greg Kurz <gkurz>
qemu-kvm sub component:	General	QA Contact:	Min Deng <mdeng>
Status:	CLOSED ERRATA	Docs Contact:
Severity:	high
Priority:	high	CC:	bfu, bugproxy, ddepaula, dgibson, gkurz, hannsj_uhl, ngu, qzhang, virt-maint, xianwang, xuma, yanghliu, yihyu, zhenyzha
Version:	8.3	Keywords:	Patch, Regression
Target Milestone:	rc	Flags:	pm-rhel: mirror+
Target Release:	8.3
Hardware:	ppc64le
OS:	Linux
Whiteboard:
Fixed In Version:	qemu-kvm-5.1.0-2.module+el8.3.0+7652+b30e6901	Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2020-11-17 17:49:34 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	1776265

Description Min Deng 2020-06-30 08:40:29 UTC

Description of problem:
Hotplug memory with the same id to previous one, qemu got coredump
Version-Release number of selected component (if applicable):
kernel-4.18.0-221.el8.ppc64le
qemu-kvm-5.0.0-0.scrmod+el8.3.0+7150+88a2c83e.wrb200624.ppc64le

How reproducible:
always

Steps to Reproduce:
1./usr/libexec/qemu-kvm -name avocado-vt-vm1 -machine pseries,max-cpu-compat=power8 -nodefaults -device virtio-scsi-pci,id=viri_pci0,bus=pci.0,addr=0x4 -blockdev node-name=disk1,file.driver=file,driver=qcow2,file.driver=file,file.filename=rhel830-ppc64le-virtio-scsi.qcow2.backup.p8 -device scsi-hd,id=image1,drive=disk1 -device virtio-net-pci,mac=9a:4c:4d:4e:4f:60,id=idtniYmJ,vectors=4,netdev=idG7NvsN,bus=pci.0,addr=0x5 -netdev tap,id=idG7NvsN,vhost=on,script=/etc/qemu-ifup,downscript=/etc/qemu-ifdown -m 4G,slots=256,maxmem=1T -overcommit mem-lock=off -smp 32 -vnc :11 -rtc base=utc,clock=host -boot menu=off,strict=off,order=cdn,once=c -enable-kvm -monitor stdio -chardev socket,id=serial_id_serial0,path=/tmp/4,server,nowait -device spapr-vty,reg=0x30000000,chardev=serial_id_serial0
QEMU 5.0.50 monitor - type 'help' for more information
(qemu) object_add memory-backend-ram,id=mem10,id=mem10,size=10G
(qemu) device_add pc-dimm,id=dimm10,memdev=mem10
(qemu) 
(qemu) 
(qemu) 
(qemu) device_del dimm10
(qemu) object_del mem10
Error: object 'mem10' is in use, can not be deleted
(qemu) object_del mem10
(qemu)  object_add memory-backend-ram,id=mem10,id=mem10,size=10G
(qemu) device_add pc-dimm,id=dimm10,memdev=mem10
(qemu) device_del dimm10
(qemu) object_del mem10
Error: object 'mem10' is in use, can not be deleted
(qemu) object_add memory-backend-ram,id=mem10,id=mem10,size=10G
Unexpected error in object_property_try_add() at /builddir/build/BUILD/qemu-5.0.0/qom/object.c:1167:
attempt to add duplicate property 'mem10' to object (type 'container')



Actual results:
(qemu) object_add memory-backend-ram,id=mem10,id=mem10,size=10G
Unexpected error in object_property_try_add() at /builddir/build/BUILD/qemu-5.0.0/qom/object.c:1167:
attempt to add duplicate property 'mem10' to object (type 'container')

Expected results:
QEMU works well

Additional info:
please add "movable_node" to guest's kernel line

Comment 2 Min Deng 2020-06-30 08:49:45 UTC

Will try it on x86 later.

Comment 5 IBM Bug Proxy 2020-07-10 13:41:20 UTC

------- Comment From sthoufee.com 2020-06-30 08:46 EDT-------
Could see already patch in qemu community which is under discussion.
.
https://patchew.org/QEMU/20200624194809.26600-1-eric.auger@redhat.com/

Comment 6 Greg Kurz 2020-07-10 14:05:04 UTC

(In reply to IBM Bug Proxy from comment #5)
> ------- Comment From sthoufee.com 2020-06-30 08:46 EDT-------
> Could see already patch in qemu community which is under discussion.
> .
> https://patchew.org/QEMU/20200624194809.26600-1-eric.auger@redhat.com/

A more recent version of this series was posted:

https://patchew.org/QEMU/20200629193424.30280-1-eric.auger@redhat.com/

and currently in Paolo Bonzini's latest PR:

https://patchew.org/QEMU/20200708172542.25012-1-pbonzini@redhat.com/

It should be merged shortly after some unrelated build problems in
this PR are addressed.

Comment 7 David Gibson 2020-07-13 04:37:02 UTC

Looks like we expect to get this in qemu-5.1, and therefore in RHEL-AV-9.3.  Setting ITR accordingly.

Comment 11 Min Deng 2020-08-17 05:39:05 UTC

Verified the bug on the following build
qemu-kvm-5.1.0-2.module+el8.3.0+7652+b30e6901.ppc64le
kernel-4.18.0-232.el8.ppc64le
Steps, please see description
Actual results,
qemu worked well without core dump issue
Expected results,
qemu works well without core dump issue

So move this bug to be verified, thanks.

Comment 14 errata-xmlrpc 2020-11-17 17:49:34 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (virt:8.3 bug fix and enhancement update), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2020:5137