Bug 1852437 - perl-Perl-Critic-1.138-4.fc33 FTBFS with Perl 5.32: subroutine name is a homonym for builtin function isa at line 140
Summary: perl-Perl-Critic-1.138-4.fc33 FTBFS with Perl 5.32: subroutine name is a homo...
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: perl-Perl-Critic
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Paul Howarth
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: F33FTBFS
TreeView+ depends on / blocked
 
Reported: 2020-06-30 12:28 UTC by Petr Pisar
Modified: 2020-07-11 17:54 UTC (History)
4 users (show)

Fixed In Version: perl-Perl-Critic-1.138-5.fc33
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2020-07-11 17:54:10 UTC
Type: Bug


Attachments (Terms of Use)


Links
System ID Priority Status Summary Last Updated
Github Perl-Critic Perl-Critic issues 911 None open xt/40_criticize-code.t fails with Perl 5.32: subroutine name is a homonym for builtin function isa at line 140 2020-07-11 15:17:06 UTC

Description Petr Pisar 2020-06-30 12:28:13 UTC
perl-Perl-Critic-1.138-4.fc33 fails to build in Fedora 33 because a test fails with Perl 5.32:

t/gh-734.t .................................... ok
#   Failed test 'Test::Perl::Critic for "blib/lib/Perl/Critic/Document.pm"'
#   at /usr/share/perl5/vendor_perl/Test/Perl/Critic.pm line 121.
# 
#   blib/lib/Perl/Critic/Document.pm: Subroutine name is a homonym for builtin function isa at line 140, column 1.  See page 177 of PBP.  (Severity: 4, Subroutines::ProhibitBuiltinHomonyms)
xt/40_criticize-code.t ........................ 
Dubious, test returned 1 (wstat 256, 0x100)
Failed 1/198 subtests

Comment 1 Paul Howarth 2020-06-30 12:33:17 UTC
As "isa" is a documented part of Perl::Critic::Document's API, I suspect that the fix for this will just be to add a ##nocritic pragma to waive the check.

Comment 2 Paul Howarth 2020-07-11 17:54:10 UTC
I worked around this using a "## nocritic" pragma, but the long-term fix might be to include making "isa" a special case like "import", "AUTOLOAD", and "DESTROY" already are, as they are commonly overridden. That's one for upstream to decide though.


Note You need to log in before you can comment on or make changes to this bug.