Bug 1852546 - regression: xlock SEGV on -startCmd
Summary: regression: xlock SEGV on -startCmd
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: xlockmore
Version: 32
Hardware: x86_64
OS: Linux
unspecified
low
Target Milestone: ---
Assignee: Adrian Reber
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2020-06-30 16:44 UTC by Jan Kratochvil
Modified: 2020-07-09 01:06 UTC (History)
3 users (show)

Fixed In Version: xlockmore-5.64-2.fc32 xlockmore-5.64-2.fc31
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2020-07-09 01:05:31 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)
Fix. (1.39 KB, patch)
2020-06-30 16:59 UTC, Jan Kratochvil
no flags Details | Diff

Description Jan Kratochvil 2020-06-30 16:44:51 UTC
Description of problem:
SSIA

Version-Release number of selected component (if applicable):
FAIL: xlockmore-5.61-2.fc32.x86_64
PASS: xlockmore-5.64-1.fc33.x86_64

How reproducible:
Always.

Steps to Reproduce:
xlock -startCmd true 

Actual results:
Jun 30 18:39:38 host2 xlock[114113]: Start: lace, lace, :0
Jun 30 18:39:38 host2 kernel: xlock[114118]: segfault at 7f99f3af49d0 ip 00007f9a02eba872 sp 00007ffcd2807b00 error 4 in libpthread-2.31.so[7f9a02eb7000+10000]
Jun 30 18:39:38 host2 kernel: Code: 54 24 f8 c3 0f 1f 40 00 f3 0f 1e fa 41 57 41 56 41 55 41 54 55 53 48 83 ec 68 64 48 8b 04 25 28 00 00 00 48 89 44 24 58 31 c0 <8b> 87 d0 02 00 00 85 c0 0f 88 30 02 00 00 49 89 ff 48 39 bf 28 06
Jun 30 18:39:43 host2 xlock[114113]: Stop: lace, lace, :0, 0m 5s

Expected results:
Jun 30 18:39:52 host2 xlock[114132]: Start: lace, lace, :0
Jun 30 18:39:55 host2 xlock[114132]: Stop: lace, lace, :0, 0m 3s

Additional info:
The command itself does not SEGV, it forks a child which does SEGV.

(gdb) bt
#0  __pthread_clockjoin_ex (threadid=140073336301312, thread_return=thread_return@entry=0x7fffdb89bac0, clockid=clockid@entry=0, abstime=abstime@entry=0x0, block=block@entry=true)
    at pthread_join_common.c:89
#1  0x00007f6564b047c3 in __pthread_join (threadid=<optimized out>, thread_return=thread_return@entry=0x7fffdb89bac0) at pthread_join.c:24
#2  0x00007f656334ce77 in thrd_join (res=0x0, thr=<optimized out>) at ../include/c11/threads_posix.h:329
#3  util_queue_kill_threads (finish_locked=false, keep_num_threads=<optimized out>, queue=0x1b9d540) at ../src/util/u_queue.c:496
#4  util_queue_kill_threads (queue=0x1b9d540, keep_num_threads=<optimized out>, finish_locked=<optimized out>) at ../src/util/u_queue.c:472
#5  0x00007f656334cf2c in atexit_handler () at ../src/util/u_queue.c:62
#6  0x00007f656496f3d7 in __run_exit_handlers (status=0, listp=0x7f6564af3578 <__exit_funcs>, run_list_atexit=run_list_atexit@entry=true, run_dtors=run_dtors@entry=true)
    at exit.c:108
#7  0x00007f656496f580 in __GI_exit (status=<optimized out>) at exit.c:139
#8  0x000000000040be54 in ?? ()
#9  0x0000000000000001 in ?? ()
#10 0x0000000000000000 in ?? ()
(gdb) frame 5
#5  0x00007f656334cf2c in atexit_handler () at ../src/util/u_queue.c:62
62	      util_queue_kill_threads(iter, 0, false);
(gdb) info source
Current source file is ../src/util/u_queue.c
Compilation directory is /usr/src/debug/mesa-20.1.2-1.fc32.x86_64/x86_64-redhat-linux-gnu
Located in /usr/src/debug/mesa-20.1.2-1.fc32.x86_64/src/util/u_queue.c
Contains 685 lines.
Source language is c.
Producer is GNU C99 10.1.1 20200507 (Red Hat 10.1.1-1) -m64 -mtune=generic -march=x86-64 -g -O2 -std=c99 -fno-math-errno -fno-trapping-math -fexceptions -fstack-protector-strong -fasynchronous-unwind-tables -fstack-clash-protection -fcf-protection=full -fcommon -fPIC -fvisibility=hidden -fplugin=annobin.
Compiled with DWARF 2 debugging format.
Does not include preprocessor macro info.

I did not investigate it more when a newer version has it fixed.

Comment 1 Jan Kratochvil 2020-06-30 16:51:54 UTC
update:
FAIL: xlockmore-5.64-1.fc33.x86_64
Even the new version is crashing.

Comment 2 Jan Kratochvil 2020-06-30 16:59:51 UTC
Created attachment 1699353 [details]
Fix.

Comment 3 Fedora Update System 2020-06-30 17:32:55 UTC
FEDORA-2020-da091a0755 has been submitted as an update to Fedora 32. https://bodhi.fedoraproject.org/updates/FEDORA-2020-da091a0755

Comment 4 Fedora Update System 2020-06-30 18:48:13 UTC
FEDORA-2020-8649bf4b07 has been submitted as an update to Fedora 31. https://bodhi.fedoraproject.org/updates/FEDORA-2020-8649bf4b07

Comment 5 Fedora Update System 2020-07-01 02:10:09 UTC
FEDORA-2020-8649bf4b07 has been pushed to the Fedora 31 testing repository.
In short time you'll be able to install the update with the following command:
`sudo dnf upgrade --enablerepo=updates-testing --advisory=FEDORA-2020-8649bf4b07`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2020-8649bf4b07

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 6 Fedora Update System 2020-07-01 02:19:25 UTC
FEDORA-2020-da091a0755 has been pushed to the Fedora 32 testing repository.
In short time you'll be able to install the update with the following command:
`sudo dnf upgrade --enablerepo=updates-testing --advisory=FEDORA-2020-da091a0755`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2020-da091a0755

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 7 Fedora Update System 2020-07-09 01:05:31 UTC
FEDORA-2020-da091a0755 has been pushed to the Fedora 32 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 8 Fedora Update System 2020-07-09 01:06:41 UTC
FEDORA-2020-8649bf4b07 has been pushed to the Fedora 31 stable repository.
If problem still persists, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.