Bug 1852583 - Review Request: epel-release - Extra Packages for Enterprise Linux repository configuration
Summary: Review Request: epel-release - Extra Packages for Enterprise Linux repository...
Keywords:
Status: NEW
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Nobody's working on this, feel free to take it
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2020-06-30 18:35 UTC by Miro Hrončok
Modified: 2020-07-01 14:53 UTC (History)
2 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed:
Type: ---


Attachments (Terms of Use)

Description Miro Hrončok 2020-06-30 18:35:28 UTC
Spec URL: https://churchyard.fedorapeople.org/SRPMS/epel-release.spec
SRPM URL: https://churchyard.fedorapeople.org/SRPMS/epel-release-8-9.fc33.src.rpm

Description:
This package contains the Extra Packages for Enterprise Linux (EPEL)
repository GPG key as well as configuration for yum.

Fedora Account System Username: churchyard

This package is retired in Fedora, see https://src.fedoraproject.org/rpms/epel-release/pull-request/9 with individual commits.

Comment 2 Robert-André Mauchin 🐧 2020-07-01 14:53:16 UTC
 - /etc/ → %{_sysconfdir} everywhere

%files -n epel6-repos
%doc README.md
%license GPL
%dir %{_sysconfdir}/yum.repos.d/
%config(noreplace) %{_sysconfdir}/yum.repos.d/epel6*.repo
%dir %{_sysconfdir}/pki/rpm-gpg/
%{_sysconfdir}/pki/rpm-gpg/RPM-GPG-KEY-EPEL-6

%files -n epel7-repos
%doc README.md
%license GPL
%dir %{_sysconfdir}/yum.repos.d/
%config(noreplace) %{_sysconfdir}/yum.repos.d/epel7*.repo
%dir %{_sysconfdir}/pki/rpm-gpg/
%{_sysconfdir}/pki/rpm-gpg/RPM-GPG-KEY-EPEL-7

%files -n epel8-repos
%doc README.md
%license GPL
%dir %{_sysconfdir}/yum.repos.d/
%config(noreplace) %{_sysconfdir}/yum.repos.d/epel8*.repo
%dir %{_sysconfdir}/pki/rpm-gpg/
%{_sysconfdir}/pki/rpm-gpg/RPM-GPG-KEY-EPEL-8

 - Malformed dist tag:

Release:        9%{?dist}

 - Use a GPL license file with an updated FSF address:

E: incorrect-fsf-address /usr/share/licenses/epel8-repos/GPL




Package Review
==============

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed


Issues:
=======
- Dist tag is present.
- Package does not use a name that already exists.
  Note: A package with this name already exists. Please check
  https://src.fedoraproject.org/rpms/epel-release
  See: https://docs.fedoraproject.org/en-US/packaging-
  guidelines/Naming/#_conflicting_package_names


===== MUST items =====

Generic:
[x]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
     Guidelines.
[x]: License field in the package spec file matches the actual license.
     Note: Checking patched sources after %prep for licenses. Licenses
     found: "GNU Lesser General Public License", "Unknown or generated". 1
     files have unknown license. Detailed output of licensecheck in
     /home/bob/packaging/review/epel-release/review-epel-
     release/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: Package does not own files or directories owned by other packages.
     Note: Dirs in package are owned also by: /etc/pki/rpm-gpg(fedora-gpg-
     keys), /etc/yum.repos.d(fedora-repos)
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[!]: Package consistently uses macros (instead of hard-coded directory
     names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
     Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
     (~1MB) or number of files.
     Note: Documentation size is 30720 bytes in 3 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
     one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
     Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
     license(s) in its own file, then that file, containing the text of the
     license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
[x]: %config files are marked noreplace or the reason is justified.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
     work.
[x]: Package is named using only allowed ASCII characters.
[x]: No %config files under /usr.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
     provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
     %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

===== SHOULD items =====

Generic:
[-]: If the source package does not include license text(s) as a separate
     file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[-]: Fully versioned dependency in subpackages if applicable.
     Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in
     epel6-repos , epel7-repos , epel8-repos
[?]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[x]: Sources are verified with gpgverify first in %prep if upstream
     publishes signatures.
     Note: gpgverify is not used.
[-]: Description and summary sections in the package spec file contains
     translations for supported Non-English languages, if available.
[x]: Package should compile and build into binary rpms on all supported
     architectures.
[-]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed
     files.
[ ]: Spec use %global instead of %define unless justified.
     Note: %define requiring justification: %define desc() %{expand:,
     %define sum() Extra Packages for Enterprise Linux%{?1: %{1}}
     repository configuration
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
     $RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: SourceX is a working URL.

===== EXTRA items =====

Generic:
[x]: Rpmlint is run on all installed packages.
     Note: There are rpmlint messages (see attachment).
[x]: Spec file according to URL is the same as in SRPM.


Rpmlint
-------
Checking: epel6-repos-6-9.fc33.noarch.rpm
          epel7-repos-7-9.fc33.noarch.rpm
          epel8-repos-8-9.fc33.noarch.rpm
          epel-release-8-9.fc33.src.rpm
epel6-repos.noarch: W: non-conffile-in-etc /etc/pki/rpm-gpg/RPM-GPG-KEY-EPEL-6
epel6-repos.noarch: E: incorrect-fsf-address /usr/share/licenses/epel6-repos/GPL
epel7-repos.noarch: W: non-conffile-in-etc /etc/pki/rpm-gpg/RPM-GPG-KEY-EPEL-7
epel7-repos.noarch: E: incorrect-fsf-address /usr/share/licenses/epel7-repos/GPL
epel8-repos.noarch: W: non-conffile-in-etc /etc/pki/rpm-gpg/RPM-GPG-KEY-EPEL-8
epel8-repos.noarch: E: incorrect-fsf-address /usr/share/licenses/epel8-repos/GPL
4 packages and 0 specfiles checked; 3 errors, 3 warnings.


Note You need to log in before you can comment on or make changes to this bug.