SRPM Name or Url: http://www.environnement.ens.fr/perso/dumas/fc-srpms/gnochm-0.9.7-1.src.rpm Description: A CHM file viewer for Gnome. Features are: * Full text search * Bookmarks * Support for external ms-its links * Configurable support for http links * Internationalisation * Displays HTML page source
Built fine, but when I tried to run it complained "No module named chm" Works with python-chm installed. rpm isn't picking up that it requires python-chm, make it explicit in the spec.
Thanks. I also removed python-chm from the BuildRequires, as it doesn't seems to be required when building. Updated srpm available here: http://www.environnement.ens.fr/perso/dumas/fc-srpms/gnochm-0.9.7-1.src.rpm
Builds, but some deps really should be explicit: * BuildRequires: gettext is missing (required by the %find_lang macro) * Missing dependancy on update-mime-database for %post (package shared-mime-info) * Missing dependancy on update-mime-database for %postun (package shared-mime-info) Otherwise: - rpmlint checks return: W: gnochm conffile-without-noreplace-flag /etc/gconf/schemas/gnochm.schemas can ignore - package meets naming guidelines - package meets packaging guidelines - license (GPL) OK, text in %doc, matches source - spec file legible, in am. english - source matches upstream - package compiles on devel (x86_64) - no unnecessary BR - locales handled by %find_lang - not relocatable - owns all directories that it creates - no duplicate files - permissions ok - %clean ok - macro use consistent - code, not content - no need for -docs - nothing in %doc affects runtime - .desktop file
I didn't add a BR on shared-mime-info, because this is explicitely said here that such BR shouldn't be added: http://fedoraproject.org/wiki/ScriptletSnippets#head-ef39068afc1677de2e6b4370ad0fb24dafd4d47b
(In reply to comment #4) > I didn't add a BR on shared-mime-info, because this is explicitely said here > that such BR shouldn't be added: > > http://fedoraproject.org/wiki/ScriptletSnippets#head-ef39068afc1677de2e6b4370ad0fb24dafd4d47b OK. And it did build and runs. APPROVED.
Builds in devel, thanks for the review.