Bug 1852844 - unclosed <socket.socket fd=8, family=AddressFamily.AF_INET, type=SocketKind.SOCK_STREAM, proto=0, laddr=('0.0.0.0', 46460)>
Summary: unclosed <socket.socket fd=8, family=AddressFamily.AF_INET, type=SocketKind.S...
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Red Hat OpenStack
Classification: Red Hat
Component: python-tripleoclient
Version: 16.1 (Train)
Hardware: Unspecified
OS: Unspecified
low
low
Target Milestone: ---
: ---
Assignee: Alex Schultz
QA Contact: David Rosenfeld
URL:
Whiteboard:
: 1875602 (view as bug list)
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2020-07-01 12:29 UTC by Cédric Jeanneret
Modified: 2020-10-28 15:38 UTC (History)
9 users (show)

Fixed In Version: python-tripleoclient-12.3.2-1.20200804133405.0e7c3ab.el8ost
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2020-10-28 15:38:12 UTC
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Launchpad 1888676 0 None None None 2020-07-24 21:02:12 UTC
OpenStack gerrit 742678 0 None MERGED [TRAIN-and-older] Properly close sockets 2020-12-24 10:40:47 UTC
Red Hat Product Errata RHEA-2020:4284 0 None None None 2020-10-28 15:38:33 UTC

Description Cédric Jeanneret 2020-07-01 12:29:49 UTC
Description of problem:
In osp-16.1 python-tripleoclient, we see a bunch of unclosed resources such as:


/usr/lib/python3.6/site-packages/tripleoclient/workflows/deployment.py:181: ResourceWarning: unclosed <socket.socket fd=8, family=AddressFamily.AF_INET, type=SocketKind.SOCK_STREAM, proto=0, laddr=('0.0.0.0', 46460)>                      
  sock = socket.socket(socket.AF_INET6)
/usr/lib/python3.6/site-packages/tripleoclient/workflows/deployment.py:175: ResourceWarning: unclosed <socket.socket fd=9, family=AddressFamily.AF_INET6, type=SocketKind.SOCK_STREAM, proto=0, laddr=('::', 0, 0, 0)>                        
  sock = socket.socket()

This is due to python3 being more careful and strict with opened sockets and files.

Since we don't see it in upstream master, it might be "just" a missing backport, or, in fact, due to the fact we dropped mistral for most of the deploy tasks...


Version-Release number of selected component (if applicable):
python3-tripleoclient-12.3.2-0.20200615103427.6f877f6.el8ost.noarch

How reproducible:
Always


Steps to Reproduce:
1. deploy the undercloud
2. deploy the overcloud
3. check the warnings

Actual results:
We see unwanted warning about unclosed sockets

Expected results:
we shouldn't see it

Additional info:

Comment 1 Alex Schultz 2020-07-01 12:57:54 UTC
Need to figure out which client is not properly cleaning up after itself.

Comment 2 Emilien Macchi 2020-09-08 13:37:52 UTC
*** Bug 1875602 has been marked as a duplicate of this bug. ***

Comment 10 errata-xmlrpc 2020-10-28 15:38:12 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (Red Hat OpenStack Platform 16.1 bug fix and enhancement advisory), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHEA-2020:4284


Note You need to log in before you can comment on or make changes to this bug.