Bug 1853501 - [RFE] Add column with storage domain in the "Storage -> Disks" page
Summary: [RFE] Add column with storage domain in the "Storage -> Disks" page
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: ovirt-engine
Classification: oVirt
Component: Frontend.WebAdmin
Version: 4.4.0.3
Hardware: Unspecified
OS: Unspecified
unspecified
low with 1 vote
Target Milestone: ovirt-4.4.8
: ---
Assignee: Bella Khizgiyaev
QA Contact: sshmulev
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2020-07-02 20:13 UTC by Ricardo Alonso
Modified: 2021-09-05 09:34 UTC (History)
8 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2021-08-19 06:22:59 UTC
oVirt Team: Storage
Embargoed:
sbonazzo: ovirt-4.4?
sshmulev: testing_plan_complete-
pm-rhel: planning_ack?
pm-rhel: devel_ack+
pm-rhel: testing_ack+


Attachments (Terms of Use)
Actual view of the table. (162.25 KB, image/png)
2020-07-02 20:13 UTC, Ricardo Alonso
no flags Details


Links
System ID Private Priority Status Summary Last Updated
oVirt gerrit 115365 0 master MERGED webadmin: Add a column for storage domain under disk view 2021-06-23 14:00:44 UTC
oVirt gerrit 115493 0 master MERGED webadmin: fix runtime exception for LUNs wrong casting 2021-07-05 12:03:57 UTC

Description Ricardo Alonso 2020-07-02 20:13:01 UTC
Created attachment 1699736 [details]
Actual view of the table.

Description of problem:
Add a column to show in which storage domain the disk is located.

Version-Release number of selected component (if applicable):
Software Version:4.4.0.3-1.el8


How reproducible:
Access Storage -> Disks. 


Actual results:
9 columns: Alias, ID, Shared, <no_name>, Attached To, Virtual Size, Status, Type, Description

Expected results:
10 columns: Alias, ID, Shared, <no_name>, Attached To, Virtual Size, Status, Type, Description, Storage Domain.

Additional info:

Comment 1 RHEL Program Management 2020-07-08 14:37:59 UTC
The documentation text flag should only be set after 'doc text' field is provided. Please provide the documentation text and set the flag to '?' again.

Comment 2 Michal Skrivanek 2020-07-22 09:29:56 UTC
let's see if it's easy

Comment 3 Bella Khizgiyaev 2021-06-28 11:12:41 UTC
The new column was added,
now under general disk view the storage domain info should be displayed.

Comment 4 Bella Khizgiyaev 2021-06-30 14:17:25 UTC
An exception was raised for LUNs when the storage domain filed was chosen:

2021-06-28 15:10:04,340+03 ERROR [org.ovirt.engine.ui.frontend.server.gwt.OvirtRemoteLoggingService] (default task-2) [] Permutation name: 794D4B14A39773A8626180040E3750DE
2021-06-28 15:10:04,341+03 ERROR [org.ovirt.engine.ui.frontend.server.gwt.OvirtRemoteLoggingService] (default task-2) [] Uncaught exception: java.lang.ClassCastException
        at java.lang.Throwable.Throwable(Throwable.java:66)
        at java.lang.Exception.Exception(Exception.java:28)
        at java.lang.RuntimeException.RuntimeException(RuntimeException.java:28)
        at java.lang.ClassCastException.ClassCastException(ClassCastException.java:26)
        at javaemul.internal.InternalPreconditions.checkCriticalType(InternalPreconditions.java:152)
        at com.google.gwt.lang.Cast.castTo(Cast.java:74)
        at org.ovirt.engine.ui.common.widget.table.column.StorageDomainsColumn.getTooltip(StorageDomainsColumn.java:37)
        at org.ovirt.engine.ui.common.widget.table.column.AbstractColumn.onBrowserEvent(AbstractColumn.java:46)
        at com.google.gwt.user.cellview.client.AbstractCellTable.$fireEventToCell(AbstractCellTable.java:2420)
        at com.google.gwt.user.cellview.client.AbstractCellTable.$onBrowserEvent2(AbstractCellTable.java:1777)
        at org.ovirt.engine.ui.common.widget.table.AbstractActionTable$1.onBrowserEvent2(AbstractActionTable.java:113)
        at com.google.gwt.user.cellview.client.AbstractHasData.onBrowserEvent(AbstractHasData.java:735)
        at com.google.gwt.user.client.DOM.dispatchEvent(DOM.java:1415)
        at com.google.gwt.user.client.impl.DOMImplStandard.dispatchEvent(DOMImplStandard.java:312)
        at com.google.gwt.core.client.impl.Impl.apply(Impl.java:306)
        at com.google.gwt.core.client.impl.Impl.entry0(Impl.java:345)
        at Unknown.wy/<(https://sleviim.redhat:8443/ovirt-engine/webadmin/?locale=en_US line 9 > scriptElement)
        at Unknown.anonymous(Unknown)

Comment 5 sshmulev 2021-07-19 13:29:03 UTC
Verified.

Seems like it is working as described, didn't see any errors (tried to see if I get errors like mentioned in comment4 but couldn't reproduce that)
In addition, also tried to add managed block storage domain, and it also worked.

Comment 6 Sandro Bonazzola 2021-08-19 06:22:59 UTC
This bugzilla is included in oVirt 4.4.8 release, published on August 19th 2021.

Since the problem described in this bug report should be resolved in oVirt 4.4.8 release, it has been closed with a resolution of CURRENT RELEASE.

If the solution does not work for you, please open a new bug report.


Note You need to log in before you can comment on or make changes to this bug.