Bug 1853650 - Review Request: perl-Graphics-ColorNamesLite-WWW - WWW color names and equivalent RGB values
Summary: Review Request: perl-Graphics-ColorNamesLite-WWW - WWW color names and equiva...
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Robert-André Mauchin 🐧
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: 1853571
TreeView+ depends on / blocked
 
Reported: 2020-07-03 13:18 UTC by Jitka Plesnikova
Modified: 2020-07-07 17:26 UTC (History)
2 users (show)

Fixed In Version: perl-Graphics-ColorNamesLite-WWW-1.14.000-1.fc33
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2020-07-07 17:26:25 UTC
Type: ---
Embargoed:
zebob.m: fedora-review+


Attachments (Terms of Use)

Description Jitka Plesnikova 2020-07-03 13:18:05 UTC
Spec URL: https://jplesnik.fedorapeople.org/perl-Graphics-ColorNamesLite-WWW/perl-Graphics-ColorNamesLite-WWW.spec
SRPM URL: https://jplesnik.fedorapeople.org/perl-Graphics-ColorNamesLite-WWW/perl-Graphics-ColorNamesLite-WWW-1.14.000-1.fc33.src.rpm

Description:
WWW color names and equivalent RGB values (lite version).

Fedora Account System Username: jplesnik

Comment 1 Robert-André Mauchin 🐧 2020-07-04 11:05:17 UTC
URL and Source addresses are Ok.
Source archive (SHA-256: 0b85aa04277a986086970a9e5f7b968c784262bbcb4a2bd9ea0792f892276f33) is original. Ok.
Summary verified from lib/Graphics/ColorNamesLite/WWW.pm. Ok.
Description verified. Ok.
License verified from README and lib/Graphics/ColorNamesLite/WWW.pm. Ok.
No XS code, noarch BuildArch is Ok.

Pod::Coverage::TrustPod, Test::Pod::Coverage, Test::Perl::Critic, and Test::Pod are not used. Ok.
AUTHOR_TESTING variable is unset before executing "make test". Ok.

$ rpmlint perl-Graphics-ColorNamesLite-WWW.spec review-perl-Graphics-ColorNamesLite-WWW/results/perl-Graphics-ColorNamesLite-WWW-1.14.000-1.fc33.noarch.rpm review-perl-Graphics-ColorNamesLite-WWW/results/perl-Graphics-ColorNamesLite-WWW-1.14.000-1.fc33.src.rpm 
2 packages and 1 specfiles checked; 0 errors, 0 warnings.

$ rpm -q -lv -p review-perl-Graphics-ColorNamesLite-WWW/results/perl-Graphics-ColorNamesLite-WWW-1.14.000-1.fc33.noarch.rpm 
drwxr-xr-x    2 root     root                        0 Jul  4 12:55 /usr/share/doc/perl-Graphics-ColorNamesLite-WWW
-rw-r--r--    1 root     root                       73 Jun 10 11:42 /usr/share/doc/perl-Graphics-ColorNamesLite-WWW/Changes
-rw-r--r--    1 root     root                     1130 Jun 10 11:42 /usr/share/doc/perl-Graphics-ColorNamesLite-WWW/README
drwxr-xr-x    2 root     root                        0 Jul  4 12:55 /usr/share/licenses/perl-Graphics-ColorNamesLite-WWW
-rw-r--r--    1 root     root                    18367 Jun 10 11:42 /usr/share/licenses/perl-Graphics-ColorNamesLite-WWW/LICENSE
-rw-r--r--    1 root     root                     1661 Jul  4 12:55 /usr/share/man/man3/Graphics::ColorNamesLite::WWW.3pm.gz
drwxr-xr-x    2 root     root                        0 Jul  4 12:55 /usr/share/perl5/vendor_perl/Graphics
drwxr-xr-x    2 root     root                        0 Jul  4 12:55 /usr/share/perl5/vendor_perl/Graphics/ColorNamesLite
-rw-r--r--    1 root     root                     6775 Jun 10 11:42 /usr/share/perl5/vendor_perl/Graphics/ColorNamesLite/WWW.pm
File layout ans permissions are Ok.

$ rpm -q --requires -p review-perl-Graphics-ColorNamesLite-WWW/results/perl-Graphics-ColorNamesLite-WWW-1.14.000-1.fc33.noarch.rpm | sort -f | uniq -c
      1 perl(:MODULE_COMPAT_5.32.0)
      1 rpmlib(CompressedFileNames) <= 3.0.4-1
      1 rpmlib(FileDigests) <= 4.6.0-1
      1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1
      1 rpmlib(PayloadIsZstd) <= 5.4.18-1
Binary requires are Ok.

$ rpm -q --provides -p review-perl-Graphics-ColorNamesLite-WWW/results/perl-Graphics-ColorNamesLite-WWW-1.14.000-1.fc33.noarch.rpm | sort -f | uniq -c
      1 perl(Graphics::ColorNamesLite::WWW) = 1.14.000
      1 perl-Graphics-ColorNamesLite-WWW = 1.14.000-1.fc33
Binary provides are Ok.


The package builds in Fedora 33 (https://koji.fedoraproject.org/koji/taskinfo?taskID=46565701). Ok.

The package is in line with Fedora and Perl packagaging guidelines.

Resolution: Package approved.

Comment 2 Jitka Plesnikova 2020-07-07 07:28:21 UTC
https://pagure.io/releng/fedora-scm-requests/issue/26874

Comment 3 Gwyn Ciesla 2020-07-07 13:17:04 UTC
(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/perl-Graphics-ColorNamesLite-WWW

Comment 4 Jitka Plesnikova 2020-07-07 17:26:25 UTC
Thank you for the review and the repository.


Note You need to log in before you can comment on or make changes to this bug.