Note: This bug is displayed in read-only format because
the product is no longer active in Red Hat Bugzilla.
RHEL Engineering is moving the tracking of its product development work on RHEL 6 through RHEL 9 to Red Hat Jira (issues.redhat.com). If you're a Red Hat customer, please continue to file support cases via the Red Hat customer portal. If you're not, please head to the "RHEL project" in Red Hat Jira and file new tickets here. Individual Bugzilla bugs in the statuses "NEW", "ASSIGNED", and "POST" are being migrated throughout September 2023. Bugs of Red Hat partners with an assigned Engineering Partner Manager (EPM) are migrated in late September as per pre-agreed dates. Bugs against components "kernel", "kernel-rt", and "kpatch" are only migrated if still in "NEW" or "ASSIGNED". If you cannot log in to RH Jira, please consult article #7032570. That failing, please send an e-mail to the RH Jira admins at rh-issues@redhat.com to troubleshoot your issue as a user management inquiry. The email creates a ServiceNow ticket with Red Hat. Individual Bugzilla bugs that are migrated will be moved to status "CLOSED", resolution "MIGRATED", and set with "MigratedToJIRA" in "Keywords". The link to the successor Jira issue will be found under "Links", have a little "two-footprint" icon next to it, and direct you to the "RHEL project" in Red Hat Jira (issue links are of type "https://issues.redhat.com/browse/RHEL-XXXX", where "X" is a digit). This same link will be available in a blue banner at the top of the page informing you that that bug has been migrated.
Description of problem:
Discard IO should be sent to the source PV (if supported) to reclaim space after successful pvmove provided "issue_discards = 1" is set in /etc/lvm/lvm.conf
Version-Release number of selected component (if applicable):
RHEL-8
lvm2
How reproducible:
Always
Steps to Reproduce:
1. do pvmove from one pv to another pv backed by thinly provisioned device like vmdk file
Actual results:
Unused space is not reclaimed on source device
Expected results:
Issue discard IO and reclaim space on device
Additional info:
Asked customer to try "blkdiscard" command on source PV to reclaim space but it seemed to remove all the data.
Reply in customer's own word:
"blkdiscard does reclaim the space, but also removes all data from the PV. This doesn't really help because if the PV gets erased then we can just remove the lun from VMware and get the space back anyway. It would of been advantageous if pvmove issued a discard, just like lvremove does when moving specific LVS and not evacuating the whole PV. My main query is what LVM commands do support issuing discards. Do LVM discards only apply to the logical volume commands, such as lvremove and lvreduce?"
Clearly the discard can be send only to 'UNUSED' devices - so if you want to discard while PV - such device should be already removed from VG (aka vgreduce vg /dev/sdaX ; blkdiscard /dev/sdaX)
If the user want to 'dicard' all teh free space in VG left after pvmove - he can try to allocate temporary LV and discard such LV - aka 'vgcreate -l100%free -n tmplv vg ; blkdiscard /dev/vg/tmplv; lvremove vg/tmplv'
Note: lvm2 team discourage to use issue_discard=1 as it makes any 'vgcfgrestore' operation mostly useless - so the explicit workaround above makes the action way more 'explicit' and usually admin is aware about consequences in this case.
I'm looking into this issue for a while - it has several problems - if we want to provide support for all modes of pvmove - it's not so easy since do in 1 commit dropping mirror and replaing it with error target.
I'm still in process of thinking how to introduce discard without breaking compatibility.
Side step around could be to collect regions and after commit submit discard - this has one drawback - if the thing fail during these steps - the operation is not repeatable since mapping are already gone. But it has clearly the lowest complexity.
Comment 8RHEL Program Management
2023-09-23 15:53:41 UTC
Issue migration from Bugzilla to Jira is in process at this time. This will be the last message in Jira copied from the Bugzilla bug.
Comment 9RHEL Program Management
2023-09-23 15:55:32 UTC
This BZ has been automatically migrated to the issues.redhat.com Red Hat Issue Tracker. All future work related to this report will be managed there.
Due to differences in account names between systems, some fields were not replicated. Be sure to add yourself to Jira issue's "Watchers" field to continue receiving updates and add others to the "Need Info From" field to continue requesting information.
To find the migrated issue, look in the "Links" section for a direct link to the new issue location. The issue key will have an icon of 2 footprints next to it, and begin with "RHEL-" followed by an integer. You can also find this issue by visiting https://issues.redhat.com/issues/?jql= and searching the "Bugzilla Bug" field for this BZ's number, e.g. a search like:
"Bugzilla Bug" = 1234567
In the event you have trouble locating or viewing this issue, you can file an issue by sending mail to rh-issues. You can also visit https://access.redhat.com/articles/7032570 for general account information.