Red Hat Bugzilla – Bug 185370
Review Request: gtklp - A GTK frontend to CUPS
Last modified: 2007-11-30 17:11:27 EST
GtkLP for CUPS is a frontend for the lpr that comes with CUPS. It is
written to make it easy to use nearly all the options from CUPS
without knowing them by name. For print-admins, there is also an
pretty simple queue tool implemented.
/usr/bin/ld: cannot find -lgnutls
collect2: ld returned 1 exit status
make: *** [gtklp] Error 1
Added buildreq gnutls-devel. Now builds fine.
Package at: http://math.ifi.unizh.ch/fedora/5/i386/SRPMS.gemi/gtklp-1.2.1-2.src.rpm
- rpmlint checks return:
W: gtklp incoherent-version-in-changelog 1.2.1-1 1.2.1-2
Minor, release just doesn't match
E: gtklp incorrect-locale-subdir /usr/share/locale/chs/LC_MESSAGES/gtklp.mo
E: gtklp incorrect-locale-cs /usr/share/locale/cz/LC_MESSAGES/gtklp.mo
E: gtklp incorrect-locale-subdir /usr/share/locale/cht/LC_MESSAGES/gtklp.mo
- package meets naming guidelines
- package meets packaging guidelines
- license (GPL) OK, text in %doc, matches source
- spec file legible, in am. english
- source matches upstream
- package compiles on FC5 (x86_64)
- no missing BR
- no unnecessary BR
- locales handled properly
- not relocatable
- owns all directories that it creates
- no duplicate files
- permissions ok
- %clean ok
- macro use consistent
- code, not content
- no need for -docs
- nothing in %doc affects runtime
- .desktop files
It'd be a good idea to inform the author when this goes through so they can add
it to their distribution list.
Couple of quick items:
1. Duplicate BuildRequires: openssl-devel (provided by cups-devel)
2. Requires for cups shouldn't be needed, since the devel packages soname should
pull this in.
(In reply to comment #3)
> E: gtklp incorrect-locale-cs /usr/share/locale/cz/LC_MESSAGES/gtklp.mo
This should be in facte cs instead of cz.
> E: gtklp incorrect-locale-subdir /usr/share/locale/chs/LC_MESSAGES/gtklp.mo
> E: gtklp incorrect-locale-subdir /usr/share/locale/cht/LC_MESSAGES/gtklp.mo
These seem to be Chinese locales.
I suggest removing these three, and notifying upstream about it.
(In reply to comment #4)
> Couple of quick items:
> 1. Duplicate BuildRequires: openssl-devel (provided by cups-devel)
> 2. Requires for cups shouldn't be needed, since the devel packages soname should
> pull this in.
This only pulls the cups libraries in. However gtklp doesn't make sense
without the printing system itself.
Is this still APPROVED, and should I go ahead with modifications
(In reply to comment #6)
> Is this still APPROVED, and should I go ahead with modifications
> I suggested?
Still approved. Go ahead with the locale fix, you can get further review before
on it before building if you wish.
Built on FC-4, FC-5 and FC-6.
Added entry to owners.list.
Thanks for the review!