Bug 1853729 - [RHOSP 16] Backport puppet-tripleo for Dell EMC SC Cinder Driver
Summary: [RHOSP 16] Backport puppet-tripleo for Dell EMC SC Cinder Driver
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: Red Hat OpenStack
Classification: Red Hat
Component: puppet-tripleo
Version: 16.0 (Train)
Hardware: Unspecified
OS: Unspecified
medium
medium
Target Milestone: z2
: 16.1 (Train on RHEL 8.2)
Assignee: Pablo Caruana
QA Contact: David Rosenfeld
URL:
Whiteboard:
Depends On:
Blocks: 1595325 1715964 1852087
TreeView+ depends on / blocked
 
Reported: 2020-07-03 17:21 UTC by Pablo Caruana
Modified: 2020-11-30 17:20 UTC (History)
20 users (show)

Fixed In Version: puppet-tripleo-11.5.0-0.20200616033427.8ff1c6a.el8ost
Doc Type: Release Note
Doc Text:
Added puppet-tripleo for Dell EMC SC volume driver config support both iSCSI and FC drivers. Supports deploying multiple instances of the cinder::backend::dellemc_sc backend (e.g. one iscsi + one fc, multiple iscsi, etc.).
Clone Of: 1852087
Environment:
Last Closed: 2020-11-05 09:19:47 UTC
Target Upstream Version:
Embargoed:
arkady_kanevsky: needinfo-


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
OpenStack gerrit 727451 0 None MERGED Support for Dell EMC SC Volume Config 2020-12-07 09:31:05 UTC
OpenStack gerrit 746204 0 None MERGED Fixing incorrect parameter names in Dell EMC Storage Templates 2020-12-07 09:31:03 UTC

Description Pablo Caruana 2020-07-03 17:21:30 UTC
+++ This bug was initially created as a clone of Bug #1852087 +++

Description of problem:
[RHOSP 16] Backport tripleo deployment templates for Dell EMC SC Cinder Driver

puppet-tripleo - https://review.opendev.org/#/c/727451/

Version-Release number of selected component (if applicable):


How reproducible:


Steps to Reproduce:
1.
2.
3.

Actual results:


Expected results:


Additional info:

Comment 2 arkady kanevsky 2020-11-03 21:57:58 UTC
Should be retargeted to z3 since it missed z2?

Comment 3 Luigi Toscano 2020-11-04 14:06:35 UTC
This is tricky.
The already released (OSP 16.1.2) puppet-tripleo-11.5.0-1.20200914161840.f716ef5.el8ost contains the backport patch (https://review.opendev.org/727451), which only affects the dellemc_sc driver.

But the other patch which is totally unrelated to this, https://review.opendev.org/746204, it hasn't been backported. That patch also affects several drivers. Please don't mix a feature bug with a bug fix, especially after that a bug moved to MODIFIED state, and without any comment explaining the addition. Please create a new bug for that fix, if it's important. I'm going to close this RFE because the main backport happened.

Comment 5 Luigi Toscano 2020-11-04 14:24:19 UTC
After rechecking, it seems the relevant part of https://review.opendev.org/746204 is available in the packages too.

But that patch should be at least partially backported upstream, at least all the code that applies to train (and probably ussuri).

Comment 6 arkady kanevsky 2020-11-30 16:42:50 UTC
Luigi backported these already.
https://review.opendev.org/c/openstack/puppet-tripleo/+/762665 merged for Ussuri.
https://review.opendev.org/c/openstack/puppet-tripleo/+/762803 has all +2 but is having gate problems.

If it is in z2 already we are good.

Comment 7 Luigi Toscano 2020-11-30 17:20:08 UTC
(In reply to arkady kanevsky from comment #6)
> Luigi backported these already.
> https://review.opendev.org/c/openstack/puppet-tripleo/+/762665 merged for
> Ussuri.
> https://review.opendev.org/c/openstack/puppet-tripleo/+/762803 has all +2
> but is having gate problems.
> 
> If it is in z2 already we are good.

The patch is in z2 already, but as a product-specific backport.
The upstream backport only cover part of the changes (not all of them are upstream), but at least it should reduce the delta to a minimal level, and it also fix the parameters of the upstream OpenStack users.

For future patches I'd suggest patches should be backported as soon as possible, maybe submitting different patches for the changes that can be backported and the ones which can't, so the latter can be easily cherry-picked.


Note You need to log in before you can comment on or make changes to this bug.