Bug 1853859 - vSphere IPI - Need validation on IP inputs
Summary: vSphere IPI - Need validation on IP inputs
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: OpenShift Container Platform
Classification: Red Hat
Component: Installer
Version: 4.5
Hardware: Unspecified
OS: Unspecified
medium
medium
Target Milestone: ---
: 4.6.0
Assignee: aos-install
QA Contact: jima
URL:
Whiteboard:
Depends On:
Blocks: 1855844
TreeView+ depends on / blocked
 
Reported: 2020-07-04 20:55 UTC by Robert Bost
Modified: 2020-10-27 16:12 UTC (History)
3 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Before this fix, the user would be able to set the same IP to the ingress and the API. This would cause the bootstrap and one of the master machines to have the same IP. Adding validation to check if the IPs are the same to avoid this problem.
Clone Of:
Environment:
Last Closed: 2020-10-27 16:12:20 UTC
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Github openshift installer pull 3862 0 None closed Bug 1853859: Add validations for IP inputs 2021-01-20 08:18:49 UTC
Red Hat Knowledge Base (Solution) 5226151 0 None None None 2020-07-15 18:22:02 UTC
Red Hat Product Errata RHBA-2020:4196 0 None None None 2020-10-27 16:12:53 UTC

Comment 1 Robert Bost 2020-07-04 20:57:56 UTC
I'm able to enter the same IP Address for both API and Ingress prompts. Of course, this is user error but some validation on this would be helpful in the event of a mistake. Creating a cluster with these settings results in Bootstrap and one of the masters being assigned the same IP address during installation. 

$ ./openshift-install create cluster 
...
? Virtual IP Address for API 10.50.0.10
? Virtual IP Address for Ingress 10.50.0.10

Comment 2 jima 2020-07-06 06:00:39 UTC
checked on nightly build 4.5.0-0.nightly-2020-07-02-190154
when launching "./openshift-install create cluster", and input same IP on both apiVIP and ingressVIP, it is indeed no such checking and installation is on-going, since bootstrap server and one master node hold same VIP, installation is failed when waiting for bootstrapping complete

Test again with same build, and input correct apiVIP and ingressVIP(two different IPs), and installation is successful.

Comment 3 Brenton Leanhardt 2020-07-06 15:45:00 UTC
We should definitely address this.  This shouldn't be a GA blocker though.

Comment 4 Patrick Dillon 2020-07-10 14:03:58 UTC
This is under active code review, but possibly will not merge today so we are adding UpcomingSprint.

Comment 7 Aditya Narayanaswamy 2020-07-10 17:10:26 UTC
PR got merged so removing UpcomingSprint.

Comment 8 jima 2020-08-04 01:39:39 UTC
Verified on nightly build: 4.6.0-0.nightly-2020-08-03-225825, and passed.

# ./openshift-install create cluster --dir ./install
? SSH Public Key /root/.ssh/openshift-qe.pub
? Platform vsphere
? vCenter xxxxxx
? Username xxxxx
? Password [? for help] ************
INFO Connecting to xxxxxxx 
INFO Defaulting to only available datacenter: dc1 
INFO Defaulting to only available cluster: devel  
? Default Datastore nvme-ds1
INFO Defaulting to only available network: VM Network 
? Virtual IP Address for API 192.168.2.2
X Sorry, your reply was invalid: "192.168.2.2" should not be equal to the Virtual IP address for the API
? Virtual IP Address for Ingress [? for help]

Comment 11 errata-xmlrpc 2020-10-27 16:12:20 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (OpenShift Container Platform 4.6 GA Images), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2020:4196


Note You need to log in before you can comment on or make changes to this bug.