Bug 1854225 - Icons on buttons in FreeIPA web UI are broken (just empty boxes) with new fontawesome-fonts
Summary: Icons on buttons in FreeIPA web UI are broken (just empty boxes) with new fon...
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: fontawesome-fonts
Version: rawhide
Hardware: All
OS: Linux
unspecified
medium
Target Milestone: ---
Assignee: Fabio Alessandro Locati
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard: openqa
Depends On:
Blocks: F33BetaBlocker
TreeView+ depends on / blocked
 
Reported: 2020-07-06 19:36 UTC by Adam Williamson
Modified: 2020-07-11 01:49 UTC (History)
15 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2020-07-11 01:49:20 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)
before: how the Users page looked in Fedora-Rawhide-20200704.n.1 (note icons on buttons) (78.02 KB, image/png)
2020-07-06 19:39 UTC, Adam Williamson
no flags Details
after: how the Users page looks in Fedora-Rawhide-20200706.n.0 (note broken icons on buttons) (63.30 KB, image/png)
2020-07-06 19:39 UTC, Adam Williamson
no flags Details

Description Adam Williamson 2020-07-06 19:36:50 UTC
In today's Rawhide (Fedora-Rawhide-20200706.n.0) we got a new fontawesome-fonts build, 5.13.1-1.fc33 (previous build was 4.7.0-8.fc32). It seems this broke some or all of the icons on buttons in the FreeIPA web UI. They're just empty boxes now. I'm attaching 'before' and 'after' screenshots for reference.

This broke the openQA tests because some of the needles match on the buttons with icons, I'll add workaround needles for the broken buttons and rerun the tests.

Comment 1 Adam Williamson 2020-07-06 19:39:17 UTC
Created attachment 1700070 [details]
before: how the Users page looked in Fedora-Rawhide-20200704.n.1 (note icons on buttons)

Comment 2 Adam Williamson 2020-07-06 19:39:49 UTC
Created attachment 1700071 [details]
after: how the Users page looks in Fedora-Rawhide-20200706.n.0 (note broken icons on buttons)

Comment 3 Adam Williamson 2020-07-06 19:40:26 UTC
CCing fontawesome packager.

Comment 4 Adam Williamson 2020-07-06 20:16:31 UTC
OK, it's not just these button icons, but tons of UI elements like radio buttons and checkboxes. Raising severity to medium as it actually makes the web UI look pretty bad and even hard to navigate since you can't tell what some UI elements are.

Comment 5 Alexander Bokovoy 2020-07-07 06:16:09 UTC
So, according to https://fontawesome.com/how-to-use/on-the-web/setup/upgrading-from-version-4, there are many changes between version 4 and version 5 to the point that straight replacement of v4 by v5 is not possible, the code has to be adopted in all projects that used v4.

I'd suggest we get v4 package back. It would probably be better to have v5 as a different package too. More to that, fontawesome.com talks about upcoming v6 that would be yet more different to previous versions. This means we really need keep parallel availability of these versions if we don't want to break anything already working.

Upgrade like this is a system-wide change in Fedora and should be done with care.

Comment 6 Adam Williamson 2020-07-07 15:16:23 UTC
since 5 has been in a compose we can't untag it, so we can only go back to v4 in the plain 'fontawesome-fonts' package with an epoch bump (which we can totally do, of course, just noting it).

Comment 7 Fabio Alessandro Locati 2020-07-07 15:20:26 UTC
Thanks for CCing me!

We are tracking the situation in #1854348

Comment 8 Alexander Bokovoy 2020-07-08 04:56:59 UTC
Fabio,

I think the bug 1854348 misses the point I am making in this bug. Fontawesome-5 is incompatible with fontawesome-4 and cannot be served as a replacement without changes in the projects that use it. This means that the current update is wrong and needs to be reverted.

What is more important, we also need to keep fontawesome-4 in Fedora until we get the projects using it migrated to a new version. This is system-wide change for Fedora and cannot be done just by bumping fontawesome package to version 5.

I consider this a blocker for Fedora 33 and is something that you'd need to solve.

Comment 9 Fedora Blocker Bugs Application 2020-07-08 05:00:31 UTC
Proposed as a Blocker for 33-beta by Fedora user abbra using the blocker tracking app because:

 Fontawesome 5 is incompatible with applications using Fontawesome 4. Rawhide was updated to fontawesome 5 which broke FreeIPA Web UI and other applications.
An upgrade of fontawesome is a system-wide change that was not announced. We need to keep fontawesome 4 for few releases until projects relying on it migrate to newer versions. This means also that the current fontawesome 5 package version needs to be packaged separately and update rolled back.

Comment 10 Fabio Alessandro Locati 2020-07-08 07:50:21 UTC
The effects of the update have been far greater than my expectation.
I've epoched and rollback the package that is now back at 4.7.0-8.
The update should be in the next comp.
I will work on a more sustainable update proposal/update path following the system-wide change process.
Thanks a lot for your suggestions on how this change can happen in a way that is sustainable for dependent packages.

Comment 11 Fedora Update System 2020-07-08 07:53:31 UTC
FEDORA-2020-c5957bcd91 has been submitted as an update to Fedora 33. https://bodhi.fedoraproject.org/updates/FEDORA-2020-c5957bcd91

Comment 12 Adam Williamson 2020-07-11 01:49:20 UTC
confirmed fixed for Rawhide in latest compose. Thanks.


Note You need to log in before you can comment on or make changes to this bug.