Bug 1855042 - Review Request: librhsm - Red Hat Subscription Manager Library
Summary: Review Request: librhsm - Red Hat Subscription Manager Library
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Neal Gompa
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2020-07-08 18:12 UTC by Stephen Gallagher
Modified: 2020-07-08 19:25 UTC (History)
2 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2020-07-08 19:25:48 UTC
Type: ---
Embargoed:
ngompa13: fedora-review+

Attachments (Terms of Use)

Description Stephen Gallagher 2020-07-08 18:12:42 UTC 
Spec URL: https://sgallagh.fedorapeople.org/packagereview/librhsm/librhsm.spec
SRPM URL: https://sgallagh.fedorapeople.org/packagereview/librhsm/librhsm-0.0.3-1.fc32.src.rpm
Description: Red Hat Subscription Manager Library
Fedora Account System Username: sgallagh
Comment 1 Neal Gompa 2020-07-08 18:28:08 UTC 
Taking this review.
Comment 2 Neal Gompa 2020-07-08 18:31:51 UTC 
> %global libname rhsm
>
> Name:           lib%{libname}
> [...]
> %{_includedir}/%{libname}/

The %libname macro doesn't seem very useful. I'd suggest that you eliminate the macro and just replace that with the name itself.
Comment 3 Neal Gompa 2020-07-08 18:34:33 UTC 
Review notes:

* Conforms to Fedora Packaging Guidelines
* Builds and installs cleanly
* No major issues from rpmlint
* License is correctly identified and license file is installed properly

PACKAGE APPROVED.
Comment 4 Gwyn Ciesla 2020-07-08 19:01:06 UTC 
(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/librhsm
Comment 5 Stephen Gallagher 2020-07-08 19:25:48 UTC 
I dropped the %libname macro when importing it.
Note You need to log in before you can comment on or make changes to this bug.