Bug 1855219 - Review Request: perl-Test2-Plugin-Cover - Collect a minimal file coverage data
Summary: Review Request: perl-Test2-Plugin-Cover - Collect a minimal file coverage data
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Jitka Plesnikova
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: 1855162
TreeView+ depends on / blocked
 
Reported: 2020-07-09 09:29 UTC by Petr Pisar
Modified: 2020-07-10 13:36 UTC (History)
2 users (show)

Fixed In Version: perl-Test2-Plugin-Cover-0.0.7-1.fc33
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2020-07-10 13:36:27 UTC
Type: ---
Embargoed:
jplesnik: fedora-review+


Attachments (Terms of Use)

Description Petr Pisar 2020-07-09 09:29:31 UTC
Spec URL: https://ppisar.fedorapeople.org/perl-Test2-Plugin-Cover/perl-Test2-Plugin-Cover.spec
SRPM URL: https://ppisar.fedorapeople.org/perl-Test2-Plugin-Cover/perl-Test2-Plugin-Cover-0.0.7-1.fc33.src.rpm
Description:
This Test2 plugin will collect minimal file coverage data, and will do so with
minimal performance impact.

Fedora Account System Username: ppisar

Comment 1 Jitka Plesnikova 2020-07-10 06:47:29 UTC
Source file is ok
Summary is ok
License is ok
Description is ok
URL and Source0 are ok
All tests passed
BuildRequires are ok

$ rpm -qp --requires perl-Test2-Plugin-Cover-0.0.7-1.fc33.x86_64.rpm | sort | uniq -c | grep -v rpmlib
      1 libc.so.6()(64bit)
      1 libc.so.6(GLIBC_2.2.5)(64bit)
      1 libperl.so.5.32()(64bit)
      1 libpthread.so.0()(64bit)
      1 libpthread.so.0(GLIBC_2.2.5)(64bit)
      1 perl(Carp)
      1 perl(File::Spec)
      1 perl(:MODULE_COMPAT_5.32.0)
      1 perl(Path::Tiny) >= 0.048
      1 perl(strict)
      1 perl(Test2::API) >= 1.302166
      1 perl(Test2::EventFacet) >= 1.302166
      1 perl(Test2::Util::HashBase)
      1 perl(warnings)
      1 perl(XSLoader)
      1 rtld(GNU_HASH)
Binary requires are Ok.

$ rpm -qp --provides perl-Test2-Plugin-Cover-0.0.7-1.fc33.x86_64.rpm | sort | uniq -c
      1 perl(Test2::EventFacet::Coverage) = 0.000007
      1 perl(Test2::Plugin::Cover) = 0.000007
      1 perl-Test2-Plugin-Cover = 0.0.7-1.fc33
      1 perl-Test2-Plugin-Cover(x86-64) = 0.0.7-1.fc33
Binary provides are Ok.

$ rpmlint ./perl-Test2-Plugin-Cover*
2 packages and 1 specfiles checked; 0 errors, 0 warnings.
Rpmlint is ok

The package looks good.

Resolution:
Approved

Comment 3 Gwyn Ciesla 2020-07-10 13:10:37 UTC
(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/perl-Test2-Plugin-Cover

Comment 4 Petr Pisar 2020-07-10 13:36:27 UTC
Thank you for the review and the repository.


Note You need to log in before you can comment on or make changes to this bug.