Bug 1856891 - Review Request: badchars - HEX bad char generator for different programming languages
Summary: Review Request: badchars - HEX bad char generator for different programming l...
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Robert-André Mauchin 🐧
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: FE-SECLAB
TreeView+ depends on / blocked
 
Reported: 2020-07-14 16:02 UTC by Fabian Affolter
Modified: 2020-08-22 19:10 UTC (History)
2 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2020-08-22 19:10:31 UTC
Type: ---
Embargoed:
zebob.m: fedora-review+


Attachments (Terms of Use)

Description Fabian Affolter 2020-07-14 16:02:53 UTC
Spec URL: https://fab.fedorapeople.org/packages/SRPMS/badchars.spec
SRPM URL: https://fab.fedorapeople.org/packages/SRPMS/badchars-0.4.0-1.fc31.src.rpm

Project URL: https://github.com/cytopia/badchars

Description:
A HEX bad char generator to instruct encoders such as shikata-ga-nai to
transform those to other chars.

Koji scratch build:
https://koji.fedoraproject.org/koji/taskinfo?taskID=47205943

rpmlint output:
$ rpmlint badchars-0.4.0-1.fc31.src.rpm
badchars.src: W: spelling-error %description -l en_US shikata -> shiatsu
badchars.src: W: spelling-error %description -l en_US ga -> GA, Ga, fa
badchars.src: W: spelling-error %description -l en_US nai -> nail, naif, nae
1 packages and 0 specfiles checked; 0 errors, 3 warnings.

$ rpmlint badchars-0.4.0-1.fc31.noarch.rpm 
badchars.noarch: W: spelling-error %description -l en_US shikata -> shiatsu
badchars.noarch: W: spelling-error %description -l en_US ga -> GA, Ga, fa
badchars.noarch: W: spelling-error %description -l en_US nai -> nail, naif, nae
badchars.noarch: W: no-documentation
badchars.noarch: W: no-manual-page-for-binary badchars
1 packages and 0 specfiles checked; 0 errors, 5 warnings.

Fedora Account System Username: fab

Comment 1 Robert-André Mauchin 🐧 2020-07-14 16:50:32 UTC
 - Should not be needed:

Requires:       python3dist(argparse)


Package approved, please fix the aforementioned issue before import.


Package Review
==============

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed


Issues:
=======
- Package installs properly.
  Note: Installation errors (see attachment)
  See: https://docs.fedoraproject.org/en-US/packaging-guidelines/


===== MUST items =====

Generic:
[x]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
     Guidelines.
[x]: License field in the package spec file matches the actual license.
     Note: Checking patched sources after %prep for licenses. Licenses
     found: "Expat License", "Unknown or generated". 6 files have unknown
     license. Detailed output of licensecheck in
     /home/bob/packaging/review/badchars/review-badchars/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
     names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
     Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
     (~1MB) or number of files.
     Note: Documentation size is 20480 bytes in 1 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
     one supported primary architecture.
[x]: Rpmlint is run on all rpms the build produces.
     Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
     license(s) in its own file, then that file, containing the text of the
     license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
     work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
     provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
     %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

===== SHOULD items =====

Generic:
[-]: If the source package does not include license text(s) as a separate
     file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[-]: Fully versioned dependency in subpackages if applicable.
     Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in
     python3-badchars
[?]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[-]: Sources are verified with gpgverify first in %prep if upstream
     publishes signatures.
     Note: gpgverify is not used.
[-]: Description and summary sections in the package spec file contains
     translations for supported Non-English languages, if available.
[x]: Package should compile and build into binary rpms on all supported
     architectures.
[-]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed
     files.
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
     $RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define unless justified.

===== EXTRA items =====

Generic:
[x]: Rpmlint is run on all installed packages.
[x]: Spec file according to URL is the same as in SRPM.



Rpmlint
-------
Checking: badchars-0.4.0-1.fc33.noarch.rpm
          python3-badchars-0.4.0-1.fc33.noarch.rpm
          badchars-0.4.0-1.fc33.src.rpm
badchars.noarch: W: spelling-error %description -l en_US shikata -> shiatsu
badchars.noarch: W: spelling-error %description -l en_US ga -> GA, Ga, fa
badchars.noarch: W: spelling-error %description -l en_US nai -> nail, naif, nae
badchars.noarch: W: no-documentation
badchars.noarch: W: no-manual-page-for-binary badchars
python3-badchars.noarch: W: spelling-error %description -l en_US shikata -> shiatsu
python3-badchars.noarch: W: spelling-error %description -l en_US ga -> GA, Ga, fa
python3-badchars.noarch: W: spelling-error %description -l en_US nai -> nail, naif, nae
badchars.src: W: spelling-error %description -l en_US shikata -> shiatsu
badchars.src: W: spelling-error %description -l en_US ga -> GA, Ga, fa
badchars.src: W: spelling-error %description -l en_US nai -> nail, naif, nae
3 packages and 0 specfiles checked; 0 errors, 11 warnings.

Comment 2 Fabian Affolter 2020-07-14 17:05:09 UTC
Thanks for the review.

(In reply to Robert-André Mauchin 🐧 from comment #1)
>  - Should not be needed:
> 
> Requires:       python3dist(argparse)

Removed.

Comment 3 Gwyn Ciesla 2020-07-14 17:10:20 UTC
(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/badchars


Note You need to log in before you can comment on or make changes to this bug.