Bug 1857477 - Bad helptext for storagecluster creation
Summary: Bad helptext for storagecluster creation
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: OpenShift Container Platform
Classification: Red Hat
Component: Console Storage Plugin
Version: 4.4
Hardware: Unspecified
OS: Unspecified
medium
low
Target Milestone: ---
: 4.8.0
Assignee: Ankush Behl
QA Contact: Elena Bondarenko
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2020-07-15 23:32 UTC by Kyle Bader
Modified: 2021-07-27 22:32 UTC (History)
10 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2021-07-27 22:32:27 UTC
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Github openshift console pull 8237 0 None open Bug 1857477: Updates helptext for storage cluster creation 2021-02-24 14:19:29 UTC
Red Hat Product Errata RHSA-2021:2438 0 None None None 2021-07-27 22:32:43 UTC

Description Kyle Bader 2020-07-15 23:32:48 UTC
Description of problem:

"3 selected nodes are used for initial deployment. The remaining selected nodes will be used by OpenShift as scheduling targets for OCS scaling."

This is not how it works, the pods created during StorageCluster initialization can be scheduled on any node that matches the nodeSelector, or any nodes that had the OCS label added to them before getting to the console.


Version-Release number of selected component (if applicable):

OCP 4.4.1
OCS 4.4

Comment 1 Neha Gupta 2020-08-06 06:01:12 UTC
@kbader UI labels the selected nodes with ocs label and hence the pods created during StorageCluster initialization can be scheduled on it, if this is what you are asking.
I didn't quite understand the issue. Can you please explain a bit more?

Comment 2 Kyle Bader 2020-09-14 18:38:01 UTC
The issue is the wording of the help text

"3 selected nodes are used for initial deployment."

It's a *minimum* of 3 nodes, but > 3 can be selected, and *all* selected nodes will be valid scheduling targets (versus only 3).


"The remaining selected nodes will be used by OpenShift as scheduling targets for OCS scaling."

All nodes that are selected are potentially valid scheduling targets for components, so they wouldn't be used *only* for scaling.

Comment 3 Neha Gupta 2020-10-08 08:50:51 UTC
@smordech @ygalanti Please update the text.

Comment 4 Yuval 2020-11-26 12:59:29 UTC
this text has been updated as part of the work we did around the storage cluster creation wizard. 
https://marvelapp.com/prototype/12i47i8j/screen/73122992

Comment 5 Nishanth Thomas 2020-12-01 05:37:09 UTC
(In reply to Yuval from comment #4)
> this text has been updated as part of the work we did around the storage
> cluster creation wizard. 
> https://marvelapp.com/prototype/12i47i8j/screen/73122992

Moving to ON_QA based on this.

Comment 12 Kyle Bader 2021-01-21 19:17:19 UTC
"Selected nodes will have labels added to them that make them targets for OCS components"

Comment 13 Vineet 2021-01-27 08:56:15 UTC
Select at least 3 nodes preferably in 3 different zones. It is recommended to start with at least 14 CPUs and 34 GiB per node.

The selected nodes will be labeled with 
cluster.ocs.openshift.io/openshift-storage=""
 (unless they are already labeled). Selected nodes will have labels added to them that make them targets for OCS components

@kbader @ygalanti is this statement what we're looking for ? Please confirm

Comment 15 Nishanth Thomas 2021-02-13 09:34:31 UTC
Setting target release to the active development branch (4.8.0). For any fixes, where required , cloned BZs will be created for those release maintenance streams.

Comment 16 Nishanth Thomas 2021-02-13 09:35:59 UTC
@kbader , do you agree with https://bugzilla.redhat.com/show_bug.cgi?id=1857477#c14 ?

Comment 18 Kyle Bader 2021-02-24 15:52:24 UTC
This text works for me:

“The selected nodes will be labeled with 
cluster.ocs.openshift.io/openshift-storage=""
 (unless they are already labeled). Selected nodes will have labels added to them that make them targets for OCS components”

That said, if we wanted to make it shorter / more concise:

“Selected nodes will be labeled in a way that makes them viable hosts for OCS components.”

Comment 28 errata-xmlrpc 2021-07-27 22:32:27 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (Moderate: OpenShift Container Platform 4.8.2 bug fix and security update), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHSA-2021:2438


Note You need to log in before you can comment on or make changes to this bug.