Spec URL: https://jskarvad.fedorapeople.org/libgnt/libgnt.spec SRPM URL: https://jskarvad.fedorapeople.org/libgnt/libgnt-2.14.0-1.fc31.src.rpm Description: GNT is an ncurses toolkit for creating text-mode graphical user interfaces in a fast and easy way. It is based on GLib and ncurses. Fedora Account System Username: jskarvad
First of all, I were able to download source tarball from URL [1]. Obtained it after some clicking in pidgin releases. It does not provide proper name for file, but can be hacked. It is not a nice URL, but working anyway. # This works. Source0: https://bintray.com/pidgin/releases/download_file?file_path=%{name}-%{version}.tar.xz#/%{name}-%{version}.tar.xz Source1: https://bintray.com/pidgin/releases/download_file?file_path=%{name}-%{version}.tar.xz.asc#/%{name}-%{version}.tar.xz.asc 1. https://bintray.com/pidgin/releases/download_file?file_path=libgnt-2.14.0.tar.xz
It might pack gtk-doc subdirectory into separate -doc package. It has megabyte in size, where library on x86_64 is 312K large. Other than that, only signature verification is missing. Good job! Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed ===== MUST items ===== C/C++: [x]: Package does not contain kernel modules. [x]: Package contains no static executables. [x]: Development (unversioned) .so files in -devel subpackage, if present. Note: Unversioned so-files in private %_libdir subdirectory (see attachment). Verify they are not in ld path. [x]: If your application is a C or C++ application you must list a BuildRequires against gcc, gcc-c++ or clang. [x]: Header files in -devel subpackage, if present. [x]: ldconfig not called in %post and %postun for Fedora 28 and later. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "GNU Lesser General Public License", "Unknown or generated", "GPL (v2 or later)". 25 files have unknown license. Detailed output of licensecheck in /home/reviewer/fedora/rawhide/1857785-libgnt/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [x]: Package does not own files or directories owned by other packages. Note: Dirs in package are owned also by: /usr/lib64/gnt(finch), /usr/include/gnt(finch-devel), /usr/share/gtk-doc(gegl04-devel-docs, p11-kit-devel, libgweather-devel, libpeas-devel, glade-devel, flatpak- devel, gssdp-docs, nautilus-python-devel, unique-devel, gocl-devel, ORBit2-devel, fprintd-devel, gtkspell3-devel, vips-devel, libdbusmenu- doc, upower-devel-docs, garcon-devel, gtk-doc, libgnome-keyring-devel, geocode-glib-devel, tepl-devel, libzapojit-devel, gtk3-devel-docs, playerctl-docs, polkit-docs, vte291-devel, redland-devel, gmime30-devel, libinsane-gobject-devel, libhandy1-devel, harfbuzz- devel, tomoe-devel, libmodulemd1-devel, libcloudproviders-devel, cheese-libs-devel, libcryptui-devel, goocanvas2-devel, anaconda- widgets-devel, gnome-todo-devel, buildstream-docs, clutter-doc, rasqal-devel, cutter-devel, gimp-devel, gsequencer-devel-doc, raptor2-devel, libwnck-devel, clutter-gst3-devel, librsvg2-devel, libldm-devel, colord-gtk-devel, libgxps-devel, nautilus-devel, libgda- devel, gsound-devel, libjcat-devel, xed-doc, libxklavier-devel, geoclue2-devel, gtk2-devel-docs, webkit2gtk3-doc, libxfce4util-devel, libsoup-devel, gnome-desktop3-devel, eog-devel, gnome-latex-doc, libdazzle-devel, yelp-devel, bamf-devel, libsecret-devel, libgexiv2-devel, gnome-online-accounts-devel, tracker-doc, gcr-devel, libidn2-devel, libcanberra-devel, gspell-doc, maliit-framework-docs, template-glib-devel, libgit2-glib-devel, libxml2-devel, libgdata- devel, ibus-devel-docs, udisks-devel, gnome-autoar-devel, libgtop2-devel, libu2f-host-devel, libunity-gtk-parser-devel, tumbler- devel, gst-devtools-devel, libnma-devel, libxfce4ui-devel, clipsmm- doc, gtranslator, libchamplain-devel, anjuta-devel, dconf-devel, switcheroo-control-docs, gnome-panel-devel, libhandy-devel, gnome- desktop-devel, gtkimageview-devel, libwnck3-devel, libmodulemd-devel, libgpod-doc, libxmlb-devel, low-memory-monitor-doc, gtksourceview4-devel, libgdl-devel, gnome-bluetooth-libs-devel, parole-devel, amtk-devel, libgnome-devel, iio-sensor-proxy-docs, gobject-introspection-devel, gom-devel, lasem-devel, dbus-doc, unique3-docs, exo-devel, gedit-devel, gfbgraph-devel, json-glib-devel, jsonrpc-glib-devel, xfconf-devel, libfm-devel-docs, gupnp-docs, poppler-glib-doc, graphene-devel), /usr/share/gtk- doc/html(gegl04-devel-docs, p11-kit-devel, libgweather-devel, libpeas- devel, glade-devel, flatpak-devel, gssdp-docs, nautilus-python-devel, unique-devel, gocl-devel, ORBit2-devel, fprintd-devel, gtkspell3-devel, vips-devel, libdbusmenu-doc, garcon-devel, libgnome- keyring-devel, geocode-glib-devel, tepl-devel, libzapojit-devel, gtk3-devel-docs, playerctl-docs, polkit-docs, vte291-devel, redland- devel, gmime30-devel, libinsane-gobject-devel, libhandy1-devel, harfbuzz-devel, tomoe-devel, libmodulemd1-devel, libcloudproviders- devel, cheese-libs-devel, libcryptui-devel, goocanvas2-devel, anaconda-widgets-devel, gnome-todo-devel, buildstream-docs, clutter- doc, rasqal-devel, cutter-devel, gimp-devel, gsequencer-devel-doc, raptor2-devel, libwnck-devel, clutter-gst3-devel, librsvg2-devel, libldm-devel, colord-gtk-devel, libgxps-devel, nautilus-devel, libgda- devel, gsound-devel, libjcat-devel, xed-doc, libxklavier-devel, geoclue2-devel, gtk2-devel-docs, webkit2gtk3-doc, libxfce4util-devel, libsoup-devel, gnome-desktop3-devel, eog-devel, gnome-latex-doc, libdazzle-devel, yelp-devel, bamf-devel, libsecret-devel, libgexiv2-devel, gnome-online-accounts-devel, tracker-doc, gcr-devel, libidn2-devel, libcanberra-devel, gspell-doc, maliit-framework-docs, template-glib-devel, libgit2-glib-devel, libxml2-devel, libgdata- devel, ibus-devel-docs, udisks-devel, gnome-autoar-devel, libgtop2-devel, libu2f-host-devel, libunity-gtk-parser-devel, tumbler- devel, gst-devtools-devel, libnma-devel, libxfce4ui-devel, clipsmm- doc, gtranslator, libchamplain-devel, anjuta-devel, dconf-devel, switcheroo-control-docs, gnome-panel-devel, libhandy-devel, gnome- desktop-devel, gtkimageview-devel, libwnck3-devel, libmodulemd-devel, libgpod-doc, libxmlb-devel, low-memory-monitor-doc, gtksourceview4-devel, libgdl-devel, gnome-bluetooth-libs-devel, devhelp-devel, parole-devel, amtk-devel, libgnome-devel, iio-sensor- proxy-docs, gobject-introspection-devel, gom-devel, lasem-devel, dbus- doc, unique3-docs, exo-devel, gedit-devel, gfbgraph-devel, json-glib- devel, jsonrpc-glib-devel, xfconf-devel, libfm-devel-docs, gupnp-docs, poppler-glib-doc, graphene-devel) [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [x]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 10240 bytes in 1 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [x]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [!]: SourceX tarball generation or download is documented. Note: Package contains tarball without URL, check comments [!]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Fully versioned dependency in subpackages if applicable. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: The placement of pkgconfig(.pc) files are correct. [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [?]: Large data in /usr/share should live in a noarch subpackage if package is arched. Note: Arch-ed rpms have a total of 1075200 bytes in /usr/share [x]: Rpmlint is run on debuginfo package(s). Note: No rpmlint messages. [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: libgnt-2.14.0-1.fc33.x86_64.rpm libgnt-devel-2.14.0-1.fc33.x86_64.rpm libgnt-debuginfo-2.14.0-1.fc33.x86_64.rpm libgnt-debugsource-2.14.0-1.fc33.x86_64.rpm libgnt-2.14.0-1.fc33.src.rpm libgnt.x86_64: W: spelling-error %description -l en_US ncurses -> nurses, curses, n curses libgnt-devel.x86_64: W: spelling-error Summary(en_US) Developmentfiles -> Development files, Development-files, Developmental libgnt.src: W: spelling-error %description -l en_US ncurses -> nurses, curses, n curses libgnt.src: W: invalid-url Source0: libgnt-2.14.0.tar.gz 5 packages and 0 specfiles checked; 0 errors, 4 warnings. Rpmlint (debuginfo) ------------------- Checking: libgnt-debuginfo-2.14.0-1.fc33.x86_64.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings. Rpmlint (installed packages) ---------------------------- warning: Found bdb Packages database while attempting sqlite backend: using bdb backend. warning: Found bdb Packages database while attempting sqlite backend: using bdb backend. libgnt-devel.x86_64: W: spelling-error Summary(en_US) Developmentfiles -> Development files, Development-files, Developmental libgnt-devel.x86_64: W: invalid-url URL: https://keep.imfreedom.org/libgnt/libgnt/ <urlopen error [Errno -2] Name or service not known> warning: Found bdb Packages database while attempting sqlite backend: using bdb backend. libgnt-debuginfo.x86_64: W: invalid-url URL: https://keep.imfreedom.org/libgnt/libgnt/ <urlopen error [Errno -2] Name or service not known> warning: Found bdb Packages database while attempting sqlite backend: using bdb backend. libgnt-debugsource.x86_64: W: invalid-url URL: https://keep.imfreedom.org/libgnt/libgnt/ <urlopen error [Errno -2] Name or service not known> warning: Found bdb Packages database while attempting sqlite backend: using bdb backend. libgnt.x86_64: W: spelling-error %description -l en_US ncurses -> nurses, curses, n curses libgnt.x86_64: W: invalid-url URL: https://keep.imfreedom.org/libgnt/libgnt/ <urlopen error [Errno -2] Name or service not known> 4 packages and 0 specfiles checked; 0 errors, 6 warnings. Unversioned so-files -------------------- libgnt: /usr/lib64/gnt/irssi.so libgnt: /usr/lib64/gnt/s.so Requires -------- libgnt (rpmlib, GLIBC filtered): libc.so.6()(64bit) libglib-2.0.so.0()(64bit) libgmodule-2.0.so.0()(64bit) libgnt.so.0()(64bit) libgobject-2.0.so.0()(64bit) libncursesw.so.6()(64bit) libpanelw.so.6()(64bit) libpthread.so.0()(64bit) libtinfo.so.6()(64bit) libxml2.so.2()(64bit) libxml2.so.2(LIBXML2_2.4.30)(64bit) libxml2.so.2(LIBXML2_2.6.0)(64bit) rtld(GNU_HASH) libgnt-devel (rpmlib, GLIBC filtered): /usr/bin/pkg-config libgnt(x86-64) libgnt.so.0()(64bit) pkgconfig(glib-2.0) pkgconfig(gmodule-2.0) pkgconfig(gobject-2.0) pkgconfig(libxml-2.0) libgnt-debuginfo (rpmlib, GLIBC filtered): libgnt-debugsource (rpmlib, GLIBC filtered): Provides -------- libgnt: libgnt libgnt(x86-64) libgnt.so.0()(64bit) libgnt-devel: libgnt-devel libgnt-devel(x86-64) pkgconfig(gnt) libgnt-debuginfo: debuginfo(build-id) libgnt-debuginfo libgnt-debuginfo(x86-64) libgnt-debugsource: libgnt-debugsource libgnt-debugsource(x86-64) Generated by fedora-review 0.7.5 (5fa5b7e) last change: 2020-02-16 Command line :/usr/bin/fedora-review -b 1857785 Buildroot used: fedora-rawhide-x86_64 Active plugins: C/C++, Generic, Shell-api Disabled plugins: fonts, PHP, Ocaml, Haskell, Perl, Java, SugarActivity, Python, R Disabled flags: EPEL6, EPEL7, DISTTAG, BATCH, EXARCH
And I were incorrect, there are much nicer url to get sources from already. You can find them under upper right corner of page [1]. Source0: https://dl.bintray.com/pidgin/releases/%{name}-%{version}.tar.xz Source1: https://dl.bintray.com/pidgin/releases/%{name}-%{version}.tar.xz.asc 1. https://bintray.com/pidgin/releases/libgnt/2.14.0#files
Thanks for the review, new version: Spec URL: https://jskarvad.fedorapeople.org/libgnt/libgnt.spec SRPM URL: https://jskarvad.fedorapeople.org/libgnt/libgnt-2.14.0-2.fc31.src.rpm
Nice. Note you have typo in doc summary. Summary: Decumentation for libgnt
(In reply to Petr Menšík from comment #5) > Nice. Note you have typo in doc summary. > > Summary: Decumentation for libgnt Thanks, I will fix it.
(fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/libgnt
(In reply to Petr Menšík from comment #3) > And I were incorrect, there are much nicer url to get sources from already. > You can find them under upper right corner of page [1]. > > Source0: > https://dl.bintray.com/pidgin/releases/%{name}-%{version}.tar.xz > Source1: > https://dl.bintray.com/pidgin/releases/%{name}-%{version}.tar.xz.asc > > 1. https://bintray.com/pidgin/releases/libgnt/2.14.0#files Also at: https://sf.net/projects/pidgin/files/libgnt/