Bug 1858106 - umlgraph fails to build with java-11-openjdk [NEEDINFO]
Summary: umlgraph fails to build with java-11-openjdk
Alias: None
Product: Fedora
Classification: Fedora
Component: umlgraph
Version: 33
Hardware: All
OS: All
Target Milestone: ---
Assignee: Orphan Owner
QA Contact: Fedora Extras Quality Assurance
: 1865591 (view as bug list)
Depends On:
Blocks: F33FTBFS Java11
TreeView+ depends on / blocked
Reported: 2020-07-16 22:26 UTC by jiri vanek
Modified: 2020-10-01 18:42 UTC (History)
7 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Last Closed: 2020-10-01 18:42:51 UTC
Type: ---
releng: needinfo? (extras-orphan)

Attachments (Terms of Use)
build.log (35.12 KB, text/plain)
2020-07-21 15:54 UTC, Raphael Groner
no flags Details

System ID Private Priority Status Summary Last Updated
Github dspinellis UMLGraph issues 60 0 None open Doclets in Java 11 2020-10-01 18:40:25 UTC

Description jiri vanek 2020-07-16 22:26:59 UTC
umlgraph fails to build with java-11-openjdk as sytem JDK. See https://fedoraproject.org/wiki/Changes/Java11 .
See especially part about known failures: https://fedoraproject.org/wiki/Changes/Java11#common_issues_packagers_can_face_and_gathered_solutions

For the build logs, see: https://koji.fedoraproject.org/koji/taskinfo?taskID=47163337
We run the rebuild longer then 10days ago. Log may be gone. Also your package may be passing in regular rawhide.
To reproduce, simply: fedpkg clone umlgraph; cd umlgraph;  fedpkg build --target f33-java11; #The target is crucial.

We run two reruns your package failed both.

We had tried 650 packages, and 500 had passed, so the java-11-openjdk will be system JDK in f33, and you should fix your package if you want to keep it alive. Usually the fix is simple, and best is to update the package to latest upstream version.
There will be usual mass rebuild once f33 branches. You may got another FTBFS bug.
Let us know here if you have any questions, here in bug, or at java-devel.org .

We'd appreciate help from the people who know this package best, but if you don't want to work on this now, let us know so we can try to work around it on our side if needed.

Comment 1 jiri vanek 2020-07-17 04:06:59 UTC
highlight: This was rebuild in sidetag f33-java11. Thus --target is really necessary to reproduce failure.
please note: This side tag, f33-java11, will be merged to main f33 buildroot in aprox 14 days.

Comment 2 Raphael Groner 2020-07-21 15:54:38 UTC
Created attachment 1701931 [details]

Comment 3 Raphael Groner 2020-07-21 15:55:46 UTC
Relevant snippet from build.log:

    [javac] /builddir/build/BUILD/UMLGraph-R5_7_2/src/main/java/org/umlgraph/doclet/UmlGraphDoc.java:22: error: package com.sun.tools.doclets.standard is not visible
    [javac] import com.sun.tools.doclets.standard.Standard;
    [javac]                             ^
    [javac]   (package com.sun.tools.doclets.standard is declared in module jdk.javadoc, which does not export it)

This seems a bug in javadoc.

Comment 4 Fabio Valentini 2020-07-21 15:59:50 UTC
No, com.sun.tools.doclets.standard.Standard class is deprecated as of Java 9 and was removed in Java 11.

See: https://docs.oracle.com/javase/9/docs/api/com/sun/tools/doclets/standard/Standard.html

Comment 5 Raphael Groner 2020-07-22 04:25:01 UTC
Obviously report this bug to upstream. 
UMLGraph-R5_7_2 is the official release since year 2014 but github shows more recent commits till 2019.

Comment 6 Raphael Groner 2020-07-22 14:45:56 UTC
What about hardly depend on jdk8 then to be able to still build javadoc as well? Main sources could get build with any current jdk in parallel.

Comment 7 Fabio Valentini 2020-07-22 14:57:41 UTC
Uh ... maybe that would work.

Different question: how attached are you to this package? Nothing else in fedora depends on it. :)

Comment 8 jiri vanek 2020-07-22 14:59:01 UTC
That is funny. Moreover live project without releas ein last 6 years.  Maybe you can build tip?
You can build by jdk8, pacakge will work for a while, but it is just delaying its death.
If it would be just javadoc, I would tell, jsut skipp javadoc generation, or really build it elsewhere.

Comment 9 jiri vanek 2020-07-22 15:01:36 UTC
 declared in module jdk.javadoc, which does not export 

In both compilation and rutime, you can extend whatmodule exports - by add-exports, add-opens and friends:
/usr/lib/jvm/java-11-openjdk/bin/java -X 2>&1 | grep -e -add 
    --add-reads <module>=<target-module>(,<target-module>)*
    --add-exports <module>/<package>=<target-module>(,<target-module>)*
    --add-opens <module>/<package>=<target-module>(,<target-module>)*
/usr/lib/jvm/java-11-openjdk/bin/javac -X 2>&1 | grep -e -add 
  --add-exports <module>/<package>=<other-module>(,<other-module>)*
  --add-reads <module>=<other-module>(,<other-module>)*

Comment 10 Fabio Valentini 2020-07-22 15:03:13 UTC
This is not about building javadocs in *this* package, umlgraph provides a way for *other* packages to build custom Javadocs.

Comment 11 jiri vanek 2020-07-22 15:03:59 UTC
(In reply to Fabio Valentini from comment #7)
> Uh ... maybe that would work.
> Different question: how attached are you to this package? Nothing else in
> fedora depends on it. :)

umlgraph.org was sold. I would say, kill the package:(

Comment 12 Raphael Groner 2020-07-22 15:53:37 UTC
If there's a valueable alternative to generate UML, I'd be fine to drop this package.

Comment 13 Fabio Valentini 2020-07-23 08:36:32 UTC
Maybe plantuml? It's currently also FTBFS with Java 11, but the failure looks easy to fix (unsetting / setting correct classpath for javadoc generation).

Comment 14 Raphael Groner 2020-07-23 10:29:53 UTC
Trend goes towards CANTFIX. The alternative with plantuml looks interesting, thanks.

Comment 15 Fabio Valentini 2020-07-23 10:49:53 UTC
FYI, I have just fixed the plantuml build (it was a bit trickier than I thought).

Comment 16 Raphael Groner 2020-07-23 11:55:46 UTC
Disabled generation of javadoc. There's another error:

+ xmvn-install -R .xmvn-reactor -n umlgraph -d /builddir/build/BUILDROOT/umlgraph-5.7.2-24.fc33.x86_64
[ERROR] Artifact installation failed
org.fedoraproject.xmvn.tools.install.ArtifactInstallationException: Artifact path points to a non-existent file: /builddir/build/BUILD/UMLGraph-R5_7_2/lib/umlgraph.jar
        at org.fedoraproject.xmvn.tools.install.impl.InstallationPlan.validate(InstallationPlan.java:100)
        at org.fedoraproject.xmvn.tools.install.impl.InstallationPlan.<init>(InstallationPlan.java:59)
        at org.fedoraproject.xmvn.tools.install.impl.DefaultInstaller.install(DefaultInstaller.java:308)
        at org.fedoraproject.xmvn.tools.install.cli.InstallerCli.run(InstallerCli.java:58)
        at org.fedoraproject.xmvn.tools.install.cli.InstallerCli.main(InstallerCli.java:83)

Comment 17 Raphael Groner 2020-08-04 07:02:15 UTC
*** Bug 1865591 has been marked as a duplicate of this bug. ***

Comment 18 Ben Cotton 2020-08-11 15:25:02 UTC
This bug appears to have been reported against 'rawhide' during the Fedora 33 development cycle.
Changing version to 33.

Comment 19 Raphael Groner 2020-09-05 10:59:58 UTC
(In reply to Fabio Valentini from comment #15)
> FYI, I have just fixed the plantuml build (it was a bit trickier than I
> thought).

Going to orphan the umlgraph package then, in favor of plantuml. Thanks.

Comment 20 Fedora Release Engineering 2020-09-30 18:40:51 UTC
Dear Maintainer,

your package has an open Fails To Build From Source bug for Fedora 33.
Action is required from you.

If you can fix your package to build, perform a build in koji, and either create
an update in bodhi, or close this bug without creating an update, if updating is
not appropriate [1]. If you are working on a fix, set the status to ASSIGNED to
acknowledge this. If you have already fixed this issue, please close this Bugzilla report.

Following the policy for such packages [2], your package will be orphaned if
this bug remains in NEW state more than 8 weeks (not sooner than 2020-09-10).

A week before the mass branching of Fedora 34 according to the schedule [3],
any packages not successfully rebuilt at least on Fedora 32 will be
retired regardless of the status of this bug.

[1] https://fedoraproject.org/wiki/Updates_Policy
[2] https://docs.fedoraproject.org/en-US/fesco/Fails_to_build_from_source_Fails_to_install/
[3] https://fedorapeople.org/groups/schedule/f-34/f-34-key-tasks.html

Comment 21 Raphael Groner 2020-10-01 18:42:51 UTC
Already orphaned.

Note You need to log in before you can comment on or make changes to this bug.