Spec URL: https://eclipseo.fedorapeople.org/for-review/qt-avif-image-plugin.spec SRPM URL: https://eclipseo.fedorapeople.org/for-review/qt-avif-image-plugin-0.3.0-1.fc33.src.rpm Description: Qt plug-in to allow Qt and KDE based applications to read/write AVIF images. Fedora Account System Username: eclipseo
Successful build: https://copr.fedorainfracloud.org/coprs/eclipseo/avif/build/1563275/
I can review this.
Created attachment 1702012 [details] Rawhide build.log Looks like libavif in Rawhide is too old: CMake Warning at CMakeLists.txt:25 (find_package): Could not find a configuration file for package "libavif" that is compatible with requested version "0.8.0". The following configuration files were considered but not accepted: /usr/lib64/cmake/libavif/libavif-config.cmake, version: 0.7.3 /lib64/cmake/libavif/libavif-config.cmake, version: 0.7.3 -- libavif not found! Searching for local build.
Yes I sent a PR to the maintainer, but we have a slight disagrement over the config.
New Spec URL: https://eclipseo.fedorapeople.org/for-review/qt-avif-image-plugin.spec New SRPM URL: https://eclipseo.fedorapeople.org/for-review/qt-avif-image-plugin-0.3.1-1.fc34.src.rpm
Ack, re-reviewing
Looks mostly fine, but there's a problem with directory ownership -- consider either depending on kf5-filesystem, or if this is useful for Qt apps without having KDE installed, just have this package own those directories too. Also require shared-mime-info for /usr/share/mime Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed Issues: ======= - Package installs a %{name}.desktop using desktop-file-install or desktop- file-validate if there is such a file. ^ this seems a false positive ===== MUST items ===== C/C++: [x]: Package does not contain kernel modules. [x]: Package contains no static executables. [-]: Development (unversioned) .so files in -devel subpackage, if present. Note: Unversioned so-files in private %_libdir subdirectory (see attachment). Verify they are not in ld path. [x]: If your application is a C or C++ application you must list a BuildRequires against gcc, gcc-c++ or clang. [x]: Header files in -devel subpackage, if present. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "BSD 2-clause "Simplified" License", "Expat License BSD 2-clause "Simplified" License", "Expat License", "*No copyright* Public domain", "BSD 3-clause "New" or "Revised" License", "ISC License". 1149 files have unknown license. Detailed output of licensecheck in /home/michel/src/fedora/reviews/1858639-qt- avif-image-plugin/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [!]: Package must own all directories that it creates. Note: Directories without known owners: /usr/share/mime/packages, /usr/share/kservices5, /usr/share/mime, /usr/share/kservices5/qimageioplugins [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 10240 bytes in 1 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: No rpmlint messages. [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Package contains desktop file if it is a GUI application. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [?]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [?]: Package should compile and build into binary rpms on all supported architectures. [!]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Fully versioned dependency in subpackages if applicable. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on debuginfo package(s). Note: No rpmlint messages. [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: qt-avif-image-plugin-0.3.1-1.fc34.x86_64.rpm qt-avif-image-plugin-debuginfo-0.3.1-1.fc34.x86_64.rpm qt-avif-image-plugin-debugsource-0.3.1-1.fc34.x86_64.rpm qt-avif-image-plugin-0.3.1-1.fc34.src.rpm 4 packages and 0 specfiles checked; 0 errors, 0 warnings. Rpmlint (debuginfo) ------------------- Checking: qt-avif-image-plugin-debuginfo-0.3.1-1.fc34.x86_64.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings. Rpmlint (installed packages) ---------------------------- warning: Found bdb Packages database while attempting sqlite backend: using bdb backend. warning: Found bdb Packages database while attempting sqlite backend: using bdb backend. qt-avif-image-plugin.x86_64: W: invalid-url URL: https://github.com/novomesk/qt-avif-image-plugin <urlopen error [Errno -3] Temporary failure in name resolution> warning: Found bdb Packages database while attempting sqlite backend: using bdb backend. qt-avif-image-plugin-debugsource.x86_64: W: invalid-url URL: https://github.com/novomesk/qt-avif-image-plugin <urlopen error [Errno -3] Temporary failure in name resolution> warning: Found bdb Packages database while attempting sqlite backend: using bdb backend. qt-avif-image-plugin-debuginfo.x86_64: W: invalid-url URL: https://github.com/novomesk/qt-avif-image-plugin <urlopen error [Errno -3] Temporary failure in name resolution> 3 packages and 0 specfiles checked; 0 errors, 3 warnings. Unversioned so-files -------------------- qt-avif-image-plugin: /usr/lib64/qt5/plugins/imageformats/libqavif.so Source checksums ---------------- https://github.com/novomesk/qt-avif-image-plugin/archive/v0.3.1/qt-avif-image-plugin-0.3.1.tar.gz : CHECKSUM(SHA256) this package : ae734b63ad207b147667d34d04932c5309ad9ac282925f2dc00bb36d43ff7ce7 CHECKSUM(SHA256) upstream package : ae734b63ad207b147667d34d04932c5309ad9ac282925f2dc00bb36d43ff7ce7 Requires -------- qt-avif-image-plugin (rpmlib, GLIBC filtered): /bin/sh libQt5Core.so.5()(64bit) libQt5Core.so.5(Qt_5)(64bit) libQt5Core.so.5(Qt_5.14)(64bit) libQt5Gui.so.5()(64bit) libQt5Gui.so.5(Qt_5)(64bit) libavif.so.6()(64bit) libc.so.6()(64bit) libstdc++.so.6()(64bit) libstdc++.so.6(CXXABI_1.3)(64bit) libstdc++.so.6(CXXABI_1.3.9)(64bit) rtld(GNU_HASH) qt-avif-image-plugin-debuginfo (rpmlib, GLIBC filtered): qt-avif-image-plugin-debugsource (rpmlib, GLIBC filtered): Provides -------- qt-avif-image-plugin: libqavif.so()(64bit) qt-avif-image-plugin qt-avif-image-plugin(x86-64) qt-avif-image-plugin-debuginfo: debuginfo(build-id) qt-avif-image-plugin-debuginfo qt-avif-image-plugin-debuginfo(x86-64) qt-avif-image-plugin-debugsource: qt-avif-image-plugin-debugsource qt-avif-image-plugin-debugsource(x86-64) Generated by fedora-review 0.7.5 (5fa5b7e) last change: 2020-02-16 Command line :/usr/bin/fedora-review -b 1858639 Buildroot used: fedora-rawhide-x86_64 Active plugins: C/C++, Generic, Shell-api Disabled plugins: R, Haskell, Python, fonts, Java, Perl, PHP, Ocaml, SugarActivity Disabled flags: EPEL6, EPEL7, DISTTAG, BATCH, EXARCH
Thanks for the review! I added Requires for shared-mime-info and kf5-filesystem.
That addresses the remaining issues. APPROVED
(fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/qt-avif-image-plugin
FEDORA-2020-9c4dd47cd0 has been submitted as an update to Fedora 33. https://bodhi.fedoraproject.org/updates/FEDORA-2020-9c4dd47cd0
FEDORA-2020-9c4dd47cd0 has been pushed to the Fedora 33 testing repository. In short time you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --advisory=FEDORA-2020-9c4dd47cd0 \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2020-9c4dd47cd0 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
FEDORA-2020-9c4dd47cd0 has been pushed to the Fedora 33 stable repository. If problem still persists, please make note of it in this bug report.