Bug 1858765

I'm not able to reproduce this for a local conversion.

For example I would expect this to fail with the "Inappropriate ioctl for device"
(it fails because it's not a real guest, but that is expected):

$ guestfish -N part luks-format /dev/sda1 0 
Enter key or passphrase ("key"): 123456

$ echo '123456' | virt-v2v --keys-from-stdin -i disk test1.img -o null
[   0.0] Opening the source -i disk test1.img
[   0.1] Creating an overlay to protect the source from being modified
[   0.2] Opening the overlay
[   6.4] Inspecting the overlay
virt-v2v: error: inspection could not detect the source guest (or physical 
machine).

Also I tried the same thing with a real Fedora LUKS local disk and
that didn't fail.

So I suspect this has something to do with the remote input, but I've
no idea what at the moment.

Oh hang on, this machine has 4 disks each requiring a passphrase.

It works if I type the passphrases in manually (the same one each time):

$ virt-v2v -ic 'vpx://root.73.141/data/10.73.75.219/?no_verify=1' -ip /tmp/passwd esx6.7-rhel7.8-swap_luks-non_os_3luks-redhat123 --keys-from-stdin -o null
[   0.0] Opening the source -i libvirt -ic vpx://root.73.141/data/10.73.75.219/?no_verify=1 esx6.7-rhel7.8-swap_luks-non_os_3luks-redhat123
[  23.7] Creating an overlay to protect the source from being modified
[  29.9] Opening the overlay
Enter key or passphrase ("/dev/sda3"): 
Enter key or passphrase ("/dev/sdb1"): 
Enter key or passphrase ("/dev/sdc1"): 
Enter key or passphrase ("/dev/sdd1"): 
[ 227.5] Inspecting the overlay
...

It also works if I echo the passphrase 4 times:

$ echo -e 'redhat123\nredhat123\nredhat123\nredhat123\n' |
  virt-v2v -ic 'vpx://root.73.141/data/10.73.75.219/?no_verify=1' -ip /tmp/passwd esx6.7-rhel7.8-swap_luks-non_os_3luks-redhat123 --keys-from-stdin -o null
[   0.0] Opening the source -i libvirt -ic vpx://root.73.141/data/10.73.75.219/?no_verify=1 esx6.7-rhel7.8-swap_luks-non_os_3luks-redhat123
[  23.4] Creating an overlay to protect the source from being modified
[  29.8] Opening the overlay
[ 163.7] Inspecting the overlay
...

ISTR last year there was an "energetic" debate about whether we should try the
same passphrase against all disks, and that idea was rejected, so you have
to repeat the passphrase once for each disk as above.

Hi rjones,

   You're right, I didn't set disk password correctly during using option --keys-from-stdin, please help to close the bug as NOTABUG, thanks!

# echo -e 'redhat123\nredhat123\nredhat123\nredhat123\n'  | virt-v2v -ic vpx://root.73.141/data/10.73.75.219/?no_verify=1 -it vddk -io vddk-libdir=/home/vmware-vix-disklib-distrib -io vddk-thumbprint=1F:97:34:5F:B6:C2:BA:66:46:CB:1A:71:76:7D:6B:50:1E:03:00:EA  -ip /home/passwd esx6.7-rhel7.8-swap_luks-non_os_3luks-redhat123 --keys-from-stdin
[   0.0] Opening the source -i libvirt -ic vpx://root.73.141/data/10.73.75.219/?no_verify=1 esx6.7-rhel7.8-swap_luks-non_os_3luks-redhat123 -it vddk  -io vddk-libdir=/home/vmware-vix-disklib-distrib -io vddk-thumbprint=1F:97:34:5F:B6:C2:BA:66:46:CB:1A:71:76:7D:6B:50:1E:03:00:EA
[   5.2] Creating an overlay to protect the source from being modified
[   9.3] Opening the overlay
[  20.3] Inspecting the overlay
virt-v2v: warning: mount: mount_stub: 
/dev/mapper/luks-f8f30718-1587-4ce1-8588-87374d273280: No such file or 
directory (ignored)
virt-v2v: warning: mount: mount_stub: 
/dev/mapper/luks-22b0edbc-4300-42f0-b182-43d595fd45c7: No such file or 
directory (ignored)
virt-v2v: warning: mount: mount_stub: 
/dev/mapper/luks-b4be9a0b-187b-45c2-ad52-3b6441aca6e2: No such file or 
directory (ignored)
[  57.2] Checking for sufficient free disk space in the guest
[  57.2] Estimating space required on target for each disk
[  57.2] Converting Red Hat Enterprise Linux Server 7.8 Beta (Maipo) to run on KVM
....

# cat /home/disk-passwd |  virt-v2v -ic vpx://root.73.141/data/10.73.75.219/?no_verify=1 -it vddk -io vddk-libdir=/home/vmware-vix-disklib-distrib -io vddk-thumbprint=1F:97:34:5F:B6:C2:BA:66:46:CB:1A:71:76:7D:6B:50:1E:03:00:EA  -ip /home/passwd esx6.7-rhel7.8-swap_luks-non_os_3luks-redhat123 --keys-from-stdin
[   0.0] Opening the source -i libvirt -ic vpx://root.73.141/data/10.73.75.219/?no_verify=1 esx6.7-rhel7.8-swap_luks-non_os_3luks-redhat123 -it vddk  -io vddk-libdir=/home/vmware-vix-disklib-distrib -io vddk-thumbprint=1F:97:34:5F:B6:C2:BA:66:46:CB:1A:71:76:7D:6B:50:1E:03:00:EA
[   5.2] Creating an overlay to protect the source from being modified
[   9.3] Opening the overlay
[  21.2] Inspecting the overlay
....

I think the doc could be improved about this if it's not a general usage?

I've pushed this small docs improvement:

https://github.com/libguestfs/virt-v2v/commit/7ba65d14c0139dcf7fec45d33cee67c0f6737dd2

The new documentation for virt-v2v(1) reads:

       --keys-from-stdin
           Read key or passphrase parameters from stdin.  The default is to
           try to read passphrases from the user by opening /dev/tty.

           If there are multiple encrypted devices then you may need to supply
           multiple keys on stdin, one per line.

           Note --keys-from-stdin only applies to keys and passphrases for
           encrypted devices and partitions, not for passwords used to connect
           to remote servers.

As this is only a tiny documentation change it's probably not worth
adding it to RHEL.  We'll get the fix next time we rebase.  So you can
close this bug as NOTABUG if you want.

(In reply to Richard W.M. Jones from comment #5)
> I've pushed this small docs improvement:
> 
> https://github.com/libguestfs/virt-v2v/commit/
> 7ba65d14c0139dcf7fec45d33cee67c0f6737dd2

Note that this situation is not specific to virt-v2v.
The same issue applies also to any other libguestfs tool that can open encrypted devices.
The majority of them can do that.

Yup, the fix is generic :-)  (Although to be fair I didn't update
the common submodule in libguestfs yet)

Verify the bug with builds:
virt-v2v-1.42.0-6.module+el8.3.0+7898+13f907d5.x86_64

Steps:
1.Update the virt-v2v to the latest build and check info in man page 
       --keys-from-stdin
           Read key or passphrase parameters from stdin.  The default is to
           try to read passphrases from the user by opening /dev/tty.

           If there are multiple encrypted devices then you may need to
           supply multiple keys on stdin, one per line.

           Note --keys-from-stdin only applies to keys and passphrases for
           encrypted devices and partitions, not for passwords used to
           connect to remote servers.

Results:
virt-v2v has updated man page about how to use --keys-from-stdin.

Hi,Rjones:
I think add "split by '\n'" after "one per line" is more clear for new user.

"one per line" means they are split by \n (new line) characters IMHO.  I believe
the text as it stands is fine.

As comment 10 and comment 11,now change the bug from ON_QA to VERIFIED.

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (virt:8.3 bug fix and enhancement update), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2020:5137