Note: This bug is displayed in read-only format because the product is no longer active in Red Hat Bugzilla.

Bug 1860002

Summary: [CNV][V2V] User can select "bridged" network type for NIC bound to pod network
Product: OpenShift Container Platform Reporter: Igor Braginsky <ibragins>
Component: Console Kubevirt PluginAssignee: Tomas Jelinek <tjelinek>
Status: CLOSED ERRATA QA Contact: Igor Braginsky <ibragins>
Severity: high Docs Contact:
Priority: medium    
Version: 4.4CC: aos-bugs, apinnick, bthurber, cnv-qe-bugs, istein, phoracek, tjelinek
Target Milestone: ---Flags: istein: needinfo-
Target Release: 4.6.0   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Cause: The selection for "bridged" network was available for pod network. Consequence: it was possible to create in invalid configuration using the UI Fix: the "briudged" option is filtered out from the UI selection for pod network Result: now it is not possible to create this invalid configuration
Story Points: ---
Clone Of: Environment:
Last Closed: 2020-10-27 16:16:44 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Attachments:
Description Flags
Bridge network connection type is available none

Description Igor Braginsky 2020-07-23 14:06:31 UTC
Created attachment 1702238 [details]
Bridge network connection type is available

Description of problem:User can select "bridged" network type for NIC bound to pod network, as result outside network will not be reachable from VM


Version-Release number of selected component (if applicable): 2.4.0


How reproducible: 100%


Steps to Reproduce: 
1. Run migration wizard
2. Go to NIC section and check UI

Actual results: For the POD network only masquerading network type should be available


Expected results:


Additional info:

Comment 4 Tomas Jelinek 2020-07-24 08:44:19 UTC
> I believe we would have to implement a filter in the UI for this which will not make 2.4.

Indeed. And we have implemented the filter for OCP 4.6 (e.g. CNV 2.5): https://github.com/openshift/console/pull/5637
So I would propose to move this under the UI and move it to on_qa. Agree?

Comment 5 Brett Thurber 2020-07-24 16:29:38 UTC
(In reply to Tomas Jelinek from comment #4)
> > I believe we would have to implement a filter in the UI for this which will not make 2.4.
> 
> Indeed. And we have implemented the filter for OCP 4.6 (e.g. CNV 2.5):
> https://github.com/openshift/console/pull/5637
> So I would propose to move this under the UI and move it to on_qa. Agree?

+1.  Moved over.  Thanks!

Comment 6 Igor Braginsky 2020-07-25 09:34:23 UTC
I think this should be documented, or there is a chance that user will face issue with not working network inside his VM.
Currently this is documented on the level of OCP, but this is never mentioned on the level of CNV or migration to CNV.
I think we should add pointer to respective document somewhere in migration flow description

Comment 8 Ilanit Stein 2020-08-06 12:04:21 UTC
@Avital,
Would you please address the doc text for OCP-4.5/CNV-2.4

@Tomas,
If this is fixed in 4.6, then need target it to 4.6 and not 4.5.

Also does  https://github.com/openshift/console/pull/5637 addresses:
"When connecting to POD network, only masquerading should be used, when to Multus network - only bridge." ?

Thanks.

Comment 10 Tomas Jelinek 2020-08-10 06:58:03 UTC
(In reply to Ilanit Stein from comment #8)
> @Tomas,
> If this is fixed in 4.6, then need target it to 4.6 and not 4.5.

indeed, moved

> 
> Also does  https://github.com/openshift/console/pull/5637 addresses:
> "When connecting to POD network, only masquerading should be used, when to
> Multus network - only bridge." ?

for pod pod network only masquerade is allowed, for multus one it is bridge and sriov which IIUC is correct.
@Petr please keep me honest here

> 
> Thanks.

Comment 11 Petr Horáček 2020-08-10 08:01:46 UTC
> for pod pod network only masquerade is allowed, for multus one it is bridge and sriov which IIUC is correct.
> @Petr please keep me honest here

That's correct. Ideally we would show "sriov" only when the selected network is an "sriov" network, but that is for another BZ.

Comment 12 Igor Braginsky 2020-08-17 11:47:29 UTC
Doc looks fine

Comment 13 Ilanit Stein 2020-08-17 18:37:22 UTC
This is the UI bug for picking SRIOV only:
Bug 1862918 - [v2v] User should only select SRIOV network when importing vm with SRIOV network

Comment 14 Ilanit Stein 2020-08-17 18:47:39 UTC
@Avital,

I see was added to the doc: 
'You must select the `masquerade` binding method"

Does it come along with POD network?

Comment 15 Avital Pinnick 2020-08-18 06:50:49 UTC
(In reply to Ilanit Stein from comment #14)
> @Avital,
> 
> I see was added to the doc: 
> 'You must select the `masquerade` binding method"
> 
> Does it come along with POD network?

That seems to be what Petr says in https://bugzilla.redhat.com/show_bug.cgi?id=1860002#c11 and Tomas, in https://bugzilla.redhat.com/show_bug.cgi?id=1860002#c10

Comment 16 Avital Pinnick 2020-08-19 14:05:21 UTC
Documentation updated for CNV 2.5 (OCP 4.6) only, since this will be fixed in 4.6.

Comment 18 Igor Braginsky 2020-10-12 06:28:26 UTC
Verified this bug on CNV 2.5, one can select only proper network type for the NIC

Comment 20 errata-xmlrpc 2020-10-27 16:16:44 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (OpenShift Container Platform 4.6 GA Images), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2020:4196