Bug 186002 - Review Request: archmage - Extensible reader/decompiler of files in CHM format
Summary: Review Request: archmage - Extensible reader/decompiler of files in CHM format
Keywords:
Status: CLOSED NEXTRELEASE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Shahms E. King
QA Contact: Fedora Package Reviews List
URL:
Whiteboard:
Depends On:
Blocks: FE-ACCEPT
TreeView+ depends on / blocked
 
Reported: 2006-03-20 21:39 UTC by Patrice Dumas
Modified: 2007-11-30 22:11 UTC (History)
0 users

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2006-04-19 21:24:50 UTC
Type: ---
Embargoed:


Attachments (Terms of Use)

Description Patrice Dumas 2006-03-20 21:39:40 UTC
SRPM Name or Url: 
http://www.environnement.ens.fr/perso/dumas/fc-srpms/python-archmod-0.0.7-1.src.rpm
Description: 

arCHMage - extensible reader/decompiler of files in CHM format 
(Microsoft HTML help, also known as Compiled HTML).
arCHMage is based on chmlib by Jed Wing and is written on python.

Comment 1 Shahms E. King 2006-04-18 17:40:03 UTC
Good:
 - rpmlint gives no errors
 - builds in mach just fine
 - spec file and package name match (but see below)
 - GPL license, license included, etc.
 - md5sum matches upstream
 - it meets the rest of the MUST clauses

The only "bad" thing I could find is that I don't think python-archmod is the
most appropriate name as the python module itself is secondary to the binary
functionality, if I'm not mistaken. It seems similar in this regard to bzr and
yum, and should be named appropriately.

Other than that, the package looks good.

Comment 2 Patrice Dumas 2006-04-18 21:50:18 UTC
I followed the packaging guidelines blindly... The packaging guidelines are in
my opinion quite misleading on that subject. For perl it doesn't matter, as
there is CPAN which is the reference for what is a module and what isn't for
python there should be a word to help packagers choice. I have uploaded a srpm
for archmage here:
http://www.environnement.ens.fr/perso/dumas/fc-srpms/archmage-0.0.7-1.src.rpm

Should archmage provides: python-archmod, or even conflicts?

Comment 3 Shahms E. King 2006-04-19 15:01:20 UTC
Yes, the packaging guidelines are unclear on that.  It's something that needs to
be clarified. I'd leave out the provides.

- rpmlint (still) gives no errors and there are no other regressions, the
package looks good.

ACCEPTED

Comment 4 Patrice Dumas 2006-04-19 21:24:50 UTC
Built for devel, thanks.


Note You need to log in before you can comment on or make changes to this bug.