Red Hat Bugzilla – Bug 186002
Review Request: archmage - Extensible reader/decompiler of files in CHM format
Last modified: 2007-11-30 17:11:27 EST
SRPM Name or Url:
arCHMage - extensible reader/decompiler of files in CHM format
(Microsoft HTML help, also known as Compiled HTML).
arCHMage is based on chmlib by Jed Wing and is written on python.
- rpmlint gives no errors
- builds in mach just fine
- spec file and package name match (but see below)
- GPL license, license included, etc.
- md5sum matches upstream
- it meets the rest of the MUST clauses
The only "bad" thing I could find is that I don't think python-archmod is the
most appropriate name as the python module itself is secondary to the binary
functionality, if I'm not mistaken. It seems similar in this regard to bzr and
yum, and should be named appropriately.
Other than that, the package looks good.
I followed the packaging guidelines blindly... The packaging guidelines are in
my opinion quite misleading on that subject. For perl it doesn't matter, as
there is CPAN which is the reference for what is a module and what isn't for
python there should be a word to help packagers choice. I have uploaded a srpm
for archmage here:
Should archmage provides: python-archmod, or even conflicts?
Yes, the packaging guidelines are unclear on that. It's something that needs to
be clarified. I'd leave out the provides.
- rpmlint (still) gives no errors and there are no other regressions, the
package looks good.
Built for devel, thanks.