Spec URL: https://hadess.fedorapeople.org/libglib-testing/libglib-testing.spec SRPM URL: https://hadess.fedorapeople.org/libglib-testing/libglib-testing-0.1.0-1.fc32.src.rpm Description: libglib-testing is a test library providing test harnesses and mock classes which complement the classes provided by GLib. It is intended to be used by any project which uses GLib and which wants to write internal unit tests. Fedora Account System Username: hadess
Scratch build: https://koji.fedoraproject.org/koji/taskinfo?taskID=47697124
> Scratch build: https://koji.fedoraproject.org/koji/taskinfo?taskID=47697124 Make that: https://koji.fedoraproject.org/koji/taskinfo?taskID=47698432 The -devel package was uninstallable, this is fixed now.
This is a dependency of malcontent, which is packaged here: https://hadess.fedorapeople.org/malcontent/
URL: https://gitlab.freedesktop.org/pwithnall/libglib-testing → URL: https://gitlab.gnome.org/pwithnall/libglib-testing - Not needed anymore except EPEL7: %ldconfig_scriptlets - In order to avoid unintentional soname bump, we recommend not globing the major soname version: %{_libdir}/libglib-testing-0.so.0* - Split this at 80 characters as the package name extends by that: %description devel This package contains the pkg-config file and development headers for %{name}. - All minor things, so this package is approved but don't forget to fix the aforementioned issues before import. Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed ===== MUST items ===== C/C++: [x]: Package does not contain kernel modules. [x]: Package contains no static executables. [x]: If your application is a C or C++ application you must list a BuildRequires against gcc, gcc-c++ or clang. [x]: Header files in -devel subpackage, if present. [x]: ldconfig not called in %post and %postun for Fedora 28 and later. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. [x]: Development (unversioned) .so files in -devel subpackage, if present. Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "GNU Lesser General Public License, Version 2.1", "*No copyright* GNU Lesser General Public License", "GNU Lesser General Public License v2.1 or later". 12 files have unknown license. Detailed output of licensecheck in /home/bob/packaging/review/libglib-testing/review-libglib- testing/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [x]: Package does not own files or directories owned by other packages. [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [x]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 0 bytes in 0 files. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [?]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [-]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Fully versioned dependency in subpackages if applicable. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: The placement of pkgconfig(.pc) files are correct. [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on debuginfo package(s). Note: No rpmlint messages. [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: libglib-testing-0.1.0-1.fc34.x86_64.rpm libglib-testing-devel-0.1.0-1.fc34.x86_64.rpm libglib-testing-debuginfo-0.1.0-1.fc34.x86_64.rpm libglib-testing-debugsource-0.1.0-1.fc34.x86_64.rpm libglib-testing-0.1.0-1.fc34.src.rpm libglib-testing.x86_64: W: no-documentation libglib-testing-devel.x86_64: E: description-line-too-long C This package contains the pkg-config file and development headers for libglib-testing. 5 packages and 0 specfiles checked; 1 errors, 1 warnings.
(In reply to Robert-André Mauchin 🐧 from comment #4) > URL: https://gitlab.freedesktop.org/pwithnall/libglib-testing > > → > > URL: https://gitlab.gnome.org/pwithnall/libglib-testing Fixed. > - Not needed anymore except EPEL7: > > %ldconfig_scriptlets Fixed. > - In order to avoid unintentional soname bump, we recommend not globing the > major soname version: > > %{_libdir}/libglib-testing-0.so.0* Fixed. > - Split this at 80 characters as the package name extends by that: > > %description devel > This package contains the pkg-config file and development headers > for %{name}. Done. > - All minor things, so this package is approved but don't forget to fix the > aforementioned issues before import. Thanks!
(fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/libglib-testing
Built as libglib-testing-0.1.0-2.fc34