Bug 1861297 - Common templates - terminationGracePeriodSeconds value should be updated in the templates, default is 0
Summary: Common templates - terminationGracePeriodSeconds value should be updated in t...
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Container Native Virtualization (CNV)
Classification: Red Hat
Component: SSP
Version: 2.4.0
Hardware: Unspecified
OS: Unspecified
urgent
urgent
Target Milestone: ---
: 2.4.1
Assignee: Karel Šimon
QA Contact: Ruth Netser
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2020-07-28 09:03 UTC by Ruth Netser
Modified: 2020-09-03 20:31 UTC (History)
7 users (show)

Fixed In Version: kubevirt-ssp-operator-container-v2.4.1-3
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2020-09-03 20:31:08 UTC
Target Upstream Version:
Embargoed:

Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Github kubevirt common-templates pull 164 0 None closed increase terminationGracePeriodSeconds to 30 seconds 2020-12-20 12:04:57 UTC
Red Hat Product Errata RHBA-2020:3629 0 None None None 2020-09-03 20:31:20 UTC

Internal Links: 1861322

Description Ruth Netser 2020-07-28 09:03:13 UTC 
Description of problem:
terminationGracePeriodSeconds value is set to 0 (force stop) in common templates.
This value should be updated to a more relaxed value (K8S default is 30).

Version-Release number of selected component (if applicable):
cNV-2.4

How reproducible:
100%

Steps to Reproduce:
1. Get common templates terminationGracePeriodSeconds value
2.
3.

Actual results:
$ oc get template -n openshift rhel8-server-medium-v0.10.0 -oyaml|grep -i grace
        terminationGracePeriodSeconds: 0


Expected results:
terminationGracePeriodSeconds should be more relaxed

Additional info:
Comment 1 Roman Mohr 2020-07-28 09:27:55 UTC 
I see this as a severe mistake on our templates. We basically tell all customers to create VMs in a configuration where we almost never shut them down properly. They have about one or two seconds until they are just killed. This puts from my perspective customer workloads at risk and I would not want to mark CNV as GA with this.
Comment 3 Dan Kenigsberg 2020-07-28 09:40:19 UTC 
Yes, this is quite bad; it spells trouble to anyone creating a VM based on our templates and should be fixed ASAP.
However, it is not new to 2.4.0, and can be fixed in a 2.4.1.
Comment 4 Ruth Netser 2020-07-28 10:03:02 UTC 
Created doc bug for 2.4.0 - bug 1861322
Comment 5 Omer Yahud 2020-08-05 12:17:47 UTC 
Upstream PR: https://github.com/kubevirt/common-templates/pull/164
Comment 7 Ruth Netser 2020-08-20 12:40:54 UTC 
With CNV 2.4.1, SSP 2.4.1-3:
RHEL and Fedora templates have terminationGracePeriodSeconds: 180
Windows templates have terminationGracePeriodSeconds: 3600

Waiting for automation run output to pass the bug to verify.
Comment 8 Ruth Netser 2020-08-28 07:56:00 UTC 
Moving this bug to verified.
Opened bug 1873402 - [RFE] Deletion of running VM - VMI may be deleted long after the VM; the VM should be present in the UI until the VMI is deleted
With the updated terminationGracePeriod, VMI may still be running after the VM was deleted (up to terminationGracePeriod timeout).
Comment 12 errata-xmlrpc 2020-09-03 20:31:08 UTC 
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (OpenShift Virtualization 2.4.1 images), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2020:3629
Note You need to log in before you can comment on or make changes to this bug.